Issue #2641586 by Mac_Weber, marvin_B8: Replace deprecated usage of ...

Issue #2641586 by Mac_Weber, marvin_B8: Replace deprecated usage of  entity_create('field_storage_config') with a direct call to  FieldStorageConfig::create()

core/modules/comment/src/Tests/CommentStringIdEntitiesTest.php

@@ -9,6 +9,7 @@
 
 use Drupal\comment\Entity\CommentType;
 use Drupal\simpletest\KernelTestBase;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Tests that comment fields cannot be added to entities with non-integer IDs.
@@ -51,7 +52,7 @@ public function testCommentFieldNonStringId() {
         'target_entity_type_id' => 'entity_test_string_id',
       ));
       $bundle->save();
-      $field_storage = entity_create('field_storage_config', array(
+      $field_storage = FieldStorageConfig::create(array(
         'field_name' => 'foo',
         'entity_type' => 'entity_test_string_id',
         'settings' => array(

core/modules/config/src/Tests/ConfigExportImportUITest.php

@@ -108,7 +108,7 @@ public function testExportImport() {
 
     // Create a field.
     $this->fieldName = Unicode::strtolower($this->randomMachineName());
-    $this->fieldStorage = entity_create('field_storage_config', array(
+    $this->fieldStorage = FieldStorageConfig::create(array(
       'field_name' => $this->fieldName,
       'entity_type' => 'node',
       'type' => 'text',

core/modules/contact/src/Tests/Views/ContactFieldsTest.php

@@ -8,6 +8,7 @@
 namespace Drupal\contact\Tests\Views;
 
 use Drupal\views\Tests\ViewTestBase;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Tests which checks that no fieldapi fields are added on contact.
@@ -33,7 +34,7 @@ class ContactFieldsTest extends ViewTestBase {
   protected function setUp() {
     parent::setUp();
 
-    $this->fieldStorage = entity_create('field_storage_config', array(
+    $this->fieldStorage = FieldStorageConfig::create(array(
       'field_name' => strtolower($this->randomMachineName()),
       'entity_type' => 'contact_message',
       'type' => 'text'

core/modules/content_translation/src/Tests/ContentTranslationContextualLinksTest.php

@@ -11,6 +11,7 @@
 use Drupal\language\Entity\ConfigurableLanguage;
 use Drupal\node\Entity\NodeType;
 use Drupal\simpletest\WebTestBase;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Tests that contextual links are available for content translation.
@@ -72,7 +73,7 @@ protected function setUp() {
     $this->contentType = $this->drupalCreateContentType(array('type' => $this->bundle));
 
     // Add a field to the content type. The field is not yet translatable.
-    entity_create('field_storage_config', array(
+    FieldStorageConfig::create(array(
       'field_name' => 'field_test_text',
       'entity_type' => 'node',
       'type' => 'text',

core/modules/content_translation/src/Tests/ContentTranslationSyncImageTest.php

@@ -8,6 +8,7 @@
 namespace Drupal\content_translation\Tests;
 
 use Drupal\Core\Entity\EntityInterface;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Tests the field synchronization behavior for the image field.
@@ -49,7 +50,7 @@ protected function setupTestFields() {
     $this->fieldName = 'field_test_et_ui_image';
     $this->cardinality = 3;
 
-    entity_create('field_storage_config', array(
+    FieldStorageConfig::create(array(
       'field_name' => $this->fieldName,
       'entity_type' => $this->entityTypeId,
       'type' => 'image',

core/modules/content_translation/src/Tests/ContentTranslationTestBase.php

@@ -10,6 +10,7 @@
 use Drupal\Core\Entity\Sql\SqlContentEntityStorage;
 use Drupal\language\Entity\ConfigurableLanguage;
 use Drupal\simpletest\WebTestBase;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Base class for content translation tests.
@@ -183,7 +184,7 @@ protected function setupTestFields() {
     if (empty($this->fieldName)) {
       $this->fieldName = 'field_test_et_ui_test';
     }
-    entity_create('field_storage_config', array(
+    FieldStorageConfig::create(array(
       'field_name' => $this->fieldName,
       'type' => 'string',
       'entity_type' => $this->entityTypeId,

core/modules/datetime/src/Tests/DateTimeFieldTest.php

@@ -12,6 +12,7 @@
 use Drupal\Core\Entity\Entity\EntityViewDisplay;
 use Drupal\Core\Datetime\DrupalDateTime;
 use Drupal\simpletest\WebTestBase;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Tests Datetime field functionality.
@@ -77,7 +78,7 @@ protected function setUp() {
 
     // Create a field with settings to validate.
     $field_name = Unicode::strtolower($this->randomMachineName());
-    $this->fieldStorage = entity_create('field_storage_config', array(
+    $this->fieldStorage = FieldStorageConfig::create(array(
       'field_name' => $field_name,
       'entity_type' => 'entity_test',
       'type' => 'datetime',
@@ -624,7 +625,7 @@ function testDefaultValue() {
 
     // Create a field storage with settings to validate.
     $field_name = Unicode::strtolower($this->randomMachineName());
-    $field_storage = entity_create('field_storage_config', array(
+    $field_storage = FieldStorageConfig::create(array(
       'field_name' => $field_name,
       'entity_type' => 'node',
       'type' => 'datetime',

core/modules/datetime/src/Tests/DateTimeItemTest.php

@@ -10,6 +10,7 @@
 use Drupal\Core\Field\FieldItemListInterface;
 use Drupal\Core\Field\FieldItemInterface;
 use Drupal\field\Tests\FieldUnitTestBase;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Tests the new entity API for the date field type.
@@ -29,7 +30,7 @@ protected function setUp() {
     parent::setUp();
 
     // Create a field with settings to validate.
-    $field_storage = entity_create('field_storage_config', array(
+    $field_storage = FieldStorageConfig::create(array(
       'field_name' => 'field_datetime',
       'type' => 'datetime',
       'entity_type' => 'entity_test',

core/modules/datetime/src/Tests/Views/DateTimeHandlerTestBase.php

@@ -10,6 +10,7 @@
 use Drupal\datetime\Plugin\Field\FieldType\DateTimeItem;
 use Drupal\views\Tests\Handler\HandlerTestBase;
 use Drupal\views\Tests\ViewTestData;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Base class for testing datetime handlers.
@@ -49,7 +50,7 @@ protected function setUp() {
       'name' => 'page'
     ]);
     $node_type->save();
-    $fieldStorage = entity_create('field_storage_config', [
+    $fieldStorage = FieldStorageConfig::create([
       'field_name' => static::$field_name,
       'entity_type' => 'node',
       'type' => 'datetime',

core/modules/field/src/Entity/FieldStorageConfig.php

@@ -15,6 +15,7 @@
 use Drupal\Core\Field\FieldStorageDefinitionInterface;
 use Drupal\Core\TypedData\OptionsProviderInterface;
 use Drupal\field\FieldStorageConfigInterface;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Defines the Field storage configuration entity.
@@ -238,7 +239,7 @@ class FieldStorageConfig extends ConfigEntityBase implements FieldStorageConfigI
    *   - type: required.
    *
    * In most cases, Field entities are created via
-   * entity_create('field_storage_config', $values)), where $values is the same
+   * FieldStorageConfig::create($values)), where $values is the same
    * parameter as in this constructor.
    *
    * @see entity_create()

core/modules/field/src/Tests/Boolean/BooleanItemTest.php

@@ -10,6 +10,7 @@
 use Drupal\Core\Field\FieldItemListInterface;
 use Drupal\Core\Field\FieldItemInterface;
 use Drupal\field\Tests\FieldUnitTestBase;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Tests the new entity API for the boolean field type.
@@ -25,7 +26,7 @@ protected function setUp() {
     parent::setUp();
 
     // Create a boolean field and storage for validation.
-    entity_create('field_storage_config', array(
+    FieldStorageConfig::create(array(
       'field_name' => 'field_boolean',
       'entity_type' => 'entity_test',
       'type' => 'boolean',

core/modules/field/src/Tests/BulkDeleteTest.php

@@ -9,6 +9,7 @@
 
 use Drupal\Core\Entity\EntityInterface;
 use Drupal\field\Entity\FieldConfig;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Bulk delete storages and fields, and clean up afterwards.
@@ -105,7 +106,7 @@ protected function setUp() {
     }
 
     // Create two field storages.
-    $field_storage = entity_create('field_storage_config', array(
+    $field_storage = FieldStorageConfig::create(array(
       'field_name' => 'bf_1',
       'entity_type' => $this->entityTypeId,
       'type' => 'test_field',
@@ -113,7 +114,7 @@ protected function setUp() {
     ));
     $field_storage->save();
     $this->fieldStorages[] = $field_storage;
-    $field_storage = entity_create('field_storage_config', array(
+    $field_storage = FieldStorageConfig::create(array(
       'field_name' => 'bf_2',
       'entity_type' => $this->entityTypeId,
       'type' => 'test_field',

core/modules/field/src/Tests/DisplayApiTest.php

@@ -8,6 +8,7 @@
 namespace Drupal\field\Tests;
 
 use Drupal\Core\Entity\Entity\EntityViewMode;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Tests the field display API.
@@ -94,7 +95,7 @@ protected function setUp() {
       ),
     );
 
-    entity_create('field_storage_config', $field_storage)->save();
+    FieldStorageConfig::create($field_storage)->save();
     entity_create('field_config', $field)->save();
     // Create a display for the default view mode.
     entity_get_display($field['entity_type'], $field['bundle'], 'default')

core/modules/field/src/Tests/Email/EmailFieldTest.php

@@ -9,6 +9,7 @@
 
 use Drupal\Component\Utility\Unicode;
 use Drupal\simpletest\WebTestBase;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Tests email field functionality.
@@ -54,7 +55,7 @@ protected function setUp() {
   function testEmailField() {
     // Create a field with settings to validate.
     $field_name = Unicode::strtolower($this->randomMachineName());
-    $this->fieldStorage = entity_create('field_storage_config', array(
+    $this->fieldStorage = FieldStorageConfig::create(array(
       'field_name' => $field_name,
       'entity_type' => 'entity_test',
       'type' => 'email',

core/modules/field/src/Tests/Email/EmailItemTest.php

@@ -10,6 +10,7 @@
 use Drupal\Core\Field\FieldItemListInterface;
 use Drupal\Core\Field\FieldItemInterface;
 use Drupal\field\Tests\FieldUnitTestBase;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Tests the new entity API for the email field type.
@@ -22,7 +23,7 @@ protected function setUp() {
     parent::setUp();
 
     // Create an email field storage and field for validation.
-    entity_create('field_storage_config', array(
+    FieldStorageConfig::create(array(
       'field_name' => 'field_email',
       'entity_type' => 'entity_test',
       'type' => 'email',

core/modules/field/src/Tests/EntityReference/EntityReferenceAutoCreateTest.php

@@ -10,6 +10,7 @@
 use Drupal\Core\Field\FieldStorageDefinitionInterface;
 use Drupal\simpletest\WebTestBase;
 use Drupal\node\Entity\Node;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Tests creating new entity (e.g. taxonomy-term) from an autocomplete widget.
@@ -44,7 +45,7 @@ protected function setUp() {
     $referenced = $this->drupalCreateContentType();
     $this->referencedType = $referenced->id();
 
-    entity_create('field_storage_config', array(
+    FieldStorageConfig::create(array(
       'field_name' => 'test_field',
       'entity_type' => 'node',
       'translatable' => FALSE,

core/modules/field/src/Tests/EntityReference/EntityReferenceFieldDefaultValueTest.php

@@ -55,7 +55,7 @@ function testEntityReferenceDefaultValue() {
     $referenced_node = $this->drupalCreateNode(array('type' => 'referenced_content'));
 
     $field_name = Unicode::strtolower($this->randomMachineName());
-    $field_storage = entity_create('field_storage_config', array(
+    $field_storage = FieldStorageConfig::create(array(
       'field_name' => $field_name,
       'entity_type' => 'node',
       'type' => 'entity_reference',
@@ -118,7 +118,7 @@ function testEntityReferenceDefaultConfigValue() {
     $referenced_node_type2 = $this->drupalCreateContentType(array('type' => 'referenced_config_to_preserve'));
 
     $field_name = Unicode::strtolower($this->randomMachineName());
-    $field_storage = entity_create('field_storage_config', array(
+    $field_storage = FieldStorageConfig::create(array(
       'field_name' => $field_name,
       'entity_type' => 'node',
       'type' => 'entity_reference',

core/modules/field/src/Tests/EntityReference/EntityReferenceFieldTranslatedReferenceViewTest.php

@@ -10,6 +10,7 @@
 use Drupal\language\Entity\ConfigurableLanguage;
 use Drupal\Core\Field\FieldStorageDefinitionInterface;
 use Drupal\simpletest\WebTestBase;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Tests the translation of entity reference field display on nodes.
@@ -206,7 +207,7 @@ protected function enableTranslation() {
    * Adds term reference field for the article content type.
    */
   protected function setUpEntityReferenceField() {
-    entity_create('field_storage_config', array(
+    FieldStorageConfig::create(array(
       'field_name' => $this->referenceFieldName,
       'entity_type' => $this->testEntityTypeName,
       'type' => 'entity_reference',

core/modules/field/src/Tests/EntityReference/EntityReferenceFileUploadTest.php

@@ -9,6 +9,7 @@
 
 use Drupal\Core\Field\FieldStorageDefinitionInterface;
 use Drupal\simpletest\WebTestBase;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Tests an autocomplete widget with file upload.
@@ -51,7 +52,7 @@ protected function setUp() {
     $this->referencedType = $referenced->id();
     $this->nodeId = $this->drupalCreateNode(array('type' => $referenced->id()))->id();
 
-    entity_create('field_storage_config', array(
+    FieldStorageConfig::create(array(
       'field_name' => 'test_field',
       'entity_type' => 'node',
       'translatable' => FALSE,
@@ -83,7 +84,7 @@ protected function setUp() {
 
     // Create a file field.
     $file_field_name = 'file_field';
-    $field_storage = entity_create('field_storage_config', array(
+    $field_storage = FieldStorageConfig::create(array(
       'field_name' => $file_field_name,
       'entity_type' => 'node',
       'type' => 'file'

core/modules/field/src/Tests/EntityReference/EntityReferenceFormatterTest.php

@@ -82,7 +82,7 @@ protected function setUp() {
 
     // Set up a field, so that the entity that'll be referenced bubbles up a
     // cache tag when rendering it entirely.
-    entity_create('field_storage_config', array(
+    FieldStorageConfig::create(array(
       'field_name' => 'body',
       'entity_type' => $this->entityType,
       'type' => 'text',

core/modules/field/src/Tests/EntityReference/Views/SelectionTest.php

@@ -9,6 +9,7 @@
 
 use Drupal\simpletest\WebTestBase;
 use Drupal\views\Views;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Tests entity reference selection handler.
@@ -50,7 +51,7 @@ protected function setUp() {
     }
 
     // Create a field.
-    $field_storage = entity_create('field_storage_config', array(
+    $field_storage = FieldStorageConfig::create(array(
       'field_name' => 'test_field',
       'entity_type' => 'entity_test',
       'translatable' => FALSE,

core/modules/field/src/Tests/FieldAccessTest.php

@@ -7,6 +7,8 @@
 
 namespace Drupal\field\Tests;
 
+use Drupal\field\Entity\FieldStorageConfig;
+
 /**
  * Tests Field access.
  *
@@ -50,7 +52,7 @@ protected function setUp() {
       'entity_type' => 'node',
       'type' => 'text',
     );
-    entity_create('field_storage_config', $field_storage)->save();
+    FieldStorageConfig::create($field_storage)->save();
     $field = array(
       'field_name' => $field_storage['field_name'],
       'entity_type' => 'node',

core/modules/field/src/Tests/FieldAttachStorageTest.php

@@ -8,6 +8,7 @@
 namespace Drupal\field\Tests;
 use Drupal\Component\Utility\Unicode;
 use Drupal\field\Entity\FieldConfig;
+use Drupal\field\Entity\FieldStorageConfig;
 
 /**
  * Tests storage-related Field Attach API functions.
@@ -95,7 +96,7 @@ function testFieldAttachLoadMultiple() {
     );
     for ($i = 1; $i <= 3; $i++) {
       $field_names[$i] = 'field_' . $i;
-      $field_storage = entity_create('field_storage_config', array(
+      $field_storage = FieldStorageConfig::create(array(
         'field_name' => $field_names[$i],
         'entity_type' => $entity_type,
         'type' => 'test_field',
@@ -323,7 +324,7 @@ function testEntityDeleteBundle() {
       'type' => 'test_field',
       'cardinality' => 1,
     );
-    entity_create('field_storage_config', $field_storage)->save();
+    FieldStorageConfig::create($field_storage)->save();
     $field = array(
       'field_name' => $field_name,
       'entity_type' => $entity_type,

core/modules/field/src/Tests/FieldCrudTest.php

@@ -50,7 +50,7 @@ function setUp() {
       'entity_type' => 'entity_test',
       'type' => 'test_field',
     );
-    $this->fieldStorage = entity_create('field_storage_config', $this->fieldStorageDefinition);
+    $this->fieldStorage = FieldStorageConfig::create($this->fieldStorageDefinition);
     $this->fieldStorage->save();
     $this->fieldDefinition = array(
       'field_name' => $this->fieldStorage->getName(),
@@ -262,7 +262,7 @@ function testDeleteFieldCrossDeletion() {
     $this->assertFalse(FieldConfig::loadByName('entity_test', $field_definition_2['bundle'], $field_storage->getName()));
 
     // Check that deletion of the last field deletes the storage.
-    $field_storage = entity_create('field_storage_config', $this->fieldStorageDefinition);
+    $field_storage = FieldStorageConfig::create($this->fieldStorageDefinition);
     $field_storage->save();
     $field = entity_create('field_config', $this->fieldDefinition);
     $field->save();
@@ -275,7 +275,7 @@ function testDeleteFieldCrossDeletion() {
 
     // Check that deletion of all fields using a storage simultaneously deletes
     // the storage.
-    $field_storage = entity_create('field_storage_config', $this->fieldStorageDefinition);
+    $field_storage = FieldStorageConfig::create($this->fieldStorageDefinition);
     $field_storage->save();
     $field = entity_create('field_config', $this->fieldDefinition);
     $field->save();

core/modules/field/src/Tests/FieldDataCountTest.php

@@ -54,7 +54,7 @@ public function testEntityCountAndHasData() {
     // Create a field with a cardinality of 2 to show that we are counting
     // entities and not rows in a table.
     /** @var \Drupal\field\Entity\FieldStorageConfig $field_storage */
-    $field_storage = entity_create('field_storage_config', array(
+    $field_storage = FieldStorageConfig::create(array(
       'field_name' => 'field_int',
       'entity_type' => 'entity_test',
       'type' => 'integer',

core/modules/field/src/Tests/FieldImportDeleteUninstallTest.php

@@ -7,6 +7,8 @@
 
 namespace Drupal\field\Tests;
 
+use Drupal\field\Entity\FieldStorageConfig;
+
 /**
  * Delete field storages and fields during config synchronization and uninstall
  * module that provides the field type.
@@ -39,7 +41,7 @@ public function testImportDeleteUninstall() {
     // Create a field to delete to prove that
     // \Drupal\field\ConfigImporterFieldPurger does not purge fields that are
     // not related to the configuration synchronization.
-    $unrelated_field_storage = entity_create('field_storage_config', array(
+    $unrelated_field_storage = FieldStorageConfig::create(array(
       'field_name' => 'field_int',
       'entity_type' => 'entity_test',
       'type' => 'integer',
@@ -51,7 +53,7 @@ public function testImportDeleteUninstall() {
     ))->save();
 
     // Create a telephone field for validation.
-    $field_storage = entity_create('field_storage_config', array(
+    $field_storage = FieldStorageConfig::create(array(
       'field_name' => 'field_test',
       'entity_type' => 'entity_test',
       'type' => 'telephone',
@@ -113,7 +115,7 @@ public function testImportDeleteUninstall() {
    */
   public function testImportAlreadyDeletedUninstall() {
     // Create a telephone field for validation.
-    $field_storage = entity_create('field_storage_config', array(
+    $field_storage = FieldStorageConfig::create(array(
       'field_name' => 'field_test',
       'entity_type' => 'entity_test',
       'type' => 'telephone',

core/modules/field/src/Tests/FieldImportDeleteUninstallUiTest.php

@@ -7,6 +7,8 @@
 
 namespace Drupal\field\Tests;
 
+use Drupal\field\Entity\FieldStorageConfig;
+
 /**
  * Delete field storages and fields during config synchronization and uninstall
  * module that provides the field type through the UI.
@@ -36,7 +38,7 @@ protected function setUp() {
    */
   public function testImportDeleteUninstall() {
     // Create a telephone field.
-    $field_storage = entity_create('field_storage_config', array(
+    $field_storage = FieldStorageConfig::create(array(
       'field_name' => 'field_tel',
       'entity_type' => 'entity_test',
       'type' => 'telephone',
@@ -48,7 +50,7 @@ public function testImportDeleteUninstall() {
     ))->save();
 
     // Create a text field.
-    $date_field_storage = entity_create('field_storage_config', array(
+    $date_field_storage = FieldStorageConfig::create(array(
       'field_name' => 'field_date',
       'entity_type' => 'entity_test',
       'type' => 'datetime',

core/modules/field/src/Tests/FieldStorageCrudTest.php

@@ -42,7 +42,7 @@ function testCreate() {
       'type' => 'test_field',
     );
     field_test_memorize();
-    $field_storage = entity_create('field_storage_config', $field_storage_definition);
+    $field_storage = FieldStorageConfig::create($field_storage_definition);
     $field_storage->save();
 
     $field_storage = FieldStorageConfig::load($field_storage->id());
@@ -81,7 +81,7 @@ function testCreate() {
 
     // Guarantee that the name is unique.
     try {
-      entity_create('field_storage_config', $field_storage_definition)->save();
+      FieldStorageConfig::create($field_storage_definition)->save();
       $this->fail(t('Cannot create two fields with the same name.'));
     }
     catch (EntityStorageException $e) {
@@ -94,7 +94,7 @@ function testCreate() {
         'field_name' => 'field_1',
         'entity_type' => 'entity_type',
       );
-      entity_create('field_storage_config', $field_storage_definition)->save();
+      FieldStorageConfig::create($field_storage_definition)->save();
       $this->fail(t('Cannot create a field with no type.'));
     }
     catch (FieldException $e) {
@@ -107,7 +107,7 @@ function testCreate() {
         'type' => 'test_field',
         'entity_type' => 'entity_test',
       );
-      entity_create('field_storage_config', $field_storage_definition)->save();
+      FieldStorageConfig::create($field_storage_definition)->save();
       $this->fail(t('Cannot create an unnamed field.'));
     }
     catch (FieldException $e) {
@@ -119,7 +119,7 @@ function testCreate() {
         'field_name' => 'test_field',
         'type' => 'test_field'
       );
-      entity_create('field_storage_config', $field_storage_definition)->save();
+      FieldStorageConfig::create($field_storage_definition)->save();
       $this->fail('Cannot create a field without an entity type.');
     }
     catch (FieldException $e) {
@@ -133,7 +133,7 @@ function testCreate() {
         'entity_type' => 'entity_test',
         'type' => 'test_field',
       );