diff --git a/core/lib/Drupal/Core/Ajax/AjaxResponseAttachmentsProcessor.php b/core/lib/Drupal/Core/Ajax/AjaxResponseAttachmentsProcessor.php index d7a72b430fbb806fa4914b6948855053cd7d4fb0..8af3dc6d5cfbf60986df1b824911cfaeb11509b7 100644 --- a/core/lib/Drupal/Core/Ajax/AjaxResponseAttachmentsProcessor.php +++ b/core/lib/Drupal/Core/Ajax/AjaxResponseAttachmentsProcessor.php @@ -133,10 +133,11 @@ public function processAttachments(AttachmentsInterface $response) { */ protected function buildAttachmentsCommands(AjaxResponse $response, Request $request) { $ajax_page_state = $request->get('ajax_page_state'); + $maintenance_mode = defined('MAINTENANCE_MODE') || \Drupal::state()->get('system.maintenance_mode'); // Aggregate CSS/JS if necessary, but only during normal site operation. - $optimize_css = !defined('MAINTENANCE_MODE') && $this->config->get('css.preprocess'); - $optimize_js = !defined('MAINTENANCE_MODE') && $this->config->get('js.preprocess'); + $optimize_css = !$maintenance_mode && $this->config->get('css.preprocess'); + $optimize_js = $maintenance_mode && $this->config->get('js.preprocess'); $attachments = $response->getAttachments(); diff --git a/core/lib/Drupal/Core/Render/HtmlResponseAttachmentsProcessor.php b/core/lib/Drupal/Core/Render/HtmlResponseAttachmentsProcessor.php index 917648103132087d2249c4346cf46e7dff0c9404..de2ab4ef4b7d074f9d6c938886c3d57d1da56f03 100644 --- a/core/lib/Drupal/Core/Render/HtmlResponseAttachmentsProcessor.php +++ b/core/lib/Drupal/Core/Render/HtmlResponseAttachmentsProcessor.php @@ -311,17 +311,19 @@ protected function renderPlaceholders(HtmlResponse $response) { protected function processAssetLibraries(AttachedAssetsInterface $assets, array $placeholders) { $variables = []; + $maintenance_mode = defined('MAINTENANCE_MODE') || \Drupal::state()->get('system.maintenance_mode'); + // Print styles - if present. if (isset($placeholders['styles'])) { // Optimize CSS if necessary, but only during normal site operation. - $optimize_css = !defined('MAINTENANCE_MODE') && $this->config->get('css.preprocess'); + $optimize_css = !$maintenance_mode && $this->config->get('css.preprocess'); $variables['styles'] = $this->cssCollectionRenderer->render($this->assetResolver->getCssAssets($assets, $optimize_css, $this->languageManager->getCurrentLanguage())); } // Print scripts - if any are present. if (isset($placeholders['scripts']) || isset($placeholders['scripts_bottom'])) { // Optimize JS if necessary, but only during normal site operation. - $optimize_js = !defined('MAINTENANCE_MODE') && !\Drupal::state()->get('system.maintenance_mode') && $this->config->get('js.preprocess'); + $optimize_js = !$maintenance_mode && $this->config->get('js.preprocess'); [$js_assets_header, $js_assets_footer] = $this->assetResolver->getJsAssets($assets, $optimize_js, $this->languageManager->getCurrentLanguage()); $variables['scripts'] = $this->jsCollectionRenderer->render($js_assets_header); $variables['scripts_bottom'] = $this->jsCollectionRenderer->render($js_assets_footer); diff --git a/core/modules/system/tests/src/Functional/System/SiteMaintenanceTest.php b/core/modules/system/tests/src/Functional/System/SiteMaintenanceTest.php index def93ffec18c7e2b27028cda586f83af5f631dcf..8de91e27dbd9b3b2f8273762c2df0a1a78d62587 100644 --- a/core/modules/system/tests/src/Functional/System/SiteMaintenanceTest.php +++ b/core/modules/system/tests/src/Functional/System/SiteMaintenanceTest.php @@ -47,7 +47,10 @@ protected function setUp(): void { // Configure 'node' as front page. $this->config('system.site')->set('page.front', '/node')->save(); - $this->config('system.performance')->set('js.preprocess', 1)->save(); + $this->config('system.performance') + ->set('js.preprocess', 1) + ->set('css.preprocess', 1) + ->save(); // Create a user allowed to access site in maintenance mode. $this->user = $this->drupalCreateUser(['access site in maintenance mode']); @@ -73,8 +76,9 @@ public function testSiteMaintenance() { $this->assertSession()->linkByHrefExists(Url::fromRoute('user.login')->toString()); $this->drupalGet(Url::fromRoute('user.page')); - // JS should be aggregated, so drupal.js is not in the page source. + // Aggregation should be enabled, individual assets should not be rendered. $this->assertSession()->elementNotExists('xpath', '//script[contains(@src, "/core/misc/drupal.js")]'); + $this->assertSession()->elementNotExists('xpath', '//link[contains(@href, "/core/modules/system/css/components/align.module.css")]'); // Turn on maintenance mode. $edit = [ 'maintenance_mode' => 1, @@ -87,8 +91,9 @@ public function testSiteMaintenance() { $offline_message = $this->config('system.site')->get('name') . ' is currently under maintenance. We should be back shortly. Thank you for your patience.'; $this->drupalGet(Url::fromRoute('user.page')); - // JS should not be aggregated, so drupal.js is expected in the page source. + // Aggregation should be disabled, individual assets should be rendered. $this->assertSession()->elementExists('xpath', '//script[contains(@src, "/core/misc/drupal.js")]'); + $this->assertSession()->elementExists('xpath', '//link[contains(@href, "/core/modules/system/css/components/align.module.css")]'); $this->assertSession()->pageTextContains($admin_message); $this->assertSession()->linkExists('Go online.'); $this->assertSession()->linkByHrefExists(Url::fromRoute('system.site_maintenance_mode')->toString());