diff --git a/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeExecuteTestBase.php b/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeExecuteTestBase.php index ed901febec9e1b1abf07e9e3bede5b81e8d2742a..7038e7b378cc653e794ff739e2226e7307dc2621 100644 --- a/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeExecuteTestBase.php +++ b/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeExecuteTestBase.php @@ -106,7 +106,16 @@ public function testMigrateUpgradeExecute() { $session->fieldExists('mysql[host]'); $this->drupalPostForm(NULL, $edits, t('Review upgrade')); - $this->assertIdConflict($session); + $entity_types = [ + 'block_content', + 'menu_link_content', + 'file', + 'taxonomy_term', + 'user', + 'comment', + 'node', + ]; + $this->assertIdConflict($session, $entity_types); $this->drupalPostForm(NULL, [], t('I acknowledge I may lose data. Continue anyway.')); $session->statusCodeEquals(200); diff --git a/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeTestBase.php b/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeTestBase.php index 14274bc5729b24f8ce369e2ae0a887a8da51ea2d..db75e036a808cf0d67eea39cd810a09d71c082a7 100644 --- a/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeTestBase.php +++ b/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeTestBase.php @@ -193,20 +193,20 @@ protected function assertReviewPage(WebAssert $session, array $available_paths, * * @param \Drupal\Tests\WebAssert $session * The current session. - * @param $session - * The current session. + * @param array $entity_types + * An array of entity types */ - protected function assertIdConflict(WebAssert $session) { + protected function assertIdConflict(WebAssert $session, $entity_types) { + /** @var \Drupal\ $entity_type_manager */ + $entity_type_manager = \Drupal::service('entity_type.manager'); + $session->pageTextContains('WARNING: Content may be overwritten on your new site.'); $session->pageTextContains('There is conflicting content of these types:'); - $session->pageTextContains('custom blocks'); - $session->pageTextContains('custom menu links'); - $session->pageTextContains('files'); - $session->pageTextContains('taxonomy terms'); - $session->pageTextContains('users'); - $session->pageTextContains('comments'); + foreach ($entity_types as $entity_type) { + $label = $entity_type_manager->getDefinition($entity_type)->getPluralLabel(); + $session->pageTextContains($label); + } $session->pageTextContains('content item revisions'); - $session->pageTextContains('content items'); $session->pageTextContains('There is translated content of these types:'); }