From c9053e9df968f1a532875412856e2409a21c8a72 Mon Sep 17 00:00:00 2001 From: catch <catch@35733.no-reply.drupal.org> Date: Wed, 14 Jun 2023 10:32:23 +0100 Subject: [PATCH] Issue #3366633 by Spokje: Uncomment assertions in StyleTest related to https://github.com/ckeditor/ckeditor5/issues/11709 (cherry picked from commit d838d8c0840cc51d8665cf1a1648951b3801d18a) --- .../tests/src/FunctionalJavascript/StyleTest.php | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/core/modules/ckeditor5/tests/src/FunctionalJavascript/StyleTest.php b/core/modules/ckeditor5/tests/src/FunctionalJavascript/StyleTest.php index 1cc9674586e4..36fc9d71ed3b 100644 --- a/core/modules/ckeditor5/tests/src/FunctionalJavascript/StyleTest.php +++ b/core/modules/ckeditor5/tests/src/FunctionalJavascript/StyleTest.php @@ -253,8 +253,7 @@ function (ConstraintViolation $v) { $this->assertSame('true', $buttons[0]->getAttribute('aria-disabled')); $this->assertFalse($buttons[1]->hasAttribute('aria-disabled')); $this->assertSame('true', $buttons[2]->getAttribute('aria-disabled')); - // @todo Uncomment this after https://github.com/ckeditor/ckeditor5/issues/11709 is fixed. - // $this->assertSame('true', $buttons[3]->getAttribute('aria-disabled')); + $this->assertSame('true', $buttons[3]->getAttribute('aria-disabled')); $this->assertTrue($buttons[0]->hasClass('ck-off')); $this->assertTrue($buttons[1]->hasClass('ck-off')); $this->assertTrue($buttons[2]->hasClass('ck-off')); @@ -283,8 +282,7 @@ function (ConstraintViolation $v) { $this->assertFalse($buttons[0]->hasAttribute('aria-disabled')); $this->assertSame('true', $buttons[1]->getAttribute('aria-disabled')); $this->assertSame('true', $buttons[2]->getAttribute('aria-disabled')); - // @todo Uncomment this after https://github.com/ckeditor/ckeditor5/issues/11709 is fixed. - // $this->assertSame('true', $buttons[3]->getAttribute('aria-disabled')); + $this->assertSame('true', $buttons[3]->getAttribute('aria-disabled')); // Close the dropdown. $style_dropdown->click(); @@ -301,8 +299,7 @@ function (ConstraintViolation $v) { $this->assertFalse($buttons[0]->hasAttribute('aria-disabled')); $this->assertSame('true', $buttons[1]->getAttribute('aria-disabled')); $this->assertFalse($buttons[2]->hasAttribute('aria-disabled')); - // @todo Uncomment this after https://github.com/ckeditor/ckeditor5/issues/11709 is fixed. - // $this->assertSame('true', $buttons[3]->getAttribute('aria-disabled')); + $this->assertSame('true', $buttons[3]->getAttribute('aria-disabled')); // Close the dropdown. $style_dropdown->click(); -- GitLab