Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
project
drupal
Commits
c1522a73
Commit
c1522a73
authored
Aug 14, 2020
by
catch
Browse files
Issue
#3146492
by sharma.amitt16, paulocs, ultrabob: Remove unused variables in media module
parent
336f6fd1
Changes
2
Hide whitespace changes
Inline
Side-by-side
core/modules/media/tests/src/FunctionalJavascript/CKEditorIntegrationTest.php
View file @
c1522a73
...
...
@@ -1106,7 +1106,7 @@ public function testAlignment() {
$this
->
assignNameToCkeditorIframe
();
$this
->
getSession
()
->
switchToIFrame
(
'ckeditor'
);
// Wait for preview to load.
$this
->
assertNotEmpty
(
$img
=
$assert_session
->
waitForElement
(
'css'
,
'drupal-media img'
));
$this
->
assertNotEmpty
(
$assert_session
->
waitForElement
(
'css'
,
'drupal-media img'
));
// Assert the drupal-media element starts without a data-align attribute.
$drupal_media
=
$assert_session
->
elementExists
(
'css'
,
'drupal-media'
);
$this
->
assertFalse
(
$drupal_media
->
hasAttribute
(
'data-align'
));
...
...
@@ -1122,7 +1122,7 @@ public function testAlignment() {
foreach
(
$alignments
as
$alignment
)
{
$this
->
fillFieldInMetadataDialogAndSubmit
(
'attributes[data-align]'
,
$alignment
);
// Wait for preview to load.
$this
->
assertNotEmpty
(
$img
=
$assert_session
->
waitForElement
(
'css'
,
'drupal-media img'
));
$this
->
assertNotEmpty
(
$assert_session
->
waitForElement
(
'css'
,
'drupal-media img'
));
// Now verify the result. Assert the first element within the
// <drupal-media> element has the alignment class.
$selector
=
sprintf
(
'drupal-media[data-align="%s"] .caption-drupal-media.align-%s'
,
$alignment
,
$alignment
);
...
...
core/modules/media/tests/src/Kernel/MediaEmbedFilterTestBase.php
View file @
c1522a73
...
...
@@ -82,7 +82,7 @@ protected function setUp() {
// Create a user with required permissions. Ensure that we don't use user 1
// because that user is treated in special ways by access control handlers.
$admin_user
=
$this
->
drupalCreateUser
([]);
$this
->
drupalCreateUser
([]);
$user
=
$this
->
drupalCreateUser
([
'access content'
,
'view media'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment