Commit be7e3036 authored by xjm's avatar xjm
Browse files

Issue #3107472 by ravi.shankar, alexpott, kishor_kolekar, jibran:...

Issue #3107472 by ravi.shankar, alexpott, kishor_kolekar, jibran: DbDumpCommand should not hardcode the version string

(cherry picked from commit 4276e511)
parent a9e5966f
......@@ -93,6 +93,8 @@ protected function generateScript(Connection $connection, array $schema_only = [
$tables .= $this->getTableScript($table, $schema, $data);
}
$script = $this->getTemplate();
// Substitute in the version.
$script = str_replace('{{VERSION}}', \Drupal::VERSION, $script);
// Substitute in the tables.
$script = str_replace('{{TABLES}}', trim($tables), $script);
return trim($script);
......@@ -395,7 +397,7 @@ protected function getTemplate() {
* @file
* A database agnostic dump for testing purposes.
*
* This file was generated by the Drupal 8.0 db-tools.php script.
* This file was generated by the Drupal {{VERSION}} db-tools.php script.
*/
use Drupal\Core\Database\Database;
......
......@@ -13,7 +13,7 @@ class DbToolsApplication extends Application {
* {@inheritdoc}
*/
public function __construct() {
parent::__construct('Database Tools', '8.0.x');
parent::__construct('Database Tools', \Drupal::VERSION);
}
/**
......
......@@ -54,6 +54,8 @@ public function testDbDumpCommand() {
$this->assertStringContainsString("'path' => 'test", $output, 'Insert path field found');
$this->assertStringContainsString("'pattern_outline' => 'test", $output, 'Insert pattern_outline field found');
$this->assertStringContainsString("// @codingStandardsIgnoreFile", $output);
$version = \Drupal::VERSION;
$this->assertStringContainsString("This file was generated by the Drupal {$version} db-tools.php script.", $output);
}
/**
......
......@@ -22,6 +22,7 @@ public function testDumpCommandRegistration() {
$application = new DbToolsApplication();
$command = $application->find('dump');
$this->assertInstanceOf('\Drupal\Core\Command\DbDumpCommand', $command);
$this->assertSame(\Drupal::VERSION, $application->getVersion());
}
/**
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment