From b85397f262fd0db6a0f1856d707525323b89e307 Mon Sep 17 00:00:00 2001 From: nod_ <nod_@598310.no-reply.drupal.org> Date: Thu, 12 Sep 2024 16:54:54 +0200 Subject: [PATCH] Issue #898656 by quietone, Abhisheksingh27, virajthakrar, smustgrave, Jacine, jhedstrom: Some documentation links use single quotes for attributes, which produces inconsistent HTML --- core/modules/migrate_drupal_ui/src/Form/ReviewForm.php | 2 +- core/modules/views/tests/src/Functional/GlossaryTest.php | 2 +- .../default_content/languages/en/node/page.csv | 2 +- .../default_content/languages/es/node/page.csv | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/core/modules/migrate_drupal_ui/src/Form/ReviewForm.php b/core/modules/migrate_drupal_ui/src/Form/ReviewForm.php index 977ee488ac56..a28dada3e9cc 100644 --- a/core/modules/migrate_drupal_ui/src/Form/ReviewForm.php +++ b/core/modules/migrate_drupal_ui/src/Form/ReviewForm.php @@ -138,7 +138,7 @@ public function buildForm(array $form, FormStateInterface $form_state) { '#open' => TRUE, '#title' => $this->t('Modules that will not be upgraded'), '#summary_attributes' => ['id' => ['error']], - '#description' => $this->t("The new site is missing modules corresponding to the old site's modules. Unless they are installed prior to the upgrade, configuration and/or content needed by them will not be available on your new site. <a href=':review'>Read the checklist</a> to help decide what to do.", [':review' => 'https://www.drupal.org/docs/8/upgrade/upgrade-using-web-browser#pre-upgrade-analysis']), + '#description' => $this->t('The new site is missing modules corresponding to the old site\'s modules. Unless they are installed prior to the upgrade, configuration and/or content needed by them will not be available on your new site. <a href=":review">Read the checklist</a> to help decide what to do.', [':review' => 'https://www.drupal.org/docs/upgrading-drupal/upgrading-from-drupal-6-or-drupal-7/upgrade-using-web-browser#pre-upgrade-analysis']), '#weight' => 2, ]; $missing_module_list['module_list'] = [ diff --git a/core/modules/views/tests/src/Functional/GlossaryTest.php b/core/modules/views/tests/src/Functional/GlossaryTest.php index fc93e5e5dab0..292f91767715 100644 --- a/core/modules/views/tests/src/Functional/GlossaryTest.php +++ b/core/modules/views/tests/src/Functional/GlossaryTest.php @@ -119,7 +119,7 @@ public function testGlossaryView(): void { // Get the summary link for a certain character. Filter by label and href // to ensure that both of them are correct. $result = $this->assertSession()->elementExists('xpath', "//a[contains(@href, '{$href}') and normalize-space(text())='{$label}']/.."); - // The rendered output looks like "<a href=''>X</a> | (count)" so let's + // The rendered output looks like "<a href="">X</a> | (count)" so let's // figure out the int. $result_count = explode(' ', trim(str_replace(['|', '(', ')'], '', $result->getText())))[1]; $this->assertEquals($count, $result_count, 'The expected number got rendered.'); diff --git a/core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/node/page.csv b/core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/node/page.csv index c9b472bae327..6cd609734d64 100644 --- a/core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/node/page.csv +++ b/core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/node/page.csv @@ -1,2 +1,2 @@ id,title,field_body,author,slug -1,About Umami,"<p>Umami is a fictional food magazine that has been created to demonstrate how you might build a Drupal site using functionality provided 'out of the box'.</p><p>For more information visit <a href='https://www.drupal.org/docs/umami-drupal-demonstration-installation-profile'>https://www.drupal.org/docs/umami-drupal-demonstration-installation-profile</a>.</p>",Samuel Adamson,about-umami +1,About Umami,"<p>Umami is a fictional food magazine that has been created to demonstrate how you might build a Drupal site using functionality provided 'out of the box'.</p><p>For more information visit <a href=""https://www.drupal.org/docs/umami-drupal-demonstration-installation-profile"">https://www.drupal.org/docs/umami-drupal-demonstration-installation-profile</a>.</p>",Samuel Adamson,about-umami diff --git a/core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/node/page.csv b/core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/node/page.csv index 13c890ca7e88..7b1fb39244d0 100644 --- a/core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/node/page.csv +++ b/core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/node/page.csv @@ -1,2 +1,2 @@ id,title,field_body,author,slug -1,Acerca de Umami,"<p> Umami es una revista ficticia de alimentos que se ha creado para demostrar cómo se puede construir un sitio de Drupal con la funcionalidad que se proporciona 'fuera de la caja'. </p> <p> Para obtener más información, visite <a href='https://www.drupal.org/docs/umami-drupal-demonstration-installation-profile'>https://www.drupal.org/docs/umami-drupal-demonstration-installation-profile</a>.</p> ",Samuel Adamson,acerca-de-umami +1,Acerca de Umami,"<p> Umami es una revista ficticia de alimentos que se ha creado para demostrar cómo se puede construir un sitio de Drupal con la funcionalidad que se proporciona 'fuera de la caja'. </p> <p> Para obtener más información, visite <a href=""https://www.drupal.org/docs/umami-drupal-demonstration-installation-profile"">https://www.drupal.org/docs/umami-drupal-demonstration-installation-profile</a>.</p> ",Samuel Adamson,acerca-de-umami -- GitLab