Issue #1549506 by swentel, pcambra, lbainbridge, muriqui: Fixed Edit and...

Issue #1549506 by swentel, pcambra, lbainbridge, muriqui: Fixed Edit and delete links should be hidden for locked fields.

core/modules/field_ui/lib/Drupal/field_ui/FieldOverview.php

@@ -152,8 +152,8 @@ public function buildForm(array $form, array &$form_state, $entity_type = NULL,
         '#links' => $links,
       );
 
-      if (!empty($instance['locked'])) {
-        $table[$name]['operations'] = array('#value' => t('Locked'));
+      if (!empty($field['locked'])) {
+        $table[$name]['operations'] = array('#markup' => t('Locked'));
         $table[$name]['#attributes']['class'][] = 'menu-disabled';
       }
     }

core/modules/field_ui/lib/Drupal/field_ui/Tests/ManageFieldsTest.php

@@ -341,6 +341,38 @@ function testDeleteField() {
     $this->assertNull(field_info_field($this->field_name), 'Field was deleted.');
   }
 
+  /**
+   * Tests that Field UI respects locked fields.
+   */
+  function testLockedField() {
+    // Create a locked field and attach it to a bundle. We need to do this
+    // programatically as there's no way to create a locked field through UI.
+    $field = entity_create('field_entity', array(
+      'field_name' => strtolower($this->randomName(8)),
+      'type' => 'test_field',
+      'cardinality' => 1,
+      'locked' => TRUE
+    ));
+    $field->save();
+    entity_create('field_instance', array(
+      'field_uuid' => $field->uuid,
+      'entity_type' => 'node',
+      'bundle' => $this->type,
+      'widget' => array(
+        'type' => 'test_field_widget',
+      )
+    ))->save();
+
+    // Check that the links for edit and delete are not present.
+    $this->drupalGet('admin/structure/types/manage/' . $this->type . '/fields');
+    $locked = $this->xpath('//tr[@id=:field_name]/td[7]', array(':field_name' => $field->id()));
+    $this->assertTrue(in_array('Locked', $locked), 'Field is marked as Locked in the UI');
+    $edit_link = $this->xpath('//tr[@id=:field_name]/td[7]', array(':field_name' => $field->id()));
+    $this->assertFalse(in_array('edit', $edit_link), 'Edit option for locked field is not present the UI');
+    $delete_link = $this->xpath('//tr[@id=:field_name]/td[8]', array(':field_name' => $field->id()));
+    $this->assertFalse(in_array('delete', $delete_link), 'Delete option for locked field is not present the UI');
+  }
+
   /**
    * Tests that Field UI respects the 'no_ui' option in hook_field_info().
    */