Issue #2391403 by Gábor Hojtsy: Statistics block not properly migrated, schema incorrect

core/modules/migrate_drupal/config/install/migrate.migration.d6_statistics_settings.yml

@@ -8,16 +8,10 @@ source:
     - statistics_enable_access_log
     - statistics_flush_accesslog_timer
     - statistics_count_content_views
-    - statistics_block_top_day_num
-    - statistics_block_top_all_num
-    - statistics_block_top_last_num
 process:
   'access_log/enabled': statistics_enable_access_log
   'access_log/max_lifetime': statistics_flush_accesslog_timer
   'count_content_views': statistics_count_content_views
-  'block/popular/top_day_limit': statistics_block_top_day_num
-  'block/popular/top_all_limit': statistics_block_top_all_num
-  'block/popular/top_recent_limit': statistics_block_top_last_num
 destination:
   plugin: config
   config_name: statistics.settings

core/modules/migrate_drupal/src/Tests/d6/MigrateStatisticsConfigsTest.php

@@ -50,9 +50,6 @@ public function testStatisticsSettings() {
     $this->assertIdentical($config->get('access_log.enabled'), FALSE);
     $this->assertIdentical($config->get('access_log.max_lifetime'), 259200);
     $this->assertIdentical($config->get('count_content_views'), 0);
-    $this->assertIdentical($config->get('block.popular.top_day_limit'), 0);
-    $this->assertIdentical($config->get('block.popular.top_all_limit'), 0);
-    $this->assertIdentical($config->get('block.popular.top_recent_limit'), 0);
     $this->assertConfigSchema(\Drupal::service('config.typed'), 'statistics.settings', $config->get());
   }
 

core/modules/statistics/config/install/statistics.settings.yml

@@ -2,8 +2,3 @@ access_log:
   enabled: false
   max_lifetime: 259200
 count_content_views: 0
-block:
-  popular:
-    top_day_limit: 0
-    top_all_limit: 0
-    top_recent_limit: 0

core/modules/statistics/config/schema/statistics.schema.yml

@@ -17,23 +17,6 @@ statistics.settings:
     count_content_views:
       type: integer
       label: 'Count content views'
-    block:
-      type: mapping
-      label: 'Block settings'
-      mapping:
-        popular:
-          type: mapping
-          label: 'Popular content block'
-          mapping:
-            top_day_limit:
-              type: integer
-              label: 'Number of day''s top views to display'
-            top_all_limit:
-              type: integer
-              label: 'Number of all time views to display'
-            top_recent_limit:
-              type: integer
-              label: 'Number of most recent views to display'
 
 block.settings.statistics_popular_block:
   type: block_settings