From a7b67e7af18b6a91ac4187c439f28d63a6fc1113 Mon Sep 17 00:00:00 2001
From: Alex Pott <alex.a.pott@googlemail.com>
Date: Mon, 29 Aug 2016 06:50:59 -0500
Subject: [PATCH] Issue #2721901 by Mile23, anoopjohn: Fix
Drupal.Commenting.FunctionComment.MissingParamName
---
core/lib/Drupal/Component/Assertion/Inspector.php | 2 +-
core/lib/Drupal/Component/Gettext/PoItem.php | 2 +-
core/lib/Drupal/Core/Asset/CssCollectionOptimizer.php | 8 ++++----
core/lib/Drupal/Core/Asset/CssCollectionRenderer.php | 2 +-
core/lib/Drupal/Core/Asset/JsCollectionOptimizer.php | 8 ++++----
core/lib/Drupal/Core/Asset/JsCollectionRenderer.php | 2 +-
core/lib/Drupal/Core/Config/ConfigCollectionInfo.php | 2 +-
core/lib/Drupal/Core/Config/ConfigCrudEvent.php | 2 +-
core/lib/Drupal/Core/Config/ConfigInstallerInterface.php | 2 +-
.../lib/Drupal/Core/Config/ConfigModuleOverridesEvent.php | 2 +-
core/lib/Drupal/Core/Cron.php | 2 +-
.../Core/EventSubscriber/EntityRouteAlterSubscriber.php | 2 +-
core/lib/Drupal/Core/Field/FieldItemListInterface.php | 2 +-
core/lib/Drupal/Core/Field/FieldTypePluginManager.php | 2 +-
core/lib/Drupal/Core/Form/FormStateInterface.php | 2 +-
.../Language/ContextProvider/CurrentLanguageContext.php | 2 +-
.../Core/Render/PageDisplayVariantSelectionEvent.php | 2 +-
.../Drupal/Core/Routing/StackedRouteMatchInterface.php | 2 +-
core/lib/Drupal/Core/Session/PermissionsHashGenerator.php | 2 +-
.../Drupal/Core/TypedData/TypedDataManagerInterface.php | 2 +-
core/lib/Drupal/Core/Url.php | 4 ++--
core/modules/action/src/Plugin/Action/EmailAction.php | 4 ++--
core/modules/book/src/BookManager.php | 2 +-
core/modules/config/src/Form/ConfigSync.php | 2 +-
core/modules/config_translation/src/ConfigNamesMapper.php | 2 +-
.../src/Controller/ContentTranslationController.php | 6 +++---
core/modules/datetime/src/Plugin/views/filter/Date.php | 2 +-
core/modules/field/src/FieldStorageConfigStorage.php | 2 +-
.../hal/src/Normalizer/ContentEntityNormalizer.php | 2 +-
.../tests/src/Unit/source/DrupalSqlBaseTest.php | 2 +-
.../tests/src/Unit/source/d6/Drupal6SqlBaseTest.php | 4 ++--
core/modules/node/src/Controller/NodeController.php | 2 +-
core/modules/node/src/NodeStorageInterface.php | 4 ++--
core/modules/node/src/Plugin/migrate/source/d6/Node.php | 2 +-
core/modules/node/src/Plugin/views/argument/Vid.php | 2 +-
.../tests/src/Kernel/Migrate/d6/MigrateUrlAliasTest.php | 2 +-
core/modules/quickedit/src/EditorSelector.php | 4 ++--
core/modules/quickedit/src/MetadataGenerator.php | 2 +-
.../rest/src/Plugin/rest/resource/EntityResource.php | 2 +-
core/modules/search/src/Form/SearchBlockForm.php | 2 +-
core/modules/shortcut/src/ShortcutSetStorageInterface.php | 2 +-
core/modules/system/src/Controller/SystemController.php | 2 +-
.../entity_test/src/Controller/EntityTestController.php | 2 +-
core/modules/user/src/Form/UserPermissionsForm.php | 2 +-
core/modules/views/src/DisplayPluginCollection.php | 2 +-
core/modules/views/src/ViewExecutable.php | 2 +-
.../modules/views_ui/src/Controller/ViewsUIController.php | 2 +-
core/modules/views_ui/src/Form/Ajax/RearrangeFilter.php | 2 +-
core/phpcs.xml.dist | 1 -
.../Asset/ResolvedLibraryDefinitionsFilesMatchTest.php | 2 +-
50 files changed, 62 insertions(+), 63 deletions(-)
diff --git a/core/lib/Drupal/Component/Assertion/Inspector.php b/core/lib/Drupal/Component/Assertion/Inspector.php
index 6b96a7ac443b..9b04e33064c6 100644
--- a/core/lib/Drupal/Component/Assertion/Inspector.php
+++ b/core/lib/Drupal/Component/Assertion/Inspector.php
@@ -108,7 +108,7 @@ public static function assertAllStringable($traversable) {
* Use this instead of is_string() alone unless the argument being an object
* in any way will cause a problem.
*
- * @param mixed string
+ * @param mixed $string
* Variable to be examined
*
* @return bool
diff --git a/core/lib/Drupal/Component/Gettext/PoItem.php b/core/lib/Drupal/Component/Gettext/PoItem.php
index c5579641c58a..6cedff11042b 100644
--- a/core/lib/Drupal/Component/Gettext/PoItem.php
+++ b/core/lib/Drupal/Component/Gettext/PoItem.php
@@ -169,7 +169,7 @@ function setComment($comment) {
/**
* Create the PoItem from a structured array.
*
- * @param array values
+ * @param array $values
*/
public function setFromArray(array $values = array()) {
if (isset($values['context'])) {
diff --git a/core/lib/Drupal/Core/Asset/CssCollectionOptimizer.php b/core/lib/Drupal/Core/Asset/CssCollectionOptimizer.php
index 9beddd1d26c5..eb47cb2c593c 100644
--- a/core/lib/Drupal/Core/Asset/CssCollectionOptimizer.php
+++ b/core/lib/Drupal/Core/Asset/CssCollectionOptimizer.php
@@ -40,13 +40,13 @@ class CssCollectionOptimizer implements AssetCollectionOptimizerInterface {
/**
* Constructs a CssCollectionOptimizer.
*
- * @param \Drupal\Core\Asset\AssetCollectionGrouperInterface
+ * @param \Drupal\Core\Asset\AssetCollectionGrouperInterface $grouper
* The grouper for CSS assets.
- * @param \Drupal\Core\Asset\AssetOptimizerInterface
+ * @param \Drupal\Core\Asset\AssetOptimizerInterface $optimizer
* The optimizer for a single CSS asset.
- * @param \Drupal\Core\Asset\AssetDumperInterface
+ * @param \Drupal\Core\Asset\AssetDumperInterface $dumper
* The dumper for optimized CSS assets.
- * @param \Drupal\Core\State\StateInterface
+ * @param \Drupal\Core\State\StateInterface $state
* The state key/value store.
*/
public function __construct(AssetCollectionGrouperInterface $grouper, AssetOptimizerInterface $optimizer, AssetDumperInterface $dumper, StateInterface $state) {
diff --git a/core/lib/Drupal/Core/Asset/CssCollectionRenderer.php b/core/lib/Drupal/Core/Asset/CssCollectionRenderer.php
index 869abe34b4e9..63721e65ffe1 100644
--- a/core/lib/Drupal/Core/Asset/CssCollectionRenderer.php
+++ b/core/lib/Drupal/Core/Asset/CssCollectionRenderer.php
@@ -63,7 +63,7 @@ class CssCollectionRenderer implements AssetCollectionRendererInterface {
/**
* Constructs a CssCollectionRenderer.
*
- * @param \Drupal\Core\State\StateInterface
+ * @param \Drupal\Core\State\StateInterface $state
* The state key/value store.
*/
public function __construct(StateInterface $state) {
diff --git a/core/lib/Drupal/Core/Asset/JsCollectionOptimizer.php b/core/lib/Drupal/Core/Asset/JsCollectionOptimizer.php
index aef10bf5529c..566722dfb6c9 100644
--- a/core/lib/Drupal/Core/Asset/JsCollectionOptimizer.php
+++ b/core/lib/Drupal/Core/Asset/JsCollectionOptimizer.php
@@ -41,13 +41,13 @@ class JsCollectionOptimizer implements AssetCollectionOptimizerInterface {
/**
* Constructs a JsCollectionOptimizer.
*
- * @param \Drupal\Core\Asset\AssetCollectionGrouperInterface
+ * @param \Drupal\Core\Asset\AssetCollectionGrouperInterface $grouper
* The grouper for JS assets.
- * @param \Drupal\Core\Asset\AssetOptimizerInterface
+ * @param \Drupal\Core\Asset\AssetOptimizerInterface $optimizer
* The optimizer for a single JS asset.
- * @param \Drupal\Core\Asset\AssetDumperInterface
+ * @param \Drupal\Core\Asset\AssetDumperInterface $dumper
* The dumper for optimized JS assets.
- * @param \Drupal\Core\State\StateInterface
+ * @param \Drupal\Core\State\StateInterface $state
* The state key/value store.
*/
public function __construct(AssetCollectionGrouperInterface $grouper, AssetOptimizerInterface $optimizer, AssetDumperInterface $dumper, StateInterface $state) {
diff --git a/core/lib/Drupal/Core/Asset/JsCollectionRenderer.php b/core/lib/Drupal/Core/Asset/JsCollectionRenderer.php
index c5f0a2b1e4e0..2e47d0f3d506 100644
--- a/core/lib/Drupal/Core/Asset/JsCollectionRenderer.php
+++ b/core/lib/Drupal/Core/Asset/JsCollectionRenderer.php
@@ -20,7 +20,7 @@ class JsCollectionRenderer implements AssetCollectionRendererInterface {
/**
* Constructs a JsCollectionRenderer.
*
- * @param \Drupal\Core\State\StateInterface
+ * @param \Drupal\Core\State\StateInterface $state
* The state key/value store.
*/
public function __construct(StateInterface $state) {
diff --git a/core/lib/Drupal/Core/Config/ConfigCollectionInfo.php b/core/lib/Drupal/Core/Config/ConfigCollectionInfo.php
index 0ec82f9f2543..483c96d2064c 100644
--- a/core/lib/Drupal/Core/Config/ConfigCollectionInfo.php
+++ b/core/lib/Drupal/Core/Config/ConfigCollectionInfo.php
@@ -24,7 +24,7 @@ class ConfigCollectionInfo extends Event {
*
* @param string $collection
* Collection name to add.
- * @param \Drupal\Core\Config\ConfigFactoryOverrideInterface
+ * @param \Drupal\Core\Config\ConfigFactoryOverrideInterface $override_service
* (optional) The configuration factory override service responsible for the
* collection.
*
diff --git a/core/lib/Drupal/Core/Config/ConfigCrudEvent.php b/core/lib/Drupal/Core/Config/ConfigCrudEvent.php
index af25d3613066..3172e8eeeb84 100644
--- a/core/lib/Drupal/Core/Config/ConfigCrudEvent.php
+++ b/core/lib/Drupal/Core/Config/ConfigCrudEvent.php
@@ -19,7 +19,7 @@ class ConfigCrudEvent extends Event {
/**
* Constructs a configuration event object.
*
- * @param \Drupal\Core\Config\Config
+ * @param \Drupal\Core\Config\Config $config
* Configuration object.
*/
public function __construct(Config $config) {
diff --git a/core/lib/Drupal/Core/Config/ConfigInstallerInterface.php b/core/lib/Drupal/Core/Config/ConfigInstallerInterface.php
index ba7181218066..3d7077b53bd5 100644
--- a/core/lib/Drupal/Core/Config/ConfigInstallerInterface.php
+++ b/core/lib/Drupal/Core/Config/ConfigInstallerInterface.php
@@ -40,7 +40,7 @@ public function installDefaultConfig($type, $name);
* - it's a configuration entity.
* - its dependencies can be met.
*
- * @param \Drupal\Core\Config\StorageInterface
+ * @param \Drupal\Core\Config\StorageInterface $storage
* (optional) The configuration storage to search for optional
* configuration. If not provided, all enabled extension's optional
* configuration directories will be searched.
diff --git a/core/lib/Drupal/Core/Config/ConfigModuleOverridesEvent.php b/core/lib/Drupal/Core/Config/ConfigModuleOverridesEvent.php
index a8a42c54eddf..be5be93a1d74 100644
--- a/core/lib/Drupal/Core/Config/ConfigModuleOverridesEvent.php
+++ b/core/lib/Drupal/Core/Config/ConfigModuleOverridesEvent.php
@@ -37,7 +37,7 @@ class ConfigModuleOverridesEvent extends Event {
*
* @param array $names
* A list of configuration names.
- * @param \Drupal\Core\Language\LanguageInterface
+ * @param \Drupal\Core\Language\LanguageInterface $language
* (optional) The language for this configuration.
*/
public function __construct(array $names, LanguageInterface $language = NULL) {
diff --git a/core/lib/Drupal/Core/Cron.php b/core/lib/Drupal/Core/Cron.php
index 8662d68c2e65..74d2866402a5 100644
--- a/core/lib/Drupal/Core/Cron.php
+++ b/core/lib/Drupal/Core/Cron.php
@@ -83,7 +83,7 @@ class Cron implements CronInterface {
* The account switching service.
* @param \Psr\Log\LoggerInterface $logger
* A logger instance.
- * @param \Drupal\Core\Queue\QueueWorkerManagerInterface
+ * @param \Drupal\Core\Queue\QueueWorkerManagerInterface $queue_manager
* The queue plugin manager.
*/
public function __construct(ModuleHandlerInterface $module_handler, LockBackendInterface $lock, QueueFactory $queue_factory, StateInterface $state, AccountSwitcherInterface $account_switcher, LoggerInterface $logger, QueueWorkerManagerInterface $queue_manager) {
diff --git a/core/lib/Drupal/Core/EventSubscriber/EntityRouteAlterSubscriber.php b/core/lib/Drupal/Core/EventSubscriber/EntityRouteAlterSubscriber.php
index 8337d43b112b..3c37195ca1f3 100644
--- a/core/lib/Drupal/Core/EventSubscriber/EntityRouteAlterSubscriber.php
+++ b/core/lib/Drupal/Core/EventSubscriber/EntityRouteAlterSubscriber.php
@@ -30,7 +30,7 @@ class EntityRouteAlterSubscriber implements EventSubscriberInterface {
/**
* Constructs an EntityRouteAlterSubscriber instance.
*
- * @param \Drupal\Core\Entity\EntityResolverManager
+ * @param \Drupal\Core\Entity\EntityResolverManager $entity_resolver_manager
* The entity resolver manager.
*/
public function __construct(EntityResolverManager $entity_resolver_manager) {
diff --git a/core/lib/Drupal/Core/Field/FieldItemListInterface.php b/core/lib/Drupal/Core/Field/FieldItemListInterface.php
index 2266c9c81b95..f901cb7483e4 100644
--- a/core/lib/Drupal/Core/Field/FieldItemListInterface.php
+++ b/core/lib/Drupal/Core/Field/FieldItemListInterface.php
@@ -245,7 +245,7 @@ public function defaultValuesFormSubmit(array $element, array &$form, FormStateI
* in order to be a valid runtime value for the field type; e.g., a date field
* could process the defined value of 'NOW' to a valid date.
*
- * @param array
+ * @param array $default_value
* The unprocessed default value defined for the field, as a numerically
* indexed array of items, each item being an array of property/value pairs.
* @param \Drupal\Core\Entity\FieldableEntityInterface $entity
diff --git a/core/lib/Drupal/Core/Field/FieldTypePluginManager.php b/core/lib/Drupal/Core/Field/FieldTypePluginManager.php
index 09c6a127ad89..84bb4c0917b5 100644
--- a/core/lib/Drupal/Core/Field/FieldTypePluginManager.php
+++ b/core/lib/Drupal/Core/Field/FieldTypePluginManager.php
@@ -34,7 +34,7 @@ class FieldTypePluginManager extends DefaultPluginManager implements FieldTypePl
* keyed by the corresponding namespace to look for plugin implementations.
* @param \Drupal\Core\Cache\CacheBackendInterface $cache_backend
* Cache backend instance to use.
- * @param \Drupal\Core\Extension\ModuleHandlerInterface
+ * @param \Drupal\Core\Extension\ModuleHandlerInterface $module_handler
* The module handler.
* @param \Drupal\Core\TypedData\TypedDataManagerInterface $typed_data_manager
* The typed data manager.
diff --git a/core/lib/Drupal/Core/Form/FormStateInterface.php b/core/lib/Drupal/Core/Form/FormStateInterface.php
index 26485a0248ca..b1e3f3bc02e1 100644
--- a/core/lib/Drupal/Core/Form/FormStateInterface.php
+++ b/core/lib/Drupal/Core/Form/FormStateInterface.php
@@ -780,7 +780,7 @@ public function setRequestMethod($method);
/**
* Returns the HTTP form method.
*
- * @param string
+ * @param string $method_type
* The HTTP form method.
*
* @return bool
diff --git a/core/lib/Drupal/Core/Language/ContextProvider/CurrentLanguageContext.php b/core/lib/Drupal/Core/Language/ContextProvider/CurrentLanguageContext.php
index b8fe273161a1..38250339ce51 100644
--- a/core/lib/Drupal/Core/Language/ContextProvider/CurrentLanguageContext.php
+++ b/core/lib/Drupal/Core/Language/ContextProvider/CurrentLanguageContext.php
@@ -26,7 +26,7 @@ class CurrentLanguageContext implements ContextProviderInterface {
/**
* Constructs a new CurrentLanguageContext.
*
- * @param \Drupal\Core\Language\LanguageManagerInterface
+ * @param \Drupal\Core\Language\LanguageManagerInterface $language_manager
* The language manager.
*/
public function __construct(LanguageManagerInterface $language_manager) {
diff --git a/core/lib/Drupal/Core/Render/PageDisplayVariantSelectionEvent.php b/core/lib/Drupal/Core/Render/PageDisplayVariantSelectionEvent.php
index 852a47e8e334..37ff0f788895 100644
--- a/core/lib/Drupal/Core/Render/PageDisplayVariantSelectionEvent.php
+++ b/core/lib/Drupal/Core/Render/PageDisplayVariantSelectionEvent.php
@@ -54,7 +54,7 @@ class PageDisplayVariantSelectionEvent extends Event implements RefinableCacheab
/**
* Constructs the page display variant plugin selection event.
*
- * @param string
+ * @param string $plugin_id
* The ID of the page display variant plugin to use by default.
* @param \Drupal\Core\Routing\RouteMatchInterface $route_match
* The current route match, for context.
diff --git a/core/lib/Drupal/Core/Routing/StackedRouteMatchInterface.php b/core/lib/Drupal/Core/Routing/StackedRouteMatchInterface.php
index 986e900e4c84..45b777cfaed6 100644
--- a/core/lib/Drupal/Core/Routing/StackedRouteMatchInterface.php
+++ b/core/lib/Drupal/Core/Routing/StackedRouteMatchInterface.php
@@ -36,7 +36,7 @@ public function getParentRouteMatch();
/**
* Returns a route match from a given request, if possible.
*
- * @param \Symfony\Component\HttpFoundation\Request
+ * @param \Symfony\Component\HttpFoundation\Request $request
* The request.
*
* @return \Drupal\Core\Routing\RouteMatchInterface|null
diff --git a/core/lib/Drupal/Core/Session/PermissionsHashGenerator.php b/core/lib/Drupal/Core/Session/PermissionsHashGenerator.php
index 767d2b489242..e17253782fb1 100644
--- a/core/lib/Drupal/Core/Session/PermissionsHashGenerator.php
+++ b/core/lib/Drupal/Core/Session/PermissionsHashGenerator.php
@@ -40,7 +40,7 @@ class PermissionsHashGenerator implements PermissionsHashGeneratorInterface {
* The private key service.
* @param \Drupal\Core\Cache\CacheBackendInterface $cache
* The cache backend interface to use for the persistent cache.
- * @param \Drupal\Core\Cache\CacheBackendInterface
+ * @param \Drupal\Core\Cache\CacheBackendInterface $static
* The cache backend interface to use for the static cache.
*/
public function __construct(PrivateKey $private_key, CacheBackendInterface $cache, CacheBackendInterface $static) {
diff --git a/core/lib/Drupal/Core/TypedData/TypedDataManagerInterface.php b/core/lib/Drupal/Core/TypedData/TypedDataManagerInterface.php
index 16a910ce48de..20a4a76af282 100644
--- a/core/lib/Drupal/Core/TypedData/TypedDataManagerInterface.php
+++ b/core/lib/Drupal/Core/TypedData/TypedDataManagerInterface.php
@@ -192,7 +192,7 @@ public function getValidationConstraintManager();
* The validation constraint manager is used to instantiate validation
* constraint plugins.
*
- * @param \Drupal\Core\Validation\ConstraintManager
+ * @param \Drupal\Core\Validation\ConstraintManager $constraintManager
* The constraint manager to set.
*/
public function setValidationConstraintManager(ConstraintManager $constraintManager);
diff --git a/core/lib/Drupal/Core/Url.php b/core/lib/Drupal/Core/Url.php
index 6a58319e0262..e7624d8a65a3 100644
--- a/core/lib/Drupal/Core/Url.php
+++ b/core/lib/Drupal/Core/Url.php
@@ -845,7 +845,7 @@ protected function unroutedUrlAssembler() {
/**
* Sets the URL generator.
*
- * @param \Drupal\Core\Routing\UrlGeneratorInterface
+ * @param \Drupal\Core\Routing\UrlGeneratorInterface $url_generator
* (optional) The URL generator, specify NULL to reset it.
*
* @return $this
@@ -859,7 +859,7 @@ public function setUrlGenerator(UrlGeneratorInterface $url_generator = NULL) {
/**
* Sets the unrouted URL assembler.
*
- * @param \Drupal\Core\Utility\UnroutedUrlAssemblerInterface
+ * @param \Drupal\Core\Utility\UnroutedUrlAssemblerInterface $url_assembler
* The unrouted URL assembler.
*
* @return $this
diff --git a/core/modules/action/src/Plugin/Action/EmailAction.php b/core/modules/action/src/Plugin/Action/EmailAction.php
index 1ee618417479..c4ea5ac1605e 100644
--- a/core/modules/action/src/Plugin/Action/EmailAction.php
+++ b/core/modules/action/src/Plugin/Action/EmailAction.php
@@ -84,9 +84,9 @@ class EmailAction extends ConfigurableActionBase implements ContainerFactoryPlug
* The entity manager.
* @param \Psr\Log\LoggerInterface $logger
* A logger instance.
- * @param \Drupal\Core\Mail\MailManagerInterface
+ * @param \Drupal\Core\Mail\MailManagerInterface $mail_manager
* The mail manager.
- * @param \Drupal\Core\Language\LanguageManagerInterface
+ * @param \Drupal\Core\Language\LanguageManagerInterface $language_manager
* The language manager.
* @param \Egulias\EmailValidator\EmailValidator $email_validator
* The email validator.
diff --git a/core/modules/book/src/BookManager.php b/core/modules/book/src/BookManager.php
index 2942462faa91..60754be7bd17 100644
--- a/core/modules/book/src/BookManager.php
+++ b/core/modules/book/src/BookManager.php
@@ -138,7 +138,7 @@ public function getParentDepthLimit(array $book_link) {
/**
* Determine the relative depth of the children of a given book link.
*
- * @param array
+ * @param array $book_link
* The book link.
*
* @return int
diff --git a/core/modules/config/src/Form/ConfigSync.php b/core/modules/config/src/Form/ConfigSync.php
index 8dd9ca0d338f..51cded2690e6 100644
--- a/core/modules/config/src/Form/ConfigSync.php
+++ b/core/modules/config/src/Form/ConfigSync.php
@@ -124,7 +124,7 @@ class ConfigSync extends FormBase {
* The module installer.
* @param \Drupal\Core\Extension\ThemeHandlerInterface $theme_handler
* The theme handler.
- * @param \Drupal\Core\Render\RendererInterface
+ * @param \Drupal\Core\Render\RendererInterface $renderer
* The renderer.
*/
public function __construct(StorageInterface $sync_storage, StorageInterface $active_storage, StorageInterface $snapshot_storage, LockBackendInterface $lock, EventDispatcherInterface $event_dispatcher, ConfigManagerInterface $config_manager, TypedConfigManagerInterface $typed_config, ModuleHandlerInterface $module_handler, ModuleInstallerInterface $module_installer, ThemeHandlerInterface $theme_handler, RendererInterface $renderer) {
diff --git a/core/modules/config_translation/src/ConfigNamesMapper.php b/core/modules/config_translation/src/ConfigNamesMapper.php
index bb82fe57871f..0784090daf59 100644
--- a/core/modules/config_translation/src/ConfigNamesMapper.php
+++ b/core/modules/config_translation/src/ConfigNamesMapper.php
@@ -109,7 +109,7 @@ class ConfigNamesMapper extends PluginBase implements ConfigMapperInterface, Con
* The locale configuration manager.
* @param \Drupal\config_translation\ConfigMapperManagerInterface $config_mapper_manager
* The mapper plugin discovery service.
- * @param \Drupal\Core\Routing\RouteProviderInterface
+ * @param \Drupal\Core\Routing\RouteProviderInterface $route_provider
* The route provider.
* @param \Drupal\Core\StringTranslation\TranslationInterface $string_translation
* The string translation manager.
diff --git a/core/modules/content_translation/src/Controller/ContentTranslationController.php b/core/modules/content_translation/src/Controller/ContentTranslationController.php
index efd5953f0549..43b59aaf1e16 100644
--- a/core/modules/content_translation/src/Controller/ContentTranslationController.php
+++ b/core/modules/content_translation/src/Controller/ContentTranslationController.php
@@ -26,7 +26,7 @@ class ContentTranslationController extends ControllerBase {
/**
* Initializes a content translation controller.
*
- * @param \Drupal\content_translation\ContentTranslationManagerInterface
+ * @param \Drupal\content_translation\ContentTranslationManagerInterface $manager
* A content translation manager instance.
*/
public function __construct(ContentTranslationManagerInterface $manager) {
@@ -319,7 +319,7 @@ public function overview(RouteMatchInterface $route_match, $entity_type_id = NUL
* @param \Drupal\Core\Language\LanguageInterface $target
* The language of the translated values. Defaults to the current content
* language.
- * @param \Drupal\Core\Routing\RouteMatchInterface
+ * @param \Drupal\Core\Routing\RouteMatchInterface $route_match
* The route match object from which to extract the entity type.
* @param string $entity_type_id
* (optional) The entity type ID.
@@ -354,7 +354,7 @@ public function add(LanguageInterface $source, LanguageInterface $target, RouteM
* @param \Drupal\Core\Language\LanguageInterface $language
* The language of the translated values. Defaults to the current content
* language.
- * @param \Drupal\Core\Routing\RouteMatchInterface
+ * @param \Drupal\Core\Routing\RouteMatchInterface $route_match
* The route match object from which to extract the entity type.
* @param string $entity_type_id
* (optional) The entity type ID.
diff --git a/core/modules/datetime/src/Plugin/views/filter/Date.php b/core/modules/datetime/src/Plugin/views/filter/Date.php
index 9fd47fdc7b55..afd629a74c82 100644
--- a/core/modules/datetime/src/Plugin/views/filter/Date.php
+++ b/core/modules/datetime/src/Plugin/views/filter/Date.php
@@ -58,7 +58,7 @@ class Date extends NumericDate implements ContainerFactoryPluginInterface {
* The plugin implementation definition.
* @param \Drupal\Core\Datetime\DateFormatterInterface $date_formatter
* The date formatter service.
- * @param \Symfony\Component\HttpFoundation\RequestStack
+ * @param \Symfony\Component\HttpFoundation\RequestStack $request_stack
* The request stack used to determine the current time.
*/
public function __construct(array $configuration, $plugin_id, $plugin_definition, DateFormatterInterface $date_formatter, RequestStack $request_stack) {
diff --git a/core/modules/field/src/FieldStorageConfigStorage.php b/core/modules/field/src/FieldStorageConfigStorage.php
index 072b6fad989f..ebb037110362 100644
--- a/core/modules/field/src/FieldStorageConfigStorage.php
+++ b/core/modules/field/src/FieldStorageConfigStorage.php
@@ -64,7 +64,7 @@ class FieldStorageConfigStorage extends ConfigEntityStorage {
* The module handler.
* @param \Drupal\Core\State\StateInterface $state
* The state key value store.
- * @param \Drupal\Component\Plugin\PluginManagerInterface\FieldTypePluginManagerInterface
+ * @param \Drupal\Component\Plugin\PluginManagerInterface\FieldTypePluginManagerInterface $field_type_manager
* The field type plugin manager.
*/
public function __construct(EntityTypeInterface $entity_type, ConfigFactoryInterface $config_factory, UuidInterface $uuid_service, LanguageManagerInterface $language_manager, EntityManagerInterface $entity_manager, ModuleHandlerInterface $module_handler, StateInterface $state, FieldTypePluginManagerInterface $field_type_manager) {
diff --git a/core/modules/hal/src/Normalizer/ContentEntityNormalizer.php b/core/modules/hal/src/Normalizer/ContentEntityNormalizer.php
index fd8158b34ae1..712d52cbd6ab 100644
--- a/core/modules/hal/src/Normalizer/ContentEntityNormalizer.php
+++ b/core/modules/hal/src/Normalizer/ContentEntityNormalizer.php
@@ -190,7 +190,7 @@ public function denormalize($data, $class, $format = NULL, array $context = arra
/**
* Constructs the entity URI.
*
- * @param \Drupal\Core\Entity\EntityInterface
+ * @param \Drupal\Core\Entity\EntityInterface $entity
* The entity.
* @return string
* The entity URI.
diff --git a/core/modules/migrate_drupal/tests/src/Unit/source/DrupalSqlBaseTest.php b/core/modules/migrate_drupal/tests/src/Unit/source/DrupalSqlBaseTest.php
index f603afa5397c..4d07922a412f 100644
--- a/core/modules/migrate_drupal/tests/src/Unit/source/DrupalSqlBaseTest.php
+++ b/core/modules/migrate_drupal/tests/src/Unit/source/DrupalSqlBaseTest.php
@@ -83,7 +83,7 @@ public function query() {
/**
* Tweaks DrupalSqlBase to set a new database connection for tests.
*
- * @param \Drupal\Core\Database\Connection
+ * @param \Drupal\Core\Database\Connection $database
* The new connection to use.
*
* @see \Drupal\Tests\migrate\Unit\MigrateSourceSqlTestCase
diff --git a/core/modules/migrate_drupal/tests/src/Unit/source/d6/Drupal6SqlBaseTest.php b/core/modules/migrate_drupal/tests/src/Unit/source/d6/Drupal6SqlBaseTest.php
index e27a3531030f..845ce786363e 100644
--- a/core/modules/migrate_drupal/tests/src/Unit/source/d6/Drupal6SqlBaseTest.php
+++ b/core/modules/migrate_drupal/tests/src/Unit/source/d6/Drupal6SqlBaseTest.php
@@ -170,7 +170,7 @@ public function query() {
/**
* Tweaks Drupal6SqlBase to set a new database connection for tests.
*
- * @param \Drupal\Core\Database\Connection
+ * @param \Drupal\Core\Database\Connection $database
* The new connection to use.
*
* @see \Drupal\Tests\migrate\Unit\MigrateSqlTestCase
@@ -182,7 +182,7 @@ public function setDatabase(Connection $database) {
/**
* Tweaks Drupal6SqlBase to set a new module handler for tests.
*
- * @param \Drupal\Core\Extension\ModuleHandlerInterface
+ * @param \Drupal\Core\Extension\ModuleHandlerInterface $module_handler
* The new module handler to use.
*
* @see \Drupal\Tests\migrate\Unit\MigrateSqlTestCase
diff --git a/core/modules/node/src/Controller/NodeController.php b/core/modules/node/src/Controller/NodeController.php
index 654ba307c011..048b949c4bd2 100644
--- a/core/modules/node/src/Controller/NodeController.php
+++ b/core/modules/node/src/Controller/NodeController.php
@@ -285,7 +285,7 @@ public function addPageTitle(NodeTypeInterface $node_type) {
/**
* Gets a list of node revision IDs for a specific node.
*
- * @param \Drupal\node\NodeInterface
+ * @param \Drupal\node\NodeInterface $node
* The node entity.
* @param \Drupal\node\NodeStorageInterface $node_storage
* The node storage handler.
diff --git a/core/modules/node/src/NodeStorageInterface.php b/core/modules/node/src/NodeStorageInterface.php
index b09d7b76799f..19668c2084ca 100644
--- a/core/modules/node/src/NodeStorageInterface.php
+++ b/core/modules/node/src/NodeStorageInterface.php
@@ -14,7 +14,7 @@ interface NodeStorageInterface extends ContentEntityStorageInterface {
/**
* Gets a list of node revision IDs for a specific node.
*
- * @param \Drupal\node\NodeInterface
+ * @param \Drupal\node\NodeInterface $node
* The node entity.
*
* @return int[]
@@ -36,7 +36,7 @@ public function userRevisionIds(AccountInterface $account);
/**
* Counts the number of revisions in the default language.
*
- * @param \Drupal\node\NodeInterface
+ * @param \Drupal\node\NodeInterface $node
* The node entity.
*
* @return int
diff --git a/core/modules/node/src/Plugin/migrate/source/d6/Node.php b/core/modules/node/src/Plugin/migrate/source/d6/Node.php
index 5ca698f7955d..86864156cbae 100644
--- a/core/modules/node/src/Plugin/migrate/source/d6/Node.php
+++ b/core/modules/node/src/Plugin/migrate/source/d6/Node.php
@@ -261,7 +261,7 @@ public function getIds() {
/**
* Adapt our query for translations.
*
- * @param \Drupal\Core\Database\Query\SelectInterface
+ * @param \Drupal\Core\Database\Query\SelectInterface $query
* The generated query.
*/
protected function handleTranslations(SelectInterface $query) {
diff --git a/core/modules/node/src/Plugin/views/argument/Vid.php b/core/modules/node/src/Plugin/views/argument/Vid.php
index 77889b80131e..8788b67a30e2 100644
--- a/core/modules/node/src/Plugin/views/argument/Vid.php
+++ b/core/modules/node/src/Plugin/views/argument/Vid.php
@@ -39,7 +39,7 @@ class Vid extends NumericArgument {
* The plugin implementation definition.
* @param \Drupal\Core\Database\Connection $database
* Database Service Object.
- * @param \Drupal\node\NodeStorageInterface
+ * @param \Drupal\node\NodeStorageInterface $node_storage
* The node storage.
*/
public function __construct(array $configuration, $plugin_id, $plugin_definition, Connection $database, NodeStorageInterface $node_storage) {
diff --git a/core/modules/path/tests/src/Kernel/Migrate/d6/MigrateUrlAliasTest.php b/core/modules/path/tests/src/Kernel/Migrate/d6/MigrateUrlAliasTest.php
index 363846fcfcbe..120d072c47af 100644
--- a/core/modules/path/tests/src/Kernel/Migrate/d6/MigrateUrlAliasTest.php
+++ b/core/modules/path/tests/src/Kernel/Migrate/d6/MigrateUrlAliasTest.php
@@ -29,7 +29,7 @@ protected function setUp() {
/**
* Assert a path.
*
- * @param string pid
+ * @param string $pid
* The path id.
* @param array $conditions
* The path conditions.
diff --git a/core/modules/quickedit/src/EditorSelector.php b/core/modules/quickedit/src/EditorSelector.php
index 9e2252e6cca0..a531b1a49a53 100644
--- a/core/modules/quickedit/src/EditorSelector.php
+++ b/core/modules/quickedit/src/EditorSelector.php
@@ -36,9 +36,9 @@ class EditorSelector implements EditorSelectorInterface {
/**
* Constructs a new EditorSelector.
*
- * @param \Drupal\Component\Plugin\PluginManagerInterface
+ * @param \Drupal\Component\Plugin\PluginManagerInterface $editor_manager
* The manager for editor plugins.
- * @param \Drupal\Core\Field\FormatterPluginManager
+ * @param \Drupal\Core\Field\FormatterPluginManager $formatter_manager
* The manager for formatter plugins.
*/
public function __construct(PluginManagerInterface $editor_manager, FormatterPluginManager $formatter_manager) {
diff --git a/core/modules/quickedit/src/MetadataGenerator.php b/core/modules/quickedit/src/MetadataGenerator.php
index 31bde4a1c3a2..a22bf65a6c08 100644
--- a/core/modules/quickedit/src/MetadataGenerator.php
+++ b/core/modules/quickedit/src/MetadataGenerator.php
@@ -41,7 +41,7 @@ class MetadataGenerator implements MetadataGeneratorInterface {
* An object that checks if a user has access to edit a given field.
* @param \Drupal\quickedit\EditorSelectorInterface $editor_selector
* An object that determines which editor to attach to a given field.
- * @param \Drupal\Component\Plugin\PluginManagerInterface
+ * @param \Drupal\Component\Plugin\PluginManagerInterface $editor_manager
* The manager for editor plugins.
*/
public function __construct(EditEntityFieldAccessCheckInterface $access_checker, EditorSelectorInterface $editor_selector, PluginManagerInterface $editor_manager) {
diff --git a/core/modules/rest/src/Plugin/rest/resource/EntityResource.php b/core/modules/rest/src/Plugin/rest/resource/EntityResource.php
index dfb0272af73d..d6833c0c9747 100644
--- a/core/modules/rest/src/Plugin/rest/resource/EntityResource.php
+++ b/core/modules/rest/src/Plugin/rest/resource/EntityResource.php
@@ -68,7 +68,7 @@ class EntityResource extends ResourceBase implements DependentPluginInterface {
* The available serialization formats.
* @param \Psr\Log\LoggerInterface $logger
* A logger instance.
- * @param \Drupal\Core\Config\ConfigFactoryInterface
+ * @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory
* The config factory.
*/
public function __construct(array $configuration, $plugin_id, $plugin_definition, EntityTypeManagerInterface $entity_type_manager, $serializer_formats, LoggerInterface $logger, ConfigFactoryInterface $config_factory) {
diff --git a/core/modules/search/src/Form/SearchBlockForm.php b/core/modules/search/src/Form/SearchBlockForm.php
index cc9d89ee4b2c..cd198fd7944d 100644
--- a/core/modules/search/src/Form/SearchBlockForm.php
+++ b/core/modules/search/src/Form/SearchBlockForm.php
@@ -42,7 +42,7 @@ class SearchBlockForm extends FormBase {
* The search page repository.
* @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory
* The config factory.
- * @param \Drupal\Core\Render\RendererInterface
+ * @param \Drupal\Core\Render\RendererInterface $renderer
* The renderer.
*/
public function __construct(SearchPageRepositoryInterface $search_page_repository, ConfigFactoryInterface $config_factory, RendererInterface $renderer) {
diff --git a/core/modules/shortcut/src/ShortcutSetStorageInterface.php b/core/modules/shortcut/src/ShortcutSetStorageInterface.php
index a367800d6fa0..47036a670ed9 100644
--- a/core/modules/shortcut/src/ShortcutSetStorageInterface.php
+++ b/core/modules/shortcut/src/ShortcutSetStorageInterface.php
@@ -46,7 +46,7 @@ public function deleteAssignedShortcutSets(ShortcutSetInterface $entity);
/**
* Get the name of the set assigned to this user.
*
- * @param \Drupal\user\Entity\User
+ * @param \Drupal\user\Entity\User $account
* The user account.
*
* @return string
diff --git a/core/modules/system/src/Controller/SystemController.php b/core/modules/system/src/Controller/SystemController.php
index 062a11ba7931..41ed82469244 100644
--- a/core/modules/system/src/Controller/SystemController.php
+++ b/core/modules/system/src/Controller/SystemController.php
@@ -74,7 +74,7 @@ class SystemController extends ControllerBase {
* The form builder.
* @param \Drupal\Core\Extension\ThemeHandlerInterface $theme_handler
* The theme handler.
- * @param \Drupal\Core\Menu\MenuLinkTreeInterface
+ * @param \Drupal\Core\Menu\MenuLinkTreeInterface $menu_link_tree
* The menu link tree service.
*/
public function __construct(SystemManager $systemManager, QueryFactory $queryFactory, ThemeAccessCheck $theme_access, FormBuilderInterface $form_builder, ThemeHandlerInterface $theme_handler, MenuLinkTreeInterface $menu_link_tree) {
diff --git a/core/modules/system/tests/modules/entity_test/src/Controller/EntityTestController.php b/core/modules/system/tests/modules/entity_test/src/Controller/EntityTestController.php
index 7dcd61eae6d9..a753eabdedc0 100644
--- a/core/modules/system/tests/modules/entity_test/src/Controller/EntityTestController.php
+++ b/core/modules/system/tests/modules/entity_test/src/Controller/EntityTestController.php
@@ -22,7 +22,7 @@ class EntityTestController extends ControllerBase {
/**
* Constructs a new EntityTestController.
*
- * @param \Drupal\Core\Entity\Query\QueryFactory
+ * @param \Drupal\Core\Entity\Query\QueryFactory $entity_query_factory
* The entity query factory.
*/
public function __construct(QueryFactory $entity_query_factory) {
diff --git a/core/modules/user/src/Form/UserPermissionsForm.php b/core/modules/user/src/Form/UserPermissionsForm.php
index 7a06219665e4..75bbaf23522d 100644
--- a/core/modules/user/src/Form/UserPermissionsForm.php
+++ b/core/modules/user/src/Form/UserPermissionsForm.php
@@ -42,7 +42,7 @@ class UserPermissionsForm extends FormBase {
* The permission handler.
* @param \Drupal\user\RoleStorageInterface $role_storage
* The role storage.
- * @param \Drupal\Core\Extension\ModuleHandlerInterface
+ * @param \Drupal\Core\Extension\ModuleHandlerInterface $module_handler
* The module handler.
*/
public function __construct(PermissionHandlerInterface $permission_handler, RoleStorageInterface $role_storage, ModuleHandlerInterface $module_handler) {
diff --git a/core/modules/views/src/DisplayPluginCollection.php b/core/modules/views/src/DisplayPluginCollection.php
index e94a6ac99e18..0b692b115d68 100644
--- a/core/modules/views/src/DisplayPluginCollection.php
+++ b/core/modules/views/src/DisplayPluginCollection.php
@@ -26,7 +26,7 @@ class DisplayPluginCollection extends DefaultLazyPluginCollection {
/**
* Constructs a DisplayPluginCollection object.
*
- * @param \Drupal\views\ViewExecutable
+ * @param \Drupal\views\ViewExecutable $view
* The view which has this displays attached.
* @param \Drupal\Component\Plugin\PluginManagerInterface $manager
* The manager to be used for instantiating plugins.
diff --git a/core/modules/views/src/ViewExecutable.php b/core/modules/views/src/ViewExecutable.php
index c8b059332db4..786b10f64237 100644
--- a/core/modules/views/src/ViewExecutable.php
+++ b/core/modules/views/src/ViewExecutable.php
@@ -1655,7 +1655,7 @@ public function preview($display_id = NULL, $args = array()) {
/**
* Runs attachments and lets the display do what it needs to before running.
*
- * @param array @args
+ * @param array $args
* An array of arguments from the URL that can be used by the view.
*/
public function preExecute($args = array()) {
diff --git a/core/modules/views_ui/src/Controller/ViewsUIController.php b/core/modules/views_ui/src/Controller/ViewsUIController.php
index 4b0b44e44435..f36e912ad23a 100644
--- a/core/modules/views_ui/src/Controller/ViewsUIController.php
+++ b/core/modules/views_ui/src/Controller/ViewsUIController.php
@@ -31,7 +31,7 @@ class ViewsUIController extends ControllerBase {
/**
* Constructs a new \Drupal\views_ui\Controller\ViewsUIController object.
*
- * @param \Drupal\views\ViewsData views_data
+ * @param \Drupal\views\ViewsData $views_data
* The Views data cache object.
*/
public function __construct(ViewsData $views_data) {
diff --git a/core/modules/views_ui/src/Form/Ajax/RearrangeFilter.php b/core/modules/views_ui/src/Form/Ajax/RearrangeFilter.php
index e858a84f47d0..e8eedd7501a7 100644
--- a/core/modules/views_ui/src/Form/Ajax/RearrangeFilter.php
+++ b/core/modules/views_ui/src/Form/Ajax/RearrangeFilter.php
@@ -331,7 +331,7 @@ public function submitForm(array &$form, FormStateInterface $form_state) {
*
* For example array(0 => 'foo') would be array(1 => 'foo').
*
- * @param array
+ * @param array $array
* The array to increment keys on.
*
* @return array
diff --git a/core/phpcs.xml.dist b/core/phpcs.xml.dist
index 6ab291865093..ff05061d45b4 100644
--- a/core/phpcs.xml.dist
+++ b/core/phpcs.xml.dist
@@ -51,7 +51,6 @@
<exclude name="Drupal.Commenting.FunctionComment.Missing"/>
<exclude name="Drupal.Commenting.FunctionComment.MissingFile"/>
<exclude name="Drupal.Commenting.FunctionComment.MissingParamComment"/>
- <exclude name="Drupal.Commenting.FunctionComment.MissingParamName"/>
<exclude name="Drupal.Commenting.FunctionComment.MissingParamType"/>
<exclude name="Drupal.Commenting.FunctionComment.MissingReturnComment"/>
<exclude name="Drupal.Commenting.FunctionComment.MissingReturnType"/>
diff --git a/core/tests/Drupal/KernelTests/Core/Asset/ResolvedLibraryDefinitionsFilesMatchTest.php b/core/tests/Drupal/KernelTests/Core/Asset/ResolvedLibraryDefinitionsFilesMatchTest.php
index c3d3e30c6647..4836e16f3aa0 100644
--- a/core/tests/Drupal/KernelTests/Core/Asset/ResolvedLibraryDefinitionsFilesMatchTest.php
+++ b/core/tests/Drupal/KernelTests/Core/Asset/ResolvedLibraryDefinitionsFilesMatchTest.php
@@ -140,7 +140,7 @@ public function testCoreLibraryCompleteness() {
/**
* Checks that all the library files exist.
*
- * @param array[]
+ * @param array[] $library_definitions
* An array of library definitions, keyed by extension, then by library, and
* so on.
*/
--
GitLab