Issue #2191011 by Stuart Miller, Cottser: PHP Warnings in...

Issue #2191011 by Stuart Miller, Cottser: PHP Warnings in views_preprocess_page() caused by frontpage view.

Issue #2191011 by Stuart Miller, Cottser: PHP Warnings in...
Issue #2191011 by Stuart Miller, Cottser: PHP Warnings in views_preprocess_page() caused by frontpage view.
a566566e · webchick · 13ada2ac · a566566e · a566566e
Commit a566566e authored Mar 04, 2014 by webchick
Showing with 17 additions and 1 deletion

core/modules/node/lib/Drupal/node/Tests/Views/FrontPageTest.php ...odules/node/lib/Drupal/node/Tests/Views/FrontPageTest.php +16 -0

core/modules/views/views.module core/modules/views/views.module +1 -1

No files found.
--- a/core/modules/node/lib/Drupal/node/Tests/Views/FrontPageTest.php
+++ b/core/modules/node/lib/Drupal/node/Tests/Views/FrontPageTest.php
@@ -149,4 +149,20 @@ protected function assertNotInResultSet(ViewExecutable $view, array $not_expecte
    $this->assertFalse($found_nids, $message);
  }

+  /**
+   * Tests the frontpage when logged in as admin.
+   */
+  public function testAdminFrontPage() {
+    // When a user with sufficient permissions is logged in, views_ui adds
+    // contextual links to the homepage view. This verifies there are no errors.
+    \Drupal::moduleHandler()->install(array('views_ui'));
+    // Login root user with sufficient permissions.
+    $this->drupalLogin($this->root_user);
+    // Test frontpage view.
+    $this->drupalGet('node');
+    $this->assertResponse(200);
+    // Check that the frontpage view was rendered.
+    $this->assertPattern('/class=".+view-frontpage/', 'Frontpage view was rendered');
+  }
+
 }
--- a/core/modules/views/views.module
+++ b/core/modules/views/views.module
@@ -320,7 +320,7 @@ function views_preprocess_page(&$variables) {
  // page.html.twig, so we can only find it using JavaScript. We therefore
  // remove the "contextual-region" class from the <body> tag here and add
  // JavaScript that will insert it back in the correct place.
-  if (!empty($variables['page']['#views_contextual_links'])) {
+  if (!empty($variables['page']['#views_contextual_links']) && isset($variables['attributes']['class'])) {
    /** @var \Drupal\Core\Page\HtmlPage $page_object */
    $page_object = $variables['page']['#page'];
    $attributes = $page_object->getBodyAttributes();