Issue #2041885 by BTMash, cweagans, klausi: Move HTTP basic authentication...

Issue #2041885 by BTMash, cweagans, klausi: Move HTTP basic authentication provider to a separate module.

core/core.services.yml

@@ -606,11 +606,6 @@ services:
     class: Drupal\Core\Authentication\Provider\Cookie
     tags:
       - { name: authentication_provider, priority: 0 }
-  authentication.http_basic:
-    class: Drupal\Core\Authentication\Provider\HttpBasic
-    arguments: ['@config.factory']
-    tags:
-      - { name: authentication_provider, priority: 100 }
   authentication_subscriber:
     class: Drupal\Core\EventSubscriber\AuthenticationSubscriber
     tags:

core/modules/basic_auth/basic_auth.info.yml

+name: 'HTTP Basic Authentication'
+type: module
+description: 'Provides the HTTP Basic authentication provider'
+package: Web services
+version: VERSION
+core: 8.x

core/modules/basic_auth/basic_auth.module

+<?php
+
+/**
+ * @file
+ * Provides an HTTP Basic authentication provider.
+ */
+
+ /**
+ * Implements hook_help().
+ */
+function basic_auth_help($path, $arg) {
+  switch ($path) {
+    case 'admin/help#basic_auth':
+      $output = '';
+      $output .= '<h3>' . t('About') . '</h3>';
+      $output .= '<p>' . t('The basic auth module implements basic user authentication using the HTTP Basic authentication provider.') . '</p>';
+      return $output;
+  }
+}

core/modules/basic_auth/basic_auth.services.yml

+services:
+  authentication.http_basic:
+    class: Drupal\basic_auth\Authentication\Provider\HttpBasic
+    arguments: ['@config.factory']
+    tags:
+      - { name: authentication_provider, priority: 100 }

core/lib/Drupal/Core/Authentication/Provider/HttpBasic.php → core/modules/basic_auth/lib/Drupal/basic_auth/Authentication/Provider/HttpBasic.php

@@ -2,10 +2,10 @@
 
 /**
  * @file
- * Contains \Drupal\Core\Authentication\Provider\HttpBasic.
+ * Contains \Drupal\basic_auth\Authentication\Provider\HttpBasic.
  */
 
-namespace Drupal\Core\Authentication\Provider;
+namespace Drupal\basic_auth\Authentication\Provider;
 
 use \Drupal\Component\Utility\String;
 use Drupal\Core\Authentication\AuthenticationProviderInterface;

core/modules/system/lib/Drupal/system/Tests/Authentication/HttpBasicTest.php → core/modules/basic_auth/lib/Drupal/basic_auth/Tests/Authentication/HttpBasicTest.php

@@ -2,10 +2,10 @@
 
 /**
  * @file
- * Contains \Drupal\system\Tests\Authentication\HttpBasicTest.
+ * Contains \Drupal\basic_auth\Tests\Authentication\HttpBasicTest.
  */
 
-namespace Drupal\system\Tests\Authentication;
+namespace Drupal\basic_auth\Tests\Authentication;
 
 use Drupal\Core\Authentication\Provider\HttpBasic;
 use Drupal\simpletest\WebTestBase;
@@ -21,7 +21,7 @@ class HttpBasicTest extends WebTestBase {
    *
    * @var array
    */
-  public static $modules = array('router_test');
+  public static $modules = array('basic_auth', 'router_test');
 
   public static function getInfo() {
     return array(

core/modules/rest/lib/Drupal/rest/Tests/AuthTest.php

@@ -19,7 +19,7 @@ class AuthTest extends RESTTestBase {
    *
    * @var array
    */
-  public static $modules = array('hal', 'rest', 'entity_test');
+  public static $modules = array('basic_auth', 'hal', 'rest', 'entity_test');
 
   /**
    * {@inheritdoc}