Issue #2934152 by Wim Leers, neclimdul: ContentTypeHeaderMatcher should not...

Issue #2934152 by Wim Leers, neclimdul: ContentTypeHeaderMatcher should not run for GET, HEAD, OPTIONS or TRACE requests

core/lib/Drupal/Core/Routing/ContentTypeHeaderMatcher.php

@@ -16,8 +16,9 @@ class ContentTypeHeaderMatcher implements FilterInterface {
    */
   public function filter(RouteCollection $collection, Request $request) {
     // The Content-type header does not make sense on GET requests, because GET
-    // requests do not carry any content. Nothing to filter in this case.
-    if ($request->isMethod('GET')) {
+    // requests do not carry any content. Nothing to filter in this case. Same
+    // for all other safe methods.
+    if ($request->isMethodSafe(FALSE)) {
       return $collection;
     }
 

core/tests/Drupal/Tests/Core/Routing/ContentTypeHeaderMatcherTest.php

@@ -42,17 +42,28 @@ protected function setUp() {
   }
 
   /**
-   * Tests that routes are not filtered on GET requests.
+   * Tests that routes are not filtered on safe requests.
+   *
+   * @dataProvider providerTestSafeRequestFilter
    */
-  public function testGetRequestFilter() {
+  public function testSafeRequestFilter($method) {
     $collection = $this->fixtures->sampleRouteCollection();
     $collection->addCollection($this->fixtures->contentRouteCollection());
 
-    $request = Request::create('path/two', 'GET');
+    $request = Request::create('path/two', $method);
     $routes = $this->matcher->filter($collection, $request);
     $this->assertEquals(count($routes), 7, 'The correct number of routes was found.');
   }
 
+  public function providerTestSafeRequestFilter() {
+    return [
+      ['GET'],
+      ['HEAD'],
+      ['OPTIONS'],
+      ['TRACE'],
+    ];
+  }
+
   /**
    * Tests that XML-restricted routes get filtered out on JSON requests.
    */