From a21ee2d711d474e7a2ebd94930cdb446e5bf3a0d Mon Sep 17 00:00:00 2001
From: Alex Pott <alex.a.pott@googlemail.com>
Date: Mon, 13 May 2013 01:04:40 +0100
Subject: [PATCH] Issue #1987674 by tim.plunkett: Convert
 custom_block_type_list() to a new style controller.

---
 .../block/custom_block/custom_block.admin.inc        | 12 ------------
 core/modules/block/custom_block/custom_block.module  |  4 +---
 .../block/custom_block/custom_block.routing.yml      |  8 ++++++++
 3 files changed, 9 insertions(+), 15 deletions(-)

diff --git a/core/modules/block/custom_block/custom_block.admin.inc b/core/modules/block/custom_block/custom_block.admin.inc
index 44af8c414f59..6c74edcda1b8 100644
--- a/core/modules/block/custom_block/custom_block.admin.inc
+++ b/core/modules/block/custom_block/custom_block.admin.inc
@@ -7,18 +7,6 @@
 
 use Drupal\custom_block\Plugin\Core\Entity\CustomBlockType;
 
-/**
- * Page callback: Lists custom block types.
- *
- * @return array
- *   A build array in the format expected by drupal_render().
- *
- * @see custom_block_menu()
- */
-function custom_block_type_list() {
-  return Drupal::entityManager()->getListController('custom_block_type')->render();
-}
-
 /**
  * Page callback: Presents the custom block type creation form.
  *
diff --git a/core/modules/block/custom_block/custom_block.module b/core/modules/block/custom_block/custom_block.module
index a1fc680d1205..e674f7b343f9 100644
--- a/core/modules/block/custom_block/custom_block.module
+++ b/core/modules/block/custom_block/custom_block.module
@@ -34,9 +34,7 @@ function custom_block_menu() {
   $items['admin/structure/custom-blocks'] = array(
     'title' => 'Custom block types',
     'description' => 'Manage custom block types.',
-    'page callback' => 'custom_block_type_list',
-    'access arguments' => array('administer blocks'),
-    'file' => 'custom_block.admin.inc',
+    'route_name' => 'custom_block_type_list',
   );
   $items['admin/structure/custom-blocks/add'] = array(
     'title' => 'Add custom block type',
diff --git a/core/modules/block/custom_block/custom_block.routing.yml b/core/modules/block/custom_block/custom_block.routing.yml
index ed4ab92a9ec7..ac4ec997e4db 100644
--- a/core/modules/block/custom_block/custom_block.routing.yml
+++ b/core/modules/block/custom_block/custom_block.routing.yml
@@ -1,3 +1,11 @@
+custom_block_type_list:
+  pattern: '/admin/structure/custom-blocks'
+  defaults:
+    _content: '\Drupal\Core\Entity\Controller\EntityListController::listing'
+    entity_type: 'custom_block_type'
+  requirements:
+    _permission: 'administer blocks'
+
 custom_block_add_page:
   pattern: block/add
   defaults:
-- 
GitLab