From 9f0c3d9fceea863e5fee4a0857aaaad85fc19729 Mon Sep 17 00:00:00 2001
From: Alex Pott <alex.a.pott@googlemail.com>
Date: Fri, 23 Feb 2024 14:20:50 +0000
Subject: [PATCH] Issue #3423329 by catch, kristiaanvandeneynde, dww, alexpott:
Prevent session garbage collection during functional tests
(cherry picked from commit 4c8f1df76bc800b639a48dc479bf555d1cdf3cc4)
---
.../Core/Test/FunctionalTestSetupTrait.php | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php b/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php
index e2cfcbb07c94..363eba0bf0ef 100644
--- a/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php
+++ b/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php
@@ -129,13 +129,17 @@ protected function prepareSettings() {
// Otherwise, use the default services as a starting point for overrides.
$settings_services_file = DRUPAL_ROOT . '/sites/default/default.services.yml';
}
- // Copy the testing-specific service overrides in place.
- copy($settings_services_file, $directory . '/services.yml');
+
+ // Put the testing-specific service overrides in place.
+ $yaml = new SymfonyYaml();
+ $content = file_get_contents($settings_services_file);
+ // Disable session garbage collection since test environments do not last
+ // long enough to have stale sessions. This prevents random delete queries
+ // from running during tests.
+ $services = $yaml->parse($content);
+ $services['parameters']['session.storage.options']['gc_probability'] = 0;
if ($this->strictConfigSchema) {
// Add a listener to validate configuration schema on save.
- $yaml = new SymfonyYaml();
- $content = file_get_contents($directory . '/services.yml');
- $services = $yaml->parse($content);
$test_file_name = (new \ReflectionClass($this))->getFileName();
// @todo Decide in https://www.drupal.org/project/drupal/issues/3395099 when/how to trigger deprecation errors or even failures for contrib modules.
$is_core_test = str_starts_with($test_file_name, DRUPAL_ROOT . DIRECTORY_SEPARATOR . 'core');
@@ -144,8 +148,8 @@ protected function prepareSettings() {
'arguments' => ['@config.typed', $this->getConfigSchemaExclusions(), $is_core_test],
'tags' => [['name' => 'event_subscriber']],
];
- file_put_contents($directory . '/services.yml', $yaml->dump($services));
}
+ file_put_contents($directory . '/services.yml', $yaml->dump($services));
// Since Drupal is bootstrapped already, install_begin_request() will not
// bootstrap again. Hence, we have to reload the newly written custom
// settings.php manually.
--
GitLab