diff --git a/composer.json b/composer.json index 7bd255c547609bf524ec61ebfa240d3e6c952ce3..926b0fc4df215c499677747330420ac8b6157f53 100644 --- a/composer.json +++ b/composer.json @@ -23,7 +23,7 @@ "drupal/coder": "^8.3.10", "instaclick/php-webdriver": "^1.4.1", "justinrainbow/json-schema": "^5.2", - "mglaman/phpstan-drupal": "^1.1.29", + "mglaman/phpstan-drupal": "^1.1.30", "mikey179/vfsstream": "^1.6.11", "phpspec/prophecy-phpunit": "^2", "phpstan/extension-installer": "^1.1", diff --git a/composer.lock b/composer.lock index e88cc940531716bca8c8a007cd066831d49d1b1c..616d8d8b0b75a44ae3c640e3517b0705ea61de9e 100644 --- a/composer.lock +++ b/composer.lock @@ -4,7 +4,7 @@ "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies", "This file is @generated automatically" ], - "content-hash": "e2a1cb0d156a2efb1cc295f77cc354af", + "content-hash": "5d9667a31f9310fc88c2bbcb55616128", "packages": [ { "name": "asm89/stack-cors", @@ -5360,16 +5360,16 @@ }, { "name": "mglaman/phpstan-drupal", - "version": "1.1.29", + "version": "1.1.30", "source": { "type": "git", "url": "https://github.com/mglaman/phpstan-drupal.git", - "reference": "e6f6191c53b159013fcbd186d7f85511f3f96ff8" + "reference": "21b62499bb1233667f4d2bc6ce11db73500734fe" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/mglaman/phpstan-drupal/zipball/e6f6191c53b159013fcbd186d7f85511f3f96ff8", - "reference": "e6f6191c53b159013fcbd186d7f85511f3f96ff8", + "url": "https://api.github.com/repos/mglaman/phpstan-drupal/zipball/21b62499bb1233667f4d2bc6ce11db73500734fe", + "reference": "21b62499bb1233667f4d2bc6ce11db73500734fe", "shasum": "" }, "require": { @@ -5444,7 +5444,7 @@ "description": "Drupal extension and rules for PHPStan", "support": { "issues": "https://github.com/mglaman/phpstan-drupal/issues", - "source": "https://github.com/mglaman/phpstan-drupal/tree/1.1.29" + "source": "https://github.com/mglaman/phpstan-drupal/tree/1.1.30" }, "funding": [ { @@ -5460,7 +5460,7 @@ "type": "tidelift" } ], - "time": "2023-02-08T21:44:03+00:00" + "time": "2023-04-07T13:36:19+00:00" }, { "name": "mikey179/vfsstream", diff --git a/composer/Metapackage/DevDependencies/composer.json b/composer/Metapackage/DevDependencies/composer.json index 8647a1f99922834092fb224445214310a26c44d0..5a2e6394696c81fb8d3d7679d46f48bff33ac17b 100644 --- a/composer/Metapackage/DevDependencies/composer.json +++ b/composer/Metapackage/DevDependencies/composer.json @@ -15,7 +15,7 @@ "drupal/coder": "^8.3.10", "instaclick/php-webdriver": "^1.4.1", "justinrainbow/json-schema": "^5.2", - "mglaman/phpstan-drupal": "^1.1.29", + "mglaman/phpstan-drupal": "^1.1.30", "mikey179/vfsstream": "^1.6.11", "phpspec/prophecy-phpunit": "^2", "phpstan/extension-installer": "^1.1", diff --git a/composer/Metapackage/PinnedDevDependencies/composer.json b/composer/Metapackage/PinnedDevDependencies/composer.json index b3e75da8bff1d55d72976df1fb5ba47540ae970f..4732a8aeeb4d8e512fd4971951d3f9755a099acb 100644 --- a/composer/Metapackage/PinnedDevDependencies/composer.json +++ b/composer/Metapackage/PinnedDevDependencies/composer.json @@ -24,7 +24,7 @@ "drupal/coder": "8.3.17", "instaclick/php-webdriver": "1.4.16", "justinrainbow/json-schema": "5.2.12", - "mglaman/phpstan-drupal": "1.1.29", + "mglaman/phpstan-drupal": "1.1.30", "mikey179/vfsstream": "v1.6.11", "myclabs/deep-copy": "1.11.1", "nikic/php-parser": "v4.15.4", diff --git a/core/phpstan-baseline.neon b/core/phpstan-baseline.neon index a09976ba7d15bd274a1e9397be6c72b833993c08..b7db3ef1cd9c8d4ba7c3fc23d2d8080e75439e46 100644 --- a/core/phpstan-baseline.neon +++ b/core/phpstan-baseline.neon @@ -40,11 +40,6 @@ parameters: count: 1 path: includes/theme.maintenance.inc - - - message: "#^A file could not be loaded from Drupal\\\\Core\\\\Extension\\\\ModuleHandlerInterface\\:\\:loadInclude$#" - count: 1 - path: includes/update.inc - - message: "#^Call to an undefined method Drupal\\\\Component\\\\Datetime\\\\DateTimePlus\\:\\:getTimeZone\\(\\)\\.$#" count: 1 @@ -360,21 +355,11 @@ parameters: count: 1 path: lib/Drupal/Core/Entity/Controller/EntityController.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 1 - path: lib/Drupal/Core/Entity/Entity/EntityFormDisplay.php - - message: "#^Variable \\$candidate_ids might not be defined\\.$#" count: 2 path: lib/Drupal/Core/Entity/Entity/EntityFormDisplay.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 1 - path: lib/Drupal/Core/Entity/Entity/EntityViewDisplay.php - - message: "#^Variable \\$string in isset\\(\\) always exists and is not nullable\\.$#" count: 1 @@ -800,11 +785,6 @@ parameters: count: 1 path: modules/block/tests/src/Functional/BlockUiTest.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 3 - path: modules/block/tests/src/Kernel/NewDefaultThemeBlocksTest.php - - message: "#^Variable \\$row in empty\\(\\) is never defined\\.$#" count: 1 @@ -890,11 +870,6 @@ parameters: count: 2 path: modules/ckeditor5/ckeditor5.module - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 1 - path: modules/ckeditor5/src/Plugin/CKEditor5Plugin/MediaLibrary.php - - message: "#^Variable \\$ghs_config_classes in empty\\(\\) always exists and is always falsy\\.$#" count: 1 @@ -990,11 +965,6 @@ parameters: count: 1 path: modules/config/tests/src/Functional/ConfigInstallProfileUnmetDependenciesTest.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 1 - path: modules/config_translation/src/Controller/ConfigTranslationFieldListBuilder.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:11\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 1 @@ -1155,16 +1125,6 @@ parameters: count: 1 path: modules/dblog/tests/src/Kernel/DbLogTest.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 2 - path: modules/field/field.module - - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 1 - path: modules/field/src/ConfigImporterFieldPurger.php - - message: "#^Variable \\$items in empty\\(\\) always exists and is not falsy\\.$#" count: 1 @@ -1185,11 +1145,6 @@ parameters: count: 1 path: modules/field/tests/src/Kernel/FieldAttachStorageTest.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 2 - path: modules/field/tests/src/Kernel/FieldImportCreateTest.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:11\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 1 @@ -1235,11 +1190,6 @@ parameters: count: 1 path: modules/field_ui/src/Form/FieldConfigEditForm.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 1 - path: modules/field_ui/src/Form/FieldStorageAddForm.php - - message: "#^Method Drupal\\\\field_ui\\\\Form\\\\FieldStorageConfigEditForm\\:\\:save\\(\\) should return int but return statement is missing\\.$#" count: 1 @@ -1315,11 +1265,6 @@ parameters: count: 2 path: modules/file/tests/src/Kernel/UsageTest.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 2 - path: modules/filter/src/FilterFormatFormBase.php - - message: "#^Variable \\$rows might not be defined\\.$#" count: 1 @@ -1575,11 +1520,6 @@ parameters: count: 1 path: modules/media/src/OEmbed/UrlResolver.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 1 - path: modules/media_library/src/Plugin/Field/FieldWidget/MediaLibraryWidget.php - - message: "#^Variable \\$jpg_image might not be defined\\.$#" count: 1 @@ -1990,11 +1930,6 @@ parameters: count: 1 path: modules/search/src/Form/SearchPageFormBase.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 2 - path: modules/search/src/Form/SearchPageFormBase.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:11\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 1 @@ -2035,11 +1970,6 @@ parameters: count: 1 path: modules/shortcut/src/Form/SetCustomize.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 1 - path: modules/shortcut/src/Form/SwitchShortcutSet.php - - message: "#^Method Drupal\\\\shortcut\\\\ShortcutForm\\:\\:save\\(\\) should return int but return statement is missing\\.$#" count: 1 @@ -2085,11 +2015,6 @@ parameters: count: 1 path: modules/system/src/Form/DateFormatFormBase.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 1 - path: modules/system/src/Form/DateFormatFormBase.php - - message: "#^Method Drupal\\\\system\\\\Form\\\\ModulesListNonStableConfirmForm\\:\\:getQuestion\\(\\) should return Drupal\\\\Core\\\\StringTranslation\\\\TranslatableMarkup but return statement is missing\\.$#" count: 1 @@ -2265,11 +2190,6 @@ parameters: count: 1 path: modules/tour/src/TipPluginBase.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 1 - path: modules/tour/tour.module - - message: "#^Variable \\$violation_messages might not be defined\\.$#" count: 1 @@ -2295,11 +2215,6 @@ parameters: count: 2 path: modules/user/src/EventSubscriber/UserRequestSubscriber.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 2 - path: modules/user/src/Form/RoleSettingsForm.php - - message: "#^Variable \\$route_object might not be defined\\.$#" count: 1 @@ -2560,11 +2475,6 @@ parameters: count: 1 path: modules/views/src/Plugin/views/field/PrerenderList.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 1 - path: modules/views/src/Plugin/views/field/RenderedEntity.php - - message: "#^Variable \\$entity in isset\\(\\) always exists and is not nullable\\.$#" count: 1 @@ -2675,11 +2585,6 @@ parameters: count: 1 path: modules/views/src/ViewExecutable.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 3 - path: modules/views/src/Views.php - - message: "#^Variable \\$view in isset\\(\\) always exists and is not nullable\\.$#" count: 2 @@ -2810,11 +2715,6 @@ parameters: count: 1 path: modules/views_ui/tests/src/FunctionalJavascript/PreviewTest.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 1 - path: modules/workflows/src/Entity/Workflow.php - - message: "#^Method Drupal\\\\workflows\\\\Form\\\\WorkflowEditForm\\:\\:save\\(\\) should return int but return statement is missing\\.$#" count: 1 @@ -2885,11 +2785,6 @@ parameters: count: 1 path: modules/workspaces/tests/src/Kernel/WorkspaceAccessTest.php - - - message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\\(\\) with TRUE or FALSE to specify whether access should be checked\\.$#" - count: 1 - path: modules/workspaces/workspaces.install - - message: "#^Variable \\$keyed_content might not be defined\\.$#" count: 1 @@ -3045,11 +2940,6 @@ parameters: count: 1 path: tests/Drupal/TestSite/Commands/TestSiteInstallCommand.php - - - message: "#^A file could not be loaded from Drupal\\\\Core\\\\Extension\\\\ModuleHandlerInterface\\:\\:loadInclude$#" - count: 1 - path: tests/Drupal/TestTools/Extension/SchemaInspector.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:11\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 1