From 999dbefc55310b4d11565e9c2e9f3e39302e113f Mon Sep 17 00:00:00 2001
From: Alex Pott <alex.a.pott@googlemail.com>
Date: Sun, 3 May 2020 12:40:58 +0100
Subject: [PATCH] Issue #3082006 by id.aleks, cambraca, mr.baileys, sokru,
alexpott, larowlan, longwave: User password field is empty in Views
---
core/modules/user/src/UserViewsData.php | 4 ++
.../src/Kernel/Views/UserViewsDataTest.php | 57 +++++++++++++++++++
2 files changed, 61 insertions(+)
create mode 100644 core/modules/user/tests/src/Kernel/Views/UserViewsDataTest.php
diff --git a/core/modules/user/src/UserViewsData.php b/core/modules/user/src/UserViewsData.php
index 955ab5967bc1..ae5d681094b2 100644
--- a/core/modules/user/src/UserViewsData.php
+++ b/core/modules/user/src/UserViewsData.php
@@ -249,6 +249,10 @@ public function getViewsData() {
],
];
+ // Unset the "pass" field because the access control handler for the user
+ // entity type allows editing the password, but not viewing it.
+ unset($data['users_field_data']['pass']);
+
return $data;
}
diff --git a/core/modules/user/tests/src/Kernel/Views/UserViewsDataTest.php b/core/modules/user/tests/src/Kernel/Views/UserViewsDataTest.php
new file mode 100644
index 000000000000..656772535ed8
--- /dev/null
+++ b/core/modules/user/tests/src/Kernel/Views/UserViewsDataTest.php
@@ -0,0 +1,57 @@
+<?php
+
+namespace Drupal\Tests\user\Kernel\Views;
+
+use Drupal\KernelTests\KernelTestBase;
+
+/**
+ * Contains tests related to the views data for the user entity type.
+ *
+ * @group user
+ *
+ * @see \Drupal\user\UserViewsData
+ */
+class UserViewsDataTest extends KernelTestBase {
+
+ /**
+ * The views data service.
+ *
+ * @var \Drupal\views\ViewsData
+ */
+ protected $viewsData;
+
+ /**
+ * The entity field manager.
+ *
+ * @var \Drupal\Core\Entity\EntityFieldManagerInterface
+ */
+ protected $entityFieldManager;
+
+ /**
+ * {@inheritdoc}
+ */
+ protected static $modules = [
+ 'system',
+ 'user',
+ 'views',
+ ];
+
+ /**
+ * {@inheritdoc}
+ */
+ protected function setUp() {
+ parent::setUp();
+ $this->viewsData = $this->container->get('views.views_data');
+ $this->entityFieldManager = $this->container->get('entity_field.manager');
+ }
+
+ /**
+ * Tests if user views data object doesn't contain pass field.
+ */
+ public function testUserPasswordFieldNotAvailableToViews() {
+ $field_definitions = $this->entityFieldManager->getBaseFieldDefinitions('user');
+ $this->assertArrayHasKey('pass', $field_definitions);
+ $this->assertArrayNotHasKey('pass', $this->viewsData->get('users_field_data'));
+ }
+
+}
--
GitLab