From 90e7bdd06790ab0577ee9fa155e01b01f1380294 Mon Sep 17 00:00:00 2001 From: Alex Pott <alex.a.pott@googlemail.com> Date: Mon, 27 Apr 2015 15:03:24 +0100 Subject: [PATCH] Issue #2408481 by kyuubi, Karmen: Rewrite help.module component's inline with our CSS standards --- core/modules/forum/forum.module | 5 ++++- core/modules/system/css/system.theme.css | 14 +++----------- core/themes/seven/css/components/help.css | 10 +++------- 3 files changed, 10 insertions(+), 19 deletions(-) diff --git a/core/modules/forum/forum.module b/core/modules/forum/forum.module index 026967e796c4..54d0050f2752 100644 --- a/core/modules/forum/forum.module +++ b/core/modules/forum/forum.module @@ -58,12 +58,15 @@ function forum_help($route_name, RouteMatchInterface $route_match) { '#type' => 'link', '#url' => Url::fromRoute('help.page', ['name' => 'forum']), '#title' => t('More help'), + '#attributes' => array( + 'class' => array('icon-help'), + ), ); $container = array( '#theme' => 'container', '#children' => drupal_render($more_help_link), '#attributes' => array( - 'class' => array('more-help-link'), + 'class' => array('more-link'), ), ); $output .= drupal_render($container); diff --git a/core/modules/system/css/system.theme.css b/core/modules/system/css/system.theme.css index 0f5b08fdd165..a74bac0c9ca5 100644 --- a/core/modules/system/css/system.theme.css +++ b/core/modules/system/css/system.theme.css @@ -143,20 +143,12 @@ abbr.ajax-changed { text-align: left; } -/** - * More help link style. - */ -.more-help-link { - text-align: right; /* LTR */ -} -[dir="rtl"] .more-help-link { - text-align: left; -} -.more-help-link a { +/* Style for the help icon. */ +.icon-help { background: url(../../../misc/help.png) 0 50% no-repeat; /* LTR */ padding: 1px 0 1px 20px; /* LTR */ } -[dir="rtl"] .more-help-link a { +[dir="rtl"] .icon-help { background-position: 100% 50%; padding: 1px 20px 1px 0; } diff --git a/core/themes/seven/css/components/help.css b/core/themes/seven/css/components/help.css index f075c764682a..1cbcbd49fe51 100644 --- a/core/themes/seven/css/components/help.css +++ b/core/themes/seven/css/components/help.css @@ -1,12 +1,8 @@ /** - * Help. + * @file + * Seven styles for the help component. */ + .help p { margin: 0 0 10px; } -.help div.more-help-link { - text-align: right; /* LTR */ -} -[dir="rtl"] .help div.more-help-link { - text-align: left; -} -- GitLab