From 87b8c59a4926c0bad8f924742564fece2743bd30 Mon Sep 17 00:00:00 2001
From: nod_ <nod_@598310.no-reply.drupal.org>
Date: Thu, 25 Jul 2024 22:00:51 +0200
Subject: [PATCH] Issue #3462549 by catch, ankitv18: Optimize
TelephoneFieldTest
(cherry picked from commit c0e94e34469f42f1796712aaa8e1bb9447b206a0)
---
.../src/Functional/TelephoneFieldTest.php | 34 ++++++++-----------
1 file changed, 14 insertions(+), 20 deletions(-)
diff --git a/core/modules/telephone/tests/src/Functional/TelephoneFieldTest.php b/core/modules/telephone/tests/src/Functional/TelephoneFieldTest.php
index 16573fffa8de..001d004a4b8f 100644
--- a/core/modules/telephone/tests/src/Functional/TelephoneFieldTest.php
+++ b/core/modules/telephone/tests/src/Functional/TelephoneFieldTest.php
@@ -13,7 +13,6 @@
* Tests the creation of telephone fields.
*
* @group telephone
- * @group #slow
*/
class TelephoneFieldTest extends BrowserTestBase {
@@ -101,26 +100,9 @@ public function testTelephoneWidget(): void {
* Tests the telephone formatter.
*
* @covers \Drupal\telephone\Plugin\Field\FieldFormatter\TelephoneLinkFormatter::viewElements
- *
- * @dataProvider providerPhoneNumbers
- */
- public function testTelephoneFormatter($input, $expected): void {
- // Test basic entry of telephone field.
- $edit = [
- 'title[0][value]' => $this->randomMachineName(),
- 'field_telephone[0][value]' => $input,
- ];
-
- $this->drupalGet('node/add/article');
- $this->submitForm($edit, 'Save');
- $this->assertSession()->responseContains('<a href="tel:' . $expected . '">');
- }
-
- /**
- * Provides the phone numbers to check and expected results.
*/
- public static function providerPhoneNumbers() {
- return [
+ public function testTelephoneFormatter(): void {
+ $phone_numbers = [
'standard phone number' => ['123456789', '123456789'],
'whitespace is removed' => ['1234 56789', '123456789'],
'parse_url(0) return FALSE workaround' => ['0', '0-'],
@@ -133,6 +115,18 @@ public static function providerPhoneNumbers() {
'php bug 70588 workaround - invalid port number - upper edge check' => ['99999', '9-9999'],
'lowest number not affected by php bug 70588' => ['100000', '100000'],
];
+ foreach ($phone_numbers as $data) {
+ [$input, $expected] = $data;
+ // Test basic entry of telephone field.
+ $edit = [
+ 'title[0][value]' => $this->randomMachineName(),
+ 'field_telephone[0][value]' => $input,
+ ];
+
+ $this->drupalGet('node/add/article');
+ $this->submitForm($edit, 'Save');
+ $this->assertSession()->responseContains('<a href="tel:' . $expected . '">');
+ }
}
}
--
GitLab