From 7ff11794e533f53c57a1f69b51f8777b1ee65723 Mon Sep 17 00:00:00 2001 From: xjm <xjm@65776.no-reply.drupal.org> Date: Tue, 19 May 2020 13:54:06 -0500 Subject: [PATCH] Issue #2821499 by jungle, Andy_D, nikitagupta, lomasr, bbombachini, alexpott, andypost, Mile23, quietone, Sophie.SK, mtodor, barone, kuldeep_mehra27, vsujeetkumar, swatichouhan012, jhodgdon: Enable phpcs rule DrupalPractice.InfoFiles.NamespacedDependency --- .../help_topics_test/help_topics_test.info.yml | 2 +- .../layout_builder_views_test.info.yml | 2 +- .../migrate_drupal_multilingual.info.yml | 2 +- .../rdf/tests/rdf_test/rdf_test.info.yml | 2 +- .../tests/modules/form_test/form_test.info.yml | 4 ++-- .../new_dependency_test.info.yml | 2 +- .../user_batch_action_test.info.yml | 4 ++-- core/phpcs.xml.dist | 1 + .../demo_umami_content.info.yml | 18 +++++++++--------- ...g_install_profile_all_dependencies.info.yml | 4 ++-- ...sting_install_profile_dependencies.info.yml | 2 +- 11 files changed, 22 insertions(+), 21 deletions(-) diff --git a/core/modules/help_topics/tests/modules/help_topics_test/help_topics_test.info.yml b/core/modules/help_topics/tests/modules/help_topics_test/help_topics_test.info.yml index cf74fada3db8..d81219bd5c67 100644 --- a/core/modules/help_topics/tests/modules/help_topics_test/help_topics_test.info.yml +++ b/core/modules/help_topics/tests/modules/help_topics_test/help_topics_test.info.yml @@ -5,4 +5,4 @@ type: module description: 'Support module for help testing.' package: Testing dependencies: - - help_topics + - drupal:help_topics diff --git a/core/modules/layout_builder/tests/modules/layout_builder_views_test/layout_builder_views_test.info.yml b/core/modules/layout_builder/tests/modules/layout_builder_views_test/layout_builder_views_test.info.yml index 79d88d27df69..b2e83e05b1a7 100644 --- a/core/modules/layout_builder/tests/modules/layout_builder_views_test/layout_builder_views_test.info.yml +++ b/core/modules/layout_builder/tests/modules/layout_builder_views_test/layout_builder_views_test.info.yml @@ -4,4 +4,4 @@ description: 'Support module for testing.' package: Testing version: VERSION dependencies: - - views + - drupal:views diff --git a/core/modules/migrate_drupal_multilingual/migrate_drupal_multilingual.info.yml b/core/modules/migrate_drupal_multilingual/migrate_drupal_multilingual.info.yml index f57f39918621..42facebcf54a 100644 --- a/core/modules/migrate_drupal_multilingual/migrate_drupal_multilingual.info.yml +++ b/core/modules/migrate_drupal_multilingual/migrate_drupal_multilingual.info.yml @@ -3,5 +3,5 @@ type: module description: 'Provides a requirement for multilingual migrations.' package: 'Core (Experimental)' dependencies: - - migrate_drupal + - drupal:migrate_drupal hidden: true diff --git a/core/modules/rdf/tests/rdf_test/rdf_test.info.yml b/core/modules/rdf/tests/rdf_test/rdf_test.info.yml index 69f5c889fb9b..f9e9b999d8f1 100644 --- a/core/modules/rdf/tests/rdf_test/rdf_test.info.yml +++ b/core/modules/rdf/tests/rdf_test/rdf_test.info.yml @@ -4,4 +4,4 @@ description: 'Test functionality for the RDF module.' package: Testing version: VERSION dependencies: - - rdf + - drupal:rdf diff --git a/core/modules/system/tests/modules/form_test/form_test.info.yml b/core/modules/system/tests/modules/form_test/form_test.info.yml index 927575e0504b..a7f7be3c6d44 100644 --- a/core/modules/system/tests/modules/form_test/form_test.info.yml +++ b/core/modules/system/tests/modules/form_test/form_test.info.yml @@ -4,5 +4,5 @@ description: 'Support module for Form API tests.' package: Testing version: VERSION dependencies: - - file - - filter + - drupal:file + - drupal:filter diff --git a/core/modules/system/tests/modules/new_dependency_test/new_dependency_test.info.yml b/core/modules/system/tests/modules/new_dependency_test/new_dependency_test.info.yml index 4e45cd816a68..a560829b5ce0 100644 --- a/core/modules/system/tests/modules/new_dependency_test/new_dependency_test.info.yml +++ b/core/modules/system/tests/modules/new_dependency_test/new_dependency_test.info.yml @@ -4,4 +4,4 @@ description: 'Support module for update testing.' package: Testing version: VERSION dependencies: - - new_dependency_test_with_service + - drupal:new_dependency_test_with_service diff --git a/core/modules/views/tests/modules/user_batch_action_test/user_batch_action_test.info.yml b/core/modules/views/tests/modules/user_batch_action_test/user_batch_action_test.info.yml index 31a8f01ba78b..4dcd2838041f 100644 --- a/core/modules/views/tests/modules/user_batch_action_test/user_batch_action_test.info.yml +++ b/core/modules/views/tests/modules/user_batch_action_test/user_batch_action_test.info.yml @@ -4,5 +4,5 @@ description: 'Support module for user batch action testing.' package: Testing version: VERSION dependencies: - - views - - user + - drupal:views + - drupal:user diff --git a/core/phpcs.xml.dist b/core/phpcs.xml.dist index 387fdf0a8057..951edd8690ff 100644 --- a/core/phpcs.xml.dist +++ b/core/phpcs.xml.dist @@ -149,6 +149,7 @@ <!-- Drupal Practice sniffs --> <rule ref="DrupalPractice.Commenting.ExpectedException"/> <rule ref="DrupalPractice.General.ExceptionT"/> + <rule ref="DrupalPractice.InfoFiles.NamespacedDependency"/> <!-- Generic sniffs --> <rule ref="Generic.Arrays.DisallowLongArraySyntax"/> diff --git a/core/profiles/demo_umami/modules/demo_umami_content/demo_umami_content.info.yml b/core/profiles/demo_umami/modules/demo_umami_content/demo_umami_content.info.yml index 928957465b0d..9c97b0adf1d1 100644 --- a/core/profiles/demo_umami/modules/demo_umami_content/demo_umami_content.info.yml +++ b/core/profiles/demo_umami/modules/demo_umami_content/demo_umami_content.info.yml @@ -5,12 +5,12 @@ version: VERSION package: 'Core (Experimental)' hidden: true dependencies: - - field - - file - - image - - node - - options - - path - - taxonomy - - text - - user + - drupal:field + - drupal:file + - drupal:image + - drupal:node + - drupal:options + - drupal:path + - drupal:taxonomy + - drupal:text + - drupal:user diff --git a/core/profiles/testing_install_profile_all_dependencies/testing_install_profile_all_dependencies.info.yml b/core/profiles/testing_install_profile_all_dependencies/testing_install_profile_all_dependencies.info.yml index 0459bf017ebd..64495e648d1b 100644 --- a/core/profiles/testing_install_profile_all_dependencies/testing_install_profile_all_dependencies.info.yml +++ b/core/profiles/testing_install_profile_all_dependencies/testing_install_profile_all_dependencies.info.yml @@ -4,8 +4,8 @@ description: 'Profile for testing that install profiles can require a module.' version: VERSION hidden: true dependencies: - - ban - - dblog + - drupal:ban + - drupal:dblog install: [] themes: - classy diff --git a/core/profiles/testing_install_profile_dependencies/testing_install_profile_dependencies.info.yml b/core/profiles/testing_install_profile_dependencies/testing_install_profile_dependencies.info.yml index ce179854192f..cb884f3aab26 100644 --- a/core/profiles/testing_install_profile_dependencies/testing_install_profile_dependencies.info.yml +++ b/core/profiles/testing_install_profile_dependencies/testing_install_profile_dependencies.info.yml @@ -4,7 +4,7 @@ description: 'Profile for testing that install profiles can require a module.' version: VERSION hidden: true dependencies: - - dblog + - drupal:dblog install: - ban themes: -- GitLab