Issue #2924780 by zaporylie: Missing @var annotation for scalars that provide default values

core/lib/Drupal/Component/Datetime/DateTimePlus.php

@@ -66,31 +66,43 @@ class DateTimePlus {
 
   /**
    * The value of the time value passed to the constructor.
+   *
+   * @var string
    */
   protected $inputTimeRaw = '';
 
   /**
    * The prepared time, without timezone, for this date.
+   *
+   * @var string
    */
   protected $inputTimeAdjusted = '';
 
   /**
    * The value of the timezone passed to the constructor.
+   *
+   * @var string
    */
   protected $inputTimeZoneRaw = '';
 
   /**
    * The prepared timezone object used to construct this date.
+   *
+   * @var string
    */
   protected $inputTimeZoneAdjusted = '';
 
   /**
    * The value of the format passed to the constructor.
+   *
+   * @var string
    */
   protected $inputFormatRaw = '';
 
   /**
    * The prepared format, if provided.
+   *
+   * @var string
    */
   protected $inputFormatAdjusted = '';
 

core/lib/Drupal/Core/Database/Driver/sqlite/Schema.php

@@ -19,6 +19,8 @@ class Schema extends DatabaseSchema {
 
   /**
    * Override DatabaseSchema::$defaultSchema
+   *
+   * @var string
    */
   protected $defaultSchema = 'main';
 

core/lib/Drupal/Core/Database/Query/Query.php

@@ -48,6 +48,8 @@ abstract class Query implements PlaceholderInterface {
 
   /**
    * The placeholder counter.
+   *
+   * @var int
    */
   protected $nextPlaceholder = 0;
 

core/lib/Drupal/Core/Database/Query/Select.php

@@ -113,6 +113,8 @@ class Select extends Query implements SelectInterface {
 
   /**
    * The FOR UPDATE status
+   *
+   * @var bool
    */
   protected $forUpdate = FALSE;
 

core/lib/Drupal/Core/Database/Query/SelectExtender.php

@@ -30,6 +30,8 @@ class SelectExtender implements SelectInterface {
 
   /**
    * The placeholder counter.
+   *
+   * @var int
    */
   protected $placeholder = 0;
 

core/lib/Drupal/Core/Database/Schema.php

@@ -19,6 +19,8 @@ abstract class Schema implements PlaceholderInterface {
 
   /**
    * The placeholder counter.
+   *
+   * @var int
    */
   protected $placeholder = 0;
 
@@ -30,6 +32,8 @@ abstract class Schema implements PlaceholderInterface {
    * method.
    *
    * @see DatabaseSchema::getPrefixInfo()
+   *
+   * @var string
    */
   protected $defaultSchema = 'public';
 

core/lib/Drupal/Core/Entity/Annotation/EntityType.php

@@ -33,6 +33,8 @@ class EntityType extends Plugin {
 
   /**
    * The group machine name.
+   *
+   * @var string
    */
   public $group = 'default';
 

core/lib/Drupal/Core/Password/PhpassHashedPassword.php

@@ -28,6 +28,8 @@ class PhpassHashedPassword implements PasswordInterface {
 
   /**
    * Returns a string for mapping an int to the corresponding base 64 character.
+   *
+   * @var string
    */
   public static $ITOA64 = './0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz';
 

core/modules/block_content/src/Tests/BlockContentTestBase.php

@@ -16,6 +16,8 @@ abstract class BlockContentTestBase extends WebTestBase {
 
   /**
    * Profile to use.
+   *
+   * @var string
    */
   protected $profile = 'testing';
 

core/modules/block_content/tests/src/Functional/BlockContentTestBase.php

@@ -13,6 +13,8 @@ abstract class BlockContentTestBase extends BrowserTestBase {
 
   /**
    * Profile to use.
+   *
+   * @var string
    */
   protected $profile = 'testing';
 

core/modules/comment/src/Entity/Comment.php

@@ -73,6 +73,8 @@ class Comment extends ContentEntityBase implements CommentInterface {
 
   /**
    * The thread for which a lock was acquired.
+   *
+   * @var string
    */
   protected $threadLock = '';
 

core/modules/comment/src/Plugin/views/wizard/Comment.php

@@ -21,6 +21,8 @@ class Comment extends WizardPluginBase {
 
   /**
    * Set the created column.
+   *
+   * @var string
    */
   protected $createdColumn = 'created';
 

core/modules/content_moderation/tests/src/Functional/ModerationStateTestBase.php

@@ -13,6 +13,8 @@ abstract class ModerationStateTestBase extends BrowserTestBase {
 
   /**
    * Profile to use.
+   *
+   * @var string
    */
   protected $profile = 'testing';
 

core/modules/datetime/tests/src/Kernel/Views/FilterDateTimeTest.php

@@ -25,6 +25,8 @@ class FilterDateTimeTest extends DateTimeHandlerTestBase {
 
   /**
    * Use a non-UTC timezone.
+   *
+   * @var string
    */
   protected static $timezone = 'America/Vancouver';
 

core/modules/dblog/src/Plugin/views/wizard/Watchdog.php

@@ -18,6 +18,8 @@ class Watchdog extends WizardPluginBase {
 
   /**
    * Set the created column.
+   *
+   * @var string
    */
   protected $createdColumn = 'timestamp';
 

core/modules/file/src/Plugin/views/wizard/File.php

@@ -17,6 +17,8 @@ class File extends WizardPluginBase {
 
   /**
    * Set the created column.
+   *
+   * @var string
    */
   protected $createdColumn = 'created';
 

core/modules/help/tests/src/Functional/HelpTest.php

@@ -24,6 +24,8 @@ class HelpTest extends BrowserTestBase {
 
   /**
    * Use the Standard profile to test help implementations of many core modules.
+   *
+   * @var string
    */
   protected $profile = 'standard';
 

core/modules/migrate_drupal_ui/src/Tests/MigrateUpgradeTestBase.php

@@ -20,6 +20,8 @@ abstract class MigrateUpgradeTestBase extends WebTestBase {
 
   /**
    * Use the Standard profile to test help implementations of many core modules.
+   *
+   * @var string
    */
   protected $profile = 'standard';
 

core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeTestBase.php

@@ -15,6 +15,8 @@ abstract class MigrateUpgradeTestBase extends BrowserTestBase {
 
   /**
    * Use the Standard profile to test help implementations of many core modules.
+   *
+   * @var string
    */
   protected $profile = 'standard';
 

core/modules/node/src/Plugin/views/wizard/Node.php

@@ -22,6 +22,8 @@ class Node extends WizardPluginBase {
 
   /**
    * Set the created column.
+   *
+   * @var string
    */
   protected $createdColumn = 'node_field_data-created';
 

core/modules/node/src/Plugin/views/wizard/NodeRevision.php

@@ -21,6 +21,8 @@ class NodeRevision extends WizardPluginBase {
 
   /**
    * Set the created column.
+   *
+   * @var string
    */
   protected $createdColumn = 'changed';
 

core/modules/search/src/Plugin/views/filter/Search.php

@@ -34,6 +34,8 @@ class Search extends FilterPluginBase {
 
   /**
    * TRUE if the search query has been parsed.
+   *
+   * @var bool
    */
   protected $parsed = FALSE;
 

core/modules/simpletest/src/TestBase.php

@@ -45,6 +45,8 @@ abstract class TestBase {
 
   /**
    * Time limit for the test.
+   *
+   * @var int
    */
   protected $timeLimit = 500;
 

core/modules/simpletest/src/Tests/InstallationProfileModuleTestsTest.php

@@ -36,6 +36,8 @@ class InstallationProfileModuleTestsTest extends WebTestBase {
    *   contained in the Testing profile.
    *
    * @see \Drupal\drupal_system_listing_compatible_test\Tests\SystemListingCompatibleTest
+   *
+   * @var string
    */
   protected $profile = 'testing';
 

core/modules/simpletest/src/WebTestBase.php

@@ -169,6 +169,8 @@ abstract class WebTestBase extends TestBase {
 
   /**
    * The maximum number of redirects to follow when handling responses.
+   *
+   * @var int
    */
   protected $maximumRedirects = 5;
 

core/modules/simpletest/tests/src/Functional/OtherInstallationProfileTestsTest.php

@@ -28,6 +28,8 @@ class OtherInstallationProfileTestsTest extends BrowserTestBase {
    * The Standard profile contains \Drupal\standard\Tests\StandardTest, which
    * should be found.
    *
+   * @var string
+   *
    * @see \Drupal\simpletest\Tests\InstallationProfileModuleTestsTest
    * @see \Drupal\drupal_system_listing_compatible_test\Tests\SystemListingCompatibleTest
    */

core/modules/system/tests/src/Functional/FileTransfer/TestFileTransfer.php

@@ -16,6 +16,8 @@ class TestFileTransfer extends FileTransfer {
 
   /**
    * This is for testing the CopyRecursive logic.
+   *
+   * @var bool
    */
   public $shouldIsDirectoryReturnTrue = FALSE;
 

core/modules/system/tests/src/Functional/Menu/BreadcrumbTest.php

@@ -39,6 +39,8 @@ class BreadcrumbTest extends BrowserTestBase {
 
   /**
    * Test paths in the Standard profile.
+   *
+   * @var string
    */
   protected $profile = 'standard';
 

core/modules/system/tests/src/Functional/Module/ClassLoaderTest.php

@@ -13,6 +13,8 @@ class ClassLoaderTest extends BrowserTestBase {
 
   /**
    * The expected result from calling the module-provided class' method.
+   *
+   * @var string
    */
   protected $expected = 'Drupal\\module_autoload_test\\SomeClass::testMethod() was invoked.';
 

core/modules/user/src/Plugin/views/wizard/Users.php

@@ -21,6 +21,8 @@ class Users extends WizardPluginBase {
 
   /**
    * Set the created column.
+   *
+   * @var string
    */
   protected $createdColumn = 'created';
 

core/modules/views/src/Plugin/views/field/FieldPluginBase.php

@@ -68,6 +68,9 @@ abstract class FieldPluginBase extends HandlerBase implements FieldHandlerInterf
    */
   const RENDER_TEXT_PHASE_EMPTY = 2;
 
+  /**
+   * @var string
+   */
   public $field_alias = 'unknown';
   public $aliases = [];
 

core/modules/views/src/Plugin/views/filter/FilterPluginBase.php

@@ -53,6 +53,8 @@ abstract class FilterPluginBase extends HandlerBase implements CacheableDependen
 
   /**
    * Contains the operator which is used on the query.
+   *
+   * @var string
    */
   public $operator = '=';
 

core/modules/views/src/Plugin/views/query/Sql.php

@@ -61,6 +61,8 @@ class Sql extends QueryPluginBase {
   /**
    * The default operator to use when connecting the WHERE groups. May be
    * AND or OR.
+   *
+   * @var string
    */
   protected $groupOperator = 'AND';
 
@@ -82,9 +84,14 @@ class Sql extends QueryPluginBase {
 
   /**
    * A flag as to whether or not to make the primary field distinct.
+   *
+   * @var bool
    */
   public $distinct = FALSE;
 
+  /**
+   * @var bool
+   */
   protected $hasAggregate = FALSE;
 
   /**

core/profiles/testing/modules/drupal_system_listing_compatible_test/src/Tests/SystemListingCompatibleTest.php

@@ -29,6 +29,8 @@ class SystemListingCompatibleTest extends WebTestBase {
    * asserts that this test is found.
    *
    * @see SimpleTestInstallationProfileModuleTestsTestCase
+   *
+   * @var string
    */
   protected $profile = 'minimal';