From 69167b5dc8f9730a02899a569258e809ea7e7ae5 Mon Sep 17 00:00:00 2001
From: Lee Rowlands <lee.rowlands@previousnext.com.au>
Date: Wed, 23 May 2018 09:50:56 +1000
Subject: [PATCH] Issue #2940679 by alena_stanul, borisson_, neclimdul: Fix
FilterIdTest test names
---
.../Kernel/Plugin/migrate/process/FilterIdTest.php | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/core/modules/filter/tests/src/Kernel/Plugin/migrate/process/FilterIdTest.php b/core/modules/filter/tests/src/Kernel/Plugin/migrate/process/FilterIdTest.php
index e18b3a904dd7..eb5f7eacab46 100644
--- a/core/modules/filter/tests/src/Kernel/Plugin/migrate/process/FilterIdTest.php
+++ b/core/modules/filter/tests/src/Kernel/Plugin/migrate/process/FilterIdTest.php
@@ -37,7 +37,7 @@ protected function setUp() {
}
/**
- * Tests the filter_id plugin.
+ * Tests transformation of filter_id plugin.
*
* @param mixed $value
* The input value to the plugin.
@@ -47,11 +47,11 @@ protected function setUp() {
* (optional) The invalid plugin ID which is expected to be logged by the
* MigrateExecutable object.
*
- * @dataProvider testProvider
+ * @dataProvider provideFilters
*
* @covers ::transform
*/
- public function test($value, $expected_value, $invalid_id = NULL) {
+ public function testTransform($value, $expected_value, $invalid_id = NULL) {
$configuration = [
'bypass' => TRUE,
'map' => [
@@ -78,11 +78,14 @@ public function test($value, $expected_value, $invalid_id = NULL) {
}
/**
- * The test data provider.
+ * Provides filter ids for testing transformations.
*
* @return array
+ * Formatted as $source_id, $tranformed_id, $invalid_id.
+ * When $invalid_id is provided the transformation should fail with the
+ * supplied id.
*/
- public function testProvider() {
+ public function provideFilters() {
return [
// The filter ID is mapped, and the plugin exists.
[
--
GitLab