From 67e4f74449cf17f4769e401debb6a7b1d9fefd63 Mon Sep 17 00:00:00 2001
From: Dries Buytaert <dries@buytaert.net>
Date: Wed, 6 Oct 2004 18:26:01 +0000
Subject: [PATCH] - Usability improvement: the 'recent posts' feature on the
user pages lead to a page with a confusing (wrong) title so I shuffled
things around a bit and tab-ified it as 'track'.
---
modules/tracker.module | 20 ++++++++++++++------
modules/tracker/tracker.module | 20 ++++++++++++++------
2 files changed, 28 insertions(+), 12 deletions(-)
diff --git a/modules/tracker.module b/modules/tracker.module
index 24951d50e7de..925c6b998638 100644
--- a/modules/tracker.module
+++ b/modules/tracker.module
@@ -37,10 +37,24 @@ function tracker_menu($may_cache) {
'type' => MENU_LOCAL_TASK);
}
}
+ else {
+ if (arg(0) == 'user' && is_numeric(arg(1))) {
+ $items[] = array('path' => 'user/'. arg(1) .'/track', 'title' => t('track posts'),
+ 'callback' => 'tracker_track_user', 'access' => user_access('access content'),
+ 'type' => MENU_LOCAL_TASK);
+ }
+ }
return $items;
}
+/**
+ * Menu callback. Prints a listing of active nodes on the site.
+ */
+function tracker_track_user() {
+ tracker_page(arg(1));
+}
+
/**
* Menu callback. Prints a listing of active nodes on the site.
*/
@@ -90,10 +104,4 @@ function tracker_page($uid = 0) {
print theme('page', $output);
}
-function tracker_user($type, &$edit, &$user) {
- if ($type == 'view' && user_access('access content')) {
- return array(t('History') => form_item(t('Recent posts'), l(t('recent posts'), "tracker/$user->uid")));
- }
-}
-
?>
diff --git a/modules/tracker/tracker.module b/modules/tracker/tracker.module
index 24951d50e7de..925c6b998638 100644
--- a/modules/tracker/tracker.module
+++ b/modules/tracker/tracker.module
@@ -37,10 +37,24 @@ function tracker_menu($may_cache) {
'type' => MENU_LOCAL_TASK);
}
}
+ else {
+ if (arg(0) == 'user' && is_numeric(arg(1))) {
+ $items[] = array('path' => 'user/'. arg(1) .'/track', 'title' => t('track posts'),
+ 'callback' => 'tracker_track_user', 'access' => user_access('access content'),
+ 'type' => MENU_LOCAL_TASK);
+ }
+ }
return $items;
}
+/**
+ * Menu callback. Prints a listing of active nodes on the site.
+ */
+function tracker_track_user() {
+ tracker_page(arg(1));
+}
+
/**
* Menu callback. Prints a listing of active nodes on the site.
*/
@@ -90,10 +104,4 @@ function tracker_page($uid = 0) {
print theme('page', $output);
}
-function tracker_user($type, &$edit, &$user) {
- if ($type == 'view' && user_access('access content')) {
- return array(t('History') => form_item(t('Recent posts'), l(t('recent posts'), "tracker/$user->uid")));
- }
-}
-
?>
--
GitLab