From 65dc722d8c495fa4eb61fc76196ae291bea84eb9 Mon Sep 17 00:00:00 2001
From: Daniel Wehner <daniel.wehner@erdfisch.de>
Date: Sat, 28 Jul 2012 18:36:21 -0500
Subject: [PATCH] Add abstract classes to all kind of plugins

---
 lib/Drupal/views/Plugins/views/access/AccessPluginBase.php    | 2 +-
 lib/Drupal/views/Plugins/views/area/AreaPluginBase.php        | 2 +-
 .../views/Plugins/views/argument/ArgumentPluginBase.php       | 2 +-
 .../views/argument_default/ArgumentDefaultPluginBase.php      | 2 +-
 .../views/argument_validator/ArgumentValidatorPluginBase.php  | 2 +-
 lib/Drupal/views/Plugins/views/cache/CachePluginBase.php      | 2 +-
 lib/Drupal/views/Plugins/views/display/DisplayPluginBase.php  | 2 +-
 .../Plugins/views/exposed_form/ExposedFormPluginBase.php      | 2 +-
 lib/Drupal/views/Plugins/views/field/FieldPluginBase.php      | 2 +-
 lib/Drupal/views/Plugins/views/filter/FilterPluginBase.php    | 2 +-
 .../Plugins/views/localization/LocalizationPluginBase.php     | 2 +-
 lib/Drupal/views/Plugins/views/pager/PagerPluginBase.php      | 2 +-
 .../Plugins/views/relationship/RelationshipPluginBase.php     | 2 +-
 lib/Drupal/views/Plugins/views/row/RowPluginBase.php          | 2 +-
 lib/Drupal/views/Plugins/views/sort/SortPluginBase.php        | 2 +-
 lib/Drupal/views/Plugins/views/style/StylePluginBase.php      | 2 +-
 lib/Drupal/views/Plugins/views/wizard/Comment.php             | 2 +-
 lib/Drupal/views/Plugins/views/wizard/File.php                | 4 ++--
 lib/Drupal/views/Plugins/views/wizard/Node.php                | 4 ++--
 lib/Drupal/views/Plugins/views/wizard/NodeRevision.php        | 4 ++--
 lib/Drupal/views/Plugins/views/wizard/TaxonomyTerm.php        | 4 ++--
 lib/Drupal/views/Plugins/views/wizard/Users.php               | 4 ++--
 .../views/wizard/{WizardBase.php => WizardPluginBase.php}     | 2 +-
 23 files changed, 28 insertions(+), 28 deletions(-)
 rename lib/Drupal/views/Plugins/views/wizard/{WizardBase.php => WizardPluginBase.php} (99%)

diff --git a/lib/Drupal/views/Plugins/views/access/AccessPluginBase.php b/lib/Drupal/views/Plugins/views/access/AccessPluginBase.php
index cb48c11468fe..17a05522388b 100644
--- a/lib/Drupal/views/Plugins/views/access/AccessPluginBase.php
+++ b/lib/Drupal/views/Plugins/views/access/AccessPluginBase.php
@@ -20,7 +20,7 @@
 /**
  * The base plugin to handle access control.
  */
-class AccessPluginBase extends Plugin {
+abstract class AccessPluginBase extends Plugin {
   /**
    * Initialize the plugin.
    *
diff --git a/lib/Drupal/views/Plugins/views/area/AreaPluginBase.php b/lib/Drupal/views/Plugins/views/area/AreaPluginBase.php
index 044fc5e9df4a..970a57423736 100644
--- a/lib/Drupal/views/Plugins/views/area/AreaPluginBase.php
+++ b/lib/Drupal/views/Plugins/views/area/AreaPluginBase.php
@@ -22,7 +22,7 @@
  *
  * @ingroup views_area_handlers
  */
-class AreaPluginBase extends Handler {
+abstract class AreaPluginBase extends Handler {
   /**
    * Get this field's label.
    */
diff --git a/lib/Drupal/views/Plugins/views/argument/ArgumentPluginBase.php b/lib/Drupal/views/Plugins/views/argument/ArgumentPluginBase.php
index 318197541727..92d004171996 100644
--- a/lib/Drupal/views/Plugins/views/argument/ArgumentPluginBase.php
+++ b/lib/Drupal/views/Plugins/views/argument/ArgumentPluginBase.php
@@ -40,7 +40,7 @@
  *
  * @ingroup views_argument_handlers
  */
-class ArgumentPluginBase extends Handler {
+abstract class ArgumentPluginBase extends Handler {
 
   var $validator = NULL;
   var $argument = NULL;
diff --git a/lib/Drupal/views/Plugins/views/argument_default/ArgumentDefaultPluginBase.php b/lib/Drupal/views/Plugins/views/argument_default/ArgumentDefaultPluginBase.php
index 79a17beb3de6..2d8c781dd39d 100644
--- a/lib/Drupal/views/Plugins/views/argument_default/ArgumentDefaultPluginBase.php
+++ b/lib/Drupal/views/Plugins/views/argument_default/ArgumentDefaultPluginBase.php
@@ -20,7 +20,7 @@
 /**
  * The fixed argument default handler; also used as the base.
  */
-class ArgumentDefaultPluginBase extends Plugin {
+abstract class ArgumentDefaultPluginBase extends Plugin {
   /**
    * Return the default argument.
    *
diff --git a/lib/Drupal/views/Plugins/views/argument_validator/ArgumentValidatorPluginBase.php b/lib/Drupal/views/Plugins/views/argument_validator/ArgumentValidatorPluginBase.php
index 8bd680ee9578..d991f2d9d104 100644
--- a/lib/Drupal/views/Plugins/views/argument_validator/ArgumentValidatorPluginBase.php
+++ b/lib/Drupal/views/Plugins/views/argument_validator/ArgumentValidatorPluginBase.php
@@ -20,7 +20,7 @@
 /**
  * Base argument validator plugin to provide basic functionality.
  */
-class ArgumentValidatorPluginBase extends Plugin {
+abstract class ArgumentValidatorPluginBase extends Plugin {
 
   /**
    * Initialize this plugin with the view and the argument
diff --git a/lib/Drupal/views/Plugins/views/cache/CachePluginBase.php b/lib/Drupal/views/Plugins/views/cache/CachePluginBase.php
index d5278f204d24..5ced8b4acb93 100644
--- a/lib/Drupal/views/Plugins/views/cache/CachePluginBase.php
+++ b/lib/Drupal/views/Plugins/views/cache/CachePluginBase.php
@@ -20,7 +20,7 @@
 /**
  * The base plugin to handle caching.
  */
-class CachePluginBase extends Plugin {
+abstract class CachePluginBase extends Plugin {
   /**
    * Contains all data that should be written/read from cache.
    */
diff --git a/lib/Drupal/views/Plugins/views/display/DisplayPluginBase.php b/lib/Drupal/views/Plugins/views/display/DisplayPluginBase.php
index cca15942879a..17850f715b90 100644
--- a/lib/Drupal/views/Plugins/views/display/DisplayPluginBase.php
+++ b/lib/Drupal/views/Plugins/views/display/DisplayPluginBase.php
@@ -28,7 +28,7 @@
  * The default display plugin handler. Display plugins handle options and
  * basic mechanisms for different output methods.
  */
-class DisplayPluginBase extends Plugin {
+abstract class DisplayPluginBase extends Plugin {
   /**
    * The top object of a view.
    *
diff --git a/lib/Drupal/views/Plugins/views/exposed_form/ExposedFormPluginBase.php b/lib/Drupal/views/Plugins/views/exposed_form/ExposedFormPluginBase.php
index e9ef1a297958..ccbb0bca052c 100644
--- a/lib/Drupal/views/Plugins/views/exposed_form/ExposedFormPluginBase.php
+++ b/lib/Drupal/views/Plugins/views/exposed_form/ExposedFormPluginBase.php
@@ -22,7 +22,7 @@
 /**
  * The base plugin to handle exposed filter forms.
  */
-class ExposedFormPluginBase extends Plugin {
+abstract class ExposedFormPluginBase extends Plugin {
 
   /**
    * Initialize the plugin.
diff --git a/lib/Drupal/views/Plugins/views/field/FieldPluginBase.php b/lib/Drupal/views/Plugins/views/field/FieldPluginBase.php
index 1b51b1faf4a0..d8be38336aa7 100644
--- a/lib/Drupal/views/Plugins/views/field/FieldPluginBase.php
+++ b/lib/Drupal/views/Plugins/views/field/FieldPluginBase.php
@@ -53,7 +53,7 @@
  *   plugin_id = "standard"
  * )
  */
-class FieldPluginBase extends Handler {
+abstract class FieldPluginBase extends Handler {
 
   var $field_alias = 'unknown';
   var $aliases = array();
diff --git a/lib/Drupal/views/Plugins/views/filter/FilterPluginBase.php b/lib/Drupal/views/Plugins/views/filter/FilterPluginBase.php
index 180897465f26..cc18be93c07c 100644
--- a/lib/Drupal/views/Plugins/views/filter/FilterPluginBase.php
+++ b/lib/Drupal/views/Plugins/views/filter/FilterPluginBase.php
@@ -42,7 +42,7 @@
  *   plugin_id = "standard"
  * )
  */
-class FilterPluginBase extends Handler {
+abstract class FilterPluginBase extends Handler {
   /**
    * Contains the actual value of the field,either configured in the views ui
    * or entered in the exposed filters.
diff --git a/lib/Drupal/views/Plugins/views/localization/LocalizationPluginBase.php b/lib/Drupal/views/Plugins/views/localization/LocalizationPluginBase.php
index f920ec880257..bc6cd1913a68 100644
--- a/lib/Drupal/views/Plugins/views/localization/LocalizationPluginBase.php
+++ b/lib/Drupal/views/Plugins/views/localization/LocalizationPluginBase.php
@@ -20,7 +20,7 @@
 /**
  * The base plugin to handle localization of Views strings.
  */
-class LocalizationPluginBase extends Plugin {
+abstract class LocalizationPluginBase extends Plugin {
   // Store for exported strings
   var $export_strings = array();
   var $translate = TRUE;
diff --git a/lib/Drupal/views/Plugins/views/pager/PagerPluginBase.php b/lib/Drupal/views/Plugins/views/pager/PagerPluginBase.php
index c38723cb432c..0b5823c99565 100644
--- a/lib/Drupal/views/Plugins/views/pager/PagerPluginBase.php
+++ b/lib/Drupal/views/Plugins/views/pager/PagerPluginBase.php
@@ -20,7 +20,7 @@
 /**
  * The base plugin to handle pager.
  */
-class PagerPluginBase extends Plugin {
+abstract class PagerPluginBase extends Plugin {
   var $current_page = NULL;
   var $total_items = 0;
 
diff --git a/lib/Drupal/views/Plugins/views/relationship/RelationshipPluginBase.php b/lib/Drupal/views/Plugins/views/relationship/RelationshipPluginBase.php
index 34132c430ec1..771e6f2ba32d 100644
--- a/lib/Drupal/views/Plugins/views/relationship/RelationshipPluginBase.php
+++ b/lib/Drupal/views/Plugins/views/relationship/RelationshipPluginBase.php
@@ -47,7 +47,7 @@
  *   plugin_id = "standard"
  * )
  */
-class RelationshipPluginBase extends Handler {
+abstract class RelationshipPluginBase extends Handler {
   /**
    * Init handler to let relationships live on tables other than
    * the table they operate on.
diff --git a/lib/Drupal/views/Plugins/views/row/RowPluginBase.php b/lib/Drupal/views/Plugins/views/row/RowPluginBase.php
index 61c4c539554a..4b082b610611 100644
--- a/lib/Drupal/views/Plugins/views/row/RowPluginBase.php
+++ b/lib/Drupal/views/Plugins/views/row/RowPluginBase.php
@@ -24,7 +24,7 @@
  * Default plugin to view a single row of a table. This is really just a wrapper around
  * a theme function.
  */
-class RowPluginBase extends Plugin {
+abstract class RowPluginBase extends Plugin {
   /**
    * Initialize the row plugin.
    */
diff --git a/lib/Drupal/views/Plugins/views/sort/SortPluginBase.php b/lib/Drupal/views/Plugins/views/sort/SortPluginBase.php
index da5221e74b8b..04f4c401f6e4 100644
--- a/lib/Drupal/views/Plugins/views/sort/SortPluginBase.php
+++ b/lib/Drupal/views/Plugins/views/sort/SortPluginBase.php
@@ -28,7 +28,7 @@
  *   plugin_id = "standard"
  * )
  */
-class SortPluginBase extends Handler {
+abstract class SortPluginBase extends Handler {
 
   /**
    * Determine if a sort can be exposed.
diff --git a/lib/Drupal/views/Plugins/views/style/StylePluginBase.php b/lib/Drupal/views/Plugins/views/style/StylePluginBase.php
index 5779e3c989e3..be736b7e964b 100644
--- a/lib/Drupal/views/Plugins/views/style/StylePluginBase.php
+++ b/lib/Drupal/views/Plugins/views/style/StylePluginBase.php
@@ -28,7 +28,7 @@
 /**
  * Base class to define a style plugin handler.
  */
-class StylePluginBase extends ViewsPlugin {
+abstract class StylePluginBase extends ViewsPlugin {
   /**
    * Store all available tokens row rows.
    */
diff --git a/lib/Drupal/views/Plugins/views/wizard/Comment.php b/lib/Drupal/views/Plugins/views/wizard/Comment.php
index 8b5abb0433f7..5f4fee2faf6c 100644
--- a/lib/Drupal/views/Plugins/views/wizard/Comment.php
+++ b/lib/Drupal/views/Plugins/views/wizard/Comment.php
@@ -49,7 +49,7 @@
  *   }
  * )
  */
-class Comment extends WizardBase {
+class Comment extends WizardPluginBase {
 
   protected function row_style_options($type) {
     $options = array();
diff --git a/lib/Drupal/views/Plugins/views/wizard/File.php b/lib/Drupal/views/Plugins/views/wizard/File.php
index c6d420192784..976c1c634805 100644
--- a/lib/Drupal/views/Plugins/views/wizard/File.php
+++ b/lib/Drupal/views/Plugins/views/wizard/File.php
@@ -7,7 +7,7 @@
 
 namespace Drupal\views\Plugins\views\wizard;
 
-use Drupal\views\Plugins\views\wizard\WizardBase;
+use Drupal\views\Plugins\views\wizard\WizardPluginBase;
 use Drupal\Core\Annotation\Plugin;
 use Drupal\Core\Annotation\Translation;
 
@@ -28,7 +28,7 @@
  *   }
  * )
  */
-class File extends WizardBase {
+class File extends WizardPluginBase {
   protected function default_display_options($form, $form_state) {
     $display_options = parent::default_display_options($form, $form_state);
 
diff --git a/lib/Drupal/views/Plugins/views/wizard/Node.php b/lib/Drupal/views/Plugins/views/wizard/Node.php
index 532adf4a69e5..29e943a49531 100644
--- a/lib/Drupal/views/Plugins/views/wizard/Node.php
+++ b/lib/Drupal/views/Plugins/views/wizard/Node.php
@@ -7,7 +7,7 @@
 
 namespace Drupal\views\Plugins\views\wizard;
 
-use Drupal\views\Plugins\views\wizard\WizardBase;
+use Drupal\views\Plugins\views\wizard\WizardPluginBase;
 use Drupal\Core\Annotation\Plugin;
 use Drupal\Core\Annotation\Translation;
 
@@ -48,7 +48,7 @@
  *
  */
 
-class Node extends WizardBase {
+class Node extends WizardPluginBase {
 
   protected function row_style_options($type) {
     $options = array();
diff --git a/lib/Drupal/views/Plugins/views/wizard/NodeRevision.php b/lib/Drupal/views/Plugins/views/wizard/NodeRevision.php
index 2fcec62dff24..d288864c2505 100644
--- a/lib/Drupal/views/Plugins/views/wizard/NodeRevision.php
+++ b/lib/Drupal/views/Plugins/views/wizard/NodeRevision.php
@@ -7,7 +7,7 @@
 
 namespace Drupal\views\Plugins\views\wizard;
 
-use Drupal\views\Plugins\views\wizard\WizardBase;
+use Drupal\views\Plugins\views\wizard\WizardPluginBase;
 use Drupal\Core\Annotation\Plugin;
 use Drupal\Core\Annotation\Translation;
 
@@ -49,7 +49,7 @@
  *   }
  * )
  */
-class NodeRevision extends WizardBase {
+class NodeRevision extends WizardPluginBase {
 
   /**
    * Node revisions do not support full posts or teasers, so remove them.
diff --git a/lib/Drupal/views/Plugins/views/wizard/TaxonomyTerm.php b/lib/Drupal/views/Plugins/views/wizard/TaxonomyTerm.php
index 629df9ed625f..78c98a65b33f 100644
--- a/lib/Drupal/views/Plugins/views/wizard/TaxonomyTerm.php
+++ b/lib/Drupal/views/Plugins/views/wizard/TaxonomyTerm.php
@@ -7,7 +7,7 @@
 
 namespace Drupal\views\Plugins\views\wizard;
 
-use Drupal\views\Plugins\views\wizard\WizardBase;
+use Drupal\views\Plugins\views\wizard\WizardPluginBase;
 use Drupal\Core\Annotation\Plugin;
 use Drupal\Core\Annotation\Translation;
 
@@ -32,7 +32,7 @@
  *   }
  * )
  */
-class TaxonomyTerm extends WizardBase {
+class TaxonomyTerm extends WizardPluginBase {
 
   protected function default_display_options($form, $form_state) {
     $display_options = parent::default_display_options($form, $form_state);
diff --git a/lib/Drupal/views/Plugins/views/wizard/Users.php b/lib/Drupal/views/Plugins/views/wizard/Users.php
index e55b48602836..47236c534533 100644
--- a/lib/Drupal/views/Plugins/views/wizard/Users.php
+++ b/lib/Drupal/views/Plugins/views/wizard/Users.php
@@ -7,7 +7,7 @@
 
 namespace Drupal\views\Plugins\views\wizard;
 
-use Drupal\views\Plugins\views\wizard\WizardBase;
+use Drupal\views\Plugins\views\wizard\WizardPluginBase;
 use Drupal\Core\Annotation\Plugin;
 use Drupal\Core\Annotation\Translation;
 
@@ -43,7 +43,7 @@
  *   }
  * )
  */
-class Users extends WizardBase {
+class Users extends WizardPluginBase {
   protected function default_display_options($form, $form_state) {
     $display_options = parent::default_display_options($form, $form_state);
 
diff --git a/lib/Drupal/views/Plugins/views/wizard/WizardBase.php b/lib/Drupal/views/Plugins/views/wizard/WizardPluginBase.php
similarity index 99%
rename from lib/Drupal/views/Plugins/views/wizard/WizardBase.php
rename to lib/Drupal/views/Plugins/views/wizard/WizardPluginBase.php
index c7a7eaf86991..c1af643c32da 100644
--- a/lib/Drupal/views/Plugins/views/wizard/WizardBase.php
+++ b/lib/Drupal/views/Plugins/views/wizard/WizardPluginBase.php
@@ -13,7 +13,7 @@
 /**
  * A very generic Views Wizard class - can be constructed for any base table.
  */
-class WizardBase implements WizardInterface {
+abstract class WizardPluginBase implements WizardInterface {
   protected $base_table;
   protected $entity_type;
   protected $entity_info = array();
-- 
GitLab