Issue #1985386 by yched, Gábor Hojtsy: Crufty...

Issue #1985386 by yched, Gábor Hojtsy: Crufty 'allowed_values_function_display()' ends up in list field stored config.

core/modules/options/config/schema/options.schema.yml

@@ -13,9 +13,6 @@ field.list_integer.settings:
     allowed_values_function:
       type: string
       label: 'Allowed values function'
-    allowed_values_function_display:
-      type: string
-      label: 'Allowed values function display'
 
 field.list_integer.instance_settings:
   type: mapping
@@ -49,9 +46,6 @@ field.list_float.settings:
     allowed_values_function:
       type: string
       label: 'Allowed values function'
-    allowed_values_function_display:
-      type: string
-      label: 'Allowed values function display'
 
 field.list_float.instance_settings:
   type: mapping
@@ -85,9 +79,6 @@ field.list_text.settings:
     allowed_values_function:
       type: string
       label: 'Allowed values function'
-    allowed_values_function_display:
-      type: string
-      label: 'Allowed values function display'
 
 field.list_text.instance_settings:
   type: mapping
@@ -121,9 +112,6 @@ field.list_boolean.settings:
     allowed_values_function:
       type: string
       label: 'Allowed values function'
-    allowed_values_function_display:
-      type: string
-      label: 'Allowed values function display'
 
 field.list_boolean.instance_settings:
   type: mapping

core/modules/options/options.module

@@ -150,14 +150,11 @@ function options_field_settings_form($field, $instance, $has_data) {
   $form['allowed_values']['#description'] .= '<p>' . t('Allowed HTML tags in labels: @tags', array('@tags' => _field_filter_xss_display_allowed_tags())) . '</p>';
 
   $form['allowed_values_function'] = array(
-    '#type' => 'value',
-    '#value' => $settings['allowed_values_function'],
-  );
-  $form['allowed_values_function_display'] = array(
     '#type' => 'item',
     '#title' => t('Allowed values list'),
     '#markup' => t('The value of this field is being determined by the %function function and may not be changed.', array('%function' => $settings['allowed_values_function'])),
     '#access' => !empty($settings['allowed_values_function']),
+    '#value' => $settings['allowed_values_function'],
   );
 
   return $form;