diff --git a/core/.phpstan-baseline.php b/core/.phpstan-baseline.php
index 5e76e8752801290900b0e6c1424aee8116d21ae7..9b06d711a992cecc3fd932914b7ec3cc8d7d8051 100644
--- a/core/.phpstan-baseline.php
+++ b/core/.phpstan-baseline.php
@@ -26611,12 +26611,6 @@
'count' => 1,
'path' => __DIR__ . '/modules/media/tests/src/Kernel/MediaThumbnailFormatterTest.php',
];
-$ignoreErrors[] = [
- 'message' => '#^Method class@anonymous/core/modules/media/tests/src/Kernel/OEmbedResourceConstraintValidatorTest\\.php\\:108\\:\\:getEntity\\(\\) has no return type specified\\.$#',
- 'identifier' => 'missingType.return',
- 'count' => 1,
- 'path' => __DIR__ . '/modules/media/tests/src/Kernel/OEmbedResourceConstraintValidatorTest.php',
-];
$ignoreErrors[] = [
'message' => '#^Method Drupal\\\\Tests\\\\media\\\\Unit\\\\ResourceTest\\:\\:setDimensionsTestCases\\(\\) has no return type specified\\.$#',
'identifier' => 'missingType.return',
diff --git a/core/modules/block/tests/src/Functional/BlockUiTest.php b/core/modules/block/tests/src/Functional/BlockUiTest.php
index 76bc4f86f91c4af7eeb6bbfcf4270c1b26ddabde..647eadc165a5c206968cf41c621b32696a2af36e 100644
--- a/core/modules/block/tests/src/Functional/BlockUiTest.php
+++ b/core/modules/block/tests/src/Functional/BlockUiTest.php
@@ -34,6 +34,8 @@ class BlockUiTest extends BrowserTestBase {
*/
protected $defaultTheme = 'stark';
+ protected $regions;
+
/**
* The submitted block values used by this test.
*
diff --git a/core/modules/block/tests/src/Kernel/ConfigActionsTest.php b/core/modules/block/tests/src/Kernel/ConfigActionsTest.php
index b12ee0edc94094a0eee8920d87beded1fe9d673e..fd7fa6f34c92bff28baaeb629de8f1bcfad57bfa 100644
--- a/core/modules/block/tests/src/Kernel/ConfigActionsTest.php
+++ b/core/modules/block/tests/src/Kernel/ConfigActionsTest.php
@@ -27,6 +27,9 @@ class ConfigActionsTest extends KernelTestBase {
*/
protected static $modules = ['block', 'system', 'user'];
+ /**
+ * The configuration action manager.
+ */
private readonly ConfigActionManager $configActionManager;
/**
diff --git a/core/modules/comment/tests/src/Functional/CommentEntityTest.php b/core/modules/comment/tests/src/Functional/CommentEntityTest.php
index 7d07b90472c902ab791b578ba4ade304544ca93b..c680ebc42e67f9f898f142389e75444566963e62 100644
--- a/core/modules/comment/tests/src/Functional/CommentEntityTest.php
+++ b/core/modules/comment/tests/src/Functional/CommentEntityTest.php
@@ -38,7 +38,14 @@ class CommentEntityTest extends CommentTestBase {
*/
protected $defaultTheme = 'stark';
+ /**
+ * A vocabulary used for testing.
+ */
protected $vocab;
+
+ /**
+ * The comment type used for testing.
+ */
protected $commentType;
/**
diff --git a/core/modules/contact/tests/src/Kernel/ConfigActionsTest.php b/core/modules/contact/tests/src/Kernel/ConfigActionsTest.php
index a9a2eaada66baece899125dfd66ed83b3b3d374d..31210efca43544f8ce1dc04970d84a3a18c79387 100644
--- a/core/modules/contact/tests/src/Kernel/ConfigActionsTest.php
+++ b/core/modules/contact/tests/src/Kernel/ConfigActionsTest.php
@@ -18,6 +18,11 @@ class ConfigActionsTest extends KernelTestBase {
*/
protected static $modules = ['contact', 'system', 'user'];
+ /**
+ * The configuration action manager.
+ *
+ * @var \Drupal\Core\Config\Action\ConfigActionManager
+ */
private readonly ConfigActionManager $configActionManager;
/**
diff --git a/core/modules/field/tests/src/Kernel/ConfigActionsTest.php b/core/modules/field/tests/src/Kernel/ConfigActionsTest.php
index 62086177ea9c902fe85008177baca21162426936..15dc362a8be57b4a74790e636304b4228449b061 100644
--- a/core/modules/field/tests/src/Kernel/ConfigActionsTest.php
+++ b/core/modules/field/tests/src/Kernel/ConfigActionsTest.php
@@ -20,6 +20,9 @@ class ConfigActionsTest extends KernelTestBase {
*/
protected static $modules = ['entity_test', 'field', 'user'];
+ /**
+ * The configuration manager.
+ */
private readonly ConfigActionManager $configActionManager;
/**
diff --git a/core/modules/file/tests/src/Unit/Plugin/migrate/process/d6/FileUriTest.php b/core/modules/file/tests/src/Unit/Plugin/migrate/process/d6/FileUriTest.php
index 157633388831322911522356efc0f4647e978086..1118e0aae68eae12c2af186ad4c3ab73dde3fad9 100644
--- a/core/modules/file/tests/src/Unit/Plugin/migrate/process/d6/FileUriTest.php
+++ b/core/modules/file/tests/src/Unit/Plugin/migrate/process/d6/FileUriTest.php
@@ -15,6 +15,9 @@
*/
class FileUriTest extends MigrateTestCase {
+ /**
+ * The plugin configuration.
+ */
protected $migrationConfiguration = [
'id' => 'test',
];
diff --git a/core/modules/image/tests/src/Kernel/ConfigActionsTest.php b/core/modules/image/tests/src/Kernel/ConfigActionsTest.php
index e8391499c471ea93ecb8f642d154be21259fc904..1334d832f61ae6e4c322c7b838e3e91d88f9059a 100644
--- a/core/modules/image/tests/src/Kernel/ConfigActionsTest.php
+++ b/core/modules/image/tests/src/Kernel/ConfigActionsTest.php
@@ -18,6 +18,9 @@ class ConfigActionsTest extends KernelTestBase {
*/
protected static $modules = ['image', 'system'];
+ /**
+ * The configuration action manager.
+ */
private readonly ConfigActionManager $configActionManager;
/**
diff --git a/core/modules/jsonapi/tests/modules/jsonapi_test_data_type/src/TraversableObject.php b/core/modules/jsonapi/tests/modules/jsonapi_test_data_type/src/TraversableObject.php
index 63058f1620fbfdab93eebb004a189630ceae28e7..c5c10cb830471793037ff2d824aeea78d1513f53 100644
--- a/core/modules/jsonapi/tests/modules/jsonapi_test_data_type/src/TraversableObject.php
+++ b/core/modules/jsonapi/tests/modules/jsonapi_test_data_type/src/TraversableObject.php
@@ -9,6 +9,9 @@
*/
class TraversableObject implements \IteratorAggregate {
+ /**
+ * The test data.
+ */
public $property = "value";
/**
diff --git a/core/modules/language/tests/src/Kernel/ConfigActionsTest.php b/core/modules/language/tests/src/Kernel/ConfigActionsTest.php
index 537678199bf15326149b7a2cfc7184ade51ac4d7..0b159f7463865d91e4d37c3f0dc82f7d126f47f4 100644
--- a/core/modules/language/tests/src/Kernel/ConfigActionsTest.php
+++ b/core/modules/language/tests/src/Kernel/ConfigActionsTest.php
@@ -18,6 +18,9 @@ class ConfigActionsTest extends KernelTestBase {
*/
protected static $modules = ['language'];
+ /**
+ * The configuration action manager.
+ */
private readonly ConfigActionManager $configActionManager;
/**
diff --git a/core/modules/language/tests/src/Unit/LanguageNegotiationUrlTest.php b/core/modules/language/tests/src/Unit/LanguageNegotiationUrlTest.php
index c08b0b970570d8372c373fa68164a05e5db6b187..a79c9136248a6217d3f522682337cc84ab8855a6 100644
--- a/core/modules/language/tests/src/Unit/LanguageNegotiationUrlTest.php
+++ b/core/modules/language/tests/src/Unit/LanguageNegotiationUrlTest.php
@@ -18,8 +18,19 @@
*/
class LanguageNegotiationUrlTest extends UnitTestCase {
+ /**
+ * The language manager.
+ */
protected $languageManager;
+
+ /**
+ * The test user.
+ */
protected $user;
+
+ /**
+ * An array of languages.
+ */
protected array $languages;
/**
diff --git a/core/modules/locale/tests/src/Functional/LocaleUpdateCronTest.php b/core/modules/locale/tests/src/Functional/LocaleUpdateCronTest.php
index f0ab40d31cb074d59e20cb2efafcf936043c02b4..7d0706157b4599ca3e02b73178cc47f80d5d01c9 100644
--- a/core/modules/locale/tests/src/Functional/LocaleUpdateCronTest.php
+++ b/core/modules/locale/tests/src/Functional/LocaleUpdateCronTest.php
@@ -16,6 +16,7 @@
class LocaleUpdateCronTest extends LocaleUpdateBase {
use CronRunTrait;
+ protected $batchOutput = [];
/**
* {@inheritdoc}
diff --git a/core/modules/media/tests/src/Kernel/ConfigActionsTest.php b/core/modules/media/tests/src/Kernel/ConfigActionsTest.php
index 9ec9d21495ce54a28e3fa01c0e109030fb14ec7f..98e765c689a2d131a8a59d70e11e845fd3590dab 100644
--- a/core/modules/media/tests/src/Kernel/ConfigActionsTest.php
+++ b/core/modules/media/tests/src/Kernel/ConfigActionsTest.php
@@ -19,6 +19,9 @@ class ConfigActionsTest extends KernelTestBase {
*/
protected static $modules = ['media'];
+ /**
+ * The configuration action manager.
+ */
private readonly ConfigActionManager $configActionManager;
/**
diff --git a/core/modules/media/tests/src/Kernel/OEmbedResourceConstraintValidatorTest.php b/core/modules/media/tests/src/Kernel/OEmbedResourceConstraintValidatorTest.php
index 58d27445a1d8e9ba89959794563313ce92fa7f3b..c3d9c9d3c2e8ec5b69d5ece37d9bb2ee58054e46 100644
--- a/core/modules/media/tests/src/Kernel/OEmbedResourceConstraintValidatorTest.php
+++ b/core/modules/media/tests/src/Kernel/OEmbedResourceConstraintValidatorTest.php
@@ -107,13 +107,16 @@ public function testValidateUrlResolverInvoked(): void {
protected function getValue(Media $media) {
return new class ($media) {
+ /**
+ * The test entity.
+ */
private $entity;
public function __construct($entity) {
$this->entity = $entity;
}
- public function getEntity() {
+ public function getEntity(): Media {
return $this->entity;
}
diff --git a/core/modules/migrate/tests/src/Unit/Plugin/migrate/destination/EntityContentBaseTest.php b/core/modules/migrate/tests/src/Unit/Plugin/migrate/destination/EntityContentBaseTest.php
index bb1368a1344fef45f9da1dfb0328c17c9af17028..791e0fd8592af1ce1d20ffb507743e3bad53292f 100644
--- a/core/modules/migrate/tests/src/Unit/Plugin/migrate/destination/EntityContentBaseTest.php
+++ b/core/modules/migrate/tests/src/Unit/Plugin/migrate/destination/EntityContentBaseTest.php
@@ -111,6 +111,9 @@ public function testUntranslatable(): void {
*/
class EntityTestDestination extends EntityContentBase {
+ /**
+ * The test entity.
+ */
private $entity = NULL;
public function setEntity($entity): void {
diff --git a/core/modules/migrate/tests/src/Unit/Plugin/migrate/destination/EntityRevisionTest.php b/core/modules/migrate/tests/src/Unit/Plugin/migrate/destination/EntityRevisionTest.php
index ddb4871f2d2811dccaa7ea963b2e97542f718f83..b15951e376b7b1f4f7d9b203f0f605d17e8892da 100644
--- a/core/modules/migrate/tests/src/Unit/Plugin/migrate/destination/EntityRevisionTest.php
+++ b/core/modules/migrate/tests/src/Unit/Plugin/migrate/destination/EntityRevisionTest.php
@@ -100,6 +100,9 @@ public function testUntranslatable(): void {
*/
class EntityRevisionTestDestination extends EntityRevision {
+ /**
+ * The test entity.
+ */
private $entity = NULL;
public function setEntity($entity): void {
diff --git a/core/modules/migrate/tests/src/Unit/destination/PerComponentEntityDisplayTest.php b/core/modules/migrate/tests/src/Unit/destination/PerComponentEntityDisplayTest.php
index db25c5c5d738d950a0a9bcfad6341b338295ae2b..bcb16444814ff097566e969a7f89ee3e1b8043b9 100644
--- a/core/modules/migrate/tests/src/Unit/destination/PerComponentEntityDisplayTest.php
+++ b/core/modules/migrate/tests/src/Unit/destination/PerComponentEntityDisplayTest.php
@@ -49,7 +49,15 @@ public function testImport(): void {
class TestPerComponentEntityDisplay extends ComponentEntityDisplayBase {
const MODE_NAME = 'view_mode';
+
+ /**
+ * The arguments of getEntity.
+ */
protected $testValues;
+
+ /**
+ * The test entity.
+ */
protected $entity;
public function __construct($entity) {
diff --git a/core/modules/migrate/tests/src/Unit/destination/PerComponentEntityFormDisplayTest.php b/core/modules/migrate/tests/src/Unit/destination/PerComponentEntityFormDisplayTest.php
index 9ccf8ea8c582a2745caa97d876353bfd35f51504..2c76b29b9cf18a6ed3d216157ac00fc09bbffdb1 100644
--- a/core/modules/migrate/tests/src/Unit/destination/PerComponentEntityFormDisplayTest.php
+++ b/core/modules/migrate/tests/src/Unit/destination/PerComponentEntityFormDisplayTest.php
@@ -49,7 +49,15 @@ public function testImport(): void {
class TestPerComponentEntityFormDisplay extends PerComponentEntityFormDisplay {
const MODE_NAME = 'form_mode';
+
+ /**
+ * The test values.
+ */
protected $testValues;
+
+ /**
+ * The test entity.
+ */
protected $entity;
public function __construct($entity) {
diff --git a/core/modules/mysql/tests/src/Unit/InstallTasksTest.php b/core/modules/mysql/tests/src/Unit/InstallTasksTest.php
index cd5447eee399453fbb65057265e734d2da713f29..7fcdb5273087fc3cca2bd9d2d4b74165a4857b78 100644
--- a/core/modules/mysql/tests/src/Unit/InstallTasksTest.php
+++ b/core/modules/mysql/tests/src/Unit/InstallTasksTest.php
@@ -43,6 +43,9 @@ private function createTasks(): Tasks {
return new class($connection) extends Tasks {
+ /**
+ * The database connection.
+ */
private $connection;
public function __construct(Connection $connection) {
diff --git a/core/modules/node/tests/src/Kernel/ConfigActionsTest.php b/core/modules/node/tests/src/Kernel/ConfigActionsTest.php
index 97fea6cf281c1b53851fe148382920297ec83f0a..9a682cbe0d740431f9d9e8a6db4432e045a778a2 100644
--- a/core/modules/node/tests/src/Kernel/ConfigActionsTest.php
+++ b/core/modules/node/tests/src/Kernel/ConfigActionsTest.php
@@ -21,6 +21,9 @@ class ConfigActionsTest extends KernelTestBase {
*/
protected static $modules = ['field', 'node', 'system', 'text', 'user'];
+ /**
+ * The configuration action manager.
+ */
private readonly ConfigActionManager $configActionManager;
/**
diff --git a/core/modules/package_manager/tests/modules/fixture_manipulator/src/FixtureManipulator.php b/core/modules/package_manager/tests/modules/fixture_manipulator/src/FixtureManipulator.php
index eac4ed0c50a8f2b186434ad7664b48d0f8330c7f..7d5dc8a85113795272eb3299e283059ea5dda3eb 100644
--- a/core/modules/package_manager/tests/modules/fixture_manipulator/src/FixtureManipulator.php
+++ b/core/modules/package_manager/tests/modules/fixture_manipulator/src/FixtureManipulator.php
@@ -442,9 +442,16 @@ protected function getQueuedManipulationItems(): array {
protected function runComposerCommand(array $command_options): OutputCallbackInterface {
$plain_output = new class() implements OutputCallbackInterface {
- // phpcs:ignore DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable
+ /**
+ * The standard output for the process.
+ */
+ // phpcs:ignore DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable, Drupal.Commenting.VariableComment.Missing
public string $stdout = '';
- // phpcs:ignore DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable
+
+ /**
+ * The error output for the process.
+ */
+ // phpcs:ignore DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable, Drupal.Commenting.VariableComment.Missing
public string $stderr = '';
/**
diff --git a/core/modules/package_manager/tests/src/Unit/StageBaseTest.php b/core/modules/package_manager/tests/src/Unit/StageBaseTest.php
index 456a0e83e07bcf93ab1b2028b1f70be41102d175..61ff2af58b81d2e541c277bd7152c89706187461 100644
--- a/core/modules/package_manager/tests/src/Unit/StageBaseTest.php
+++ b/core/modules/package_manager/tests/src/Unit/StageBaseTest.php
@@ -128,7 +128,7 @@ public function testTypeMustBeExplicitlyOverridden(): void {
/**
* {@inheritdoc}
*/
- // phpcs:ignore DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable
+ // phpcs:ignore DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable, Drupal.Commenting.VariableComment.Missing
protected string $type = 'package_manager:good_grandchild';
};
@@ -146,6 +146,9 @@ class ChildStage extends StageBase {
public function __construct() {}
+ /**
+ * {@inheritdoc}
+ */
protected string $type = 'package_manager:child';
}
diff --git a/core/modules/rest/tests/modules/rest_test/src/Plugin/Validation/Constraint/RestTestConstraint.php b/core/modules/rest/tests/modules/rest_test/src/Plugin/Validation/Constraint/RestTestConstraint.php
index e5e186e8dd653addc94b04fa009494ce3688ae5f..a9575b546475151969cf2045a370078e4a86041f 100644
--- a/core/modules/rest/tests/modules/rest_test/src/Plugin/Validation/Constraint/RestTestConstraint.php
+++ b/core/modules/rest/tests/modules/rest_test/src/Plugin/Validation/Constraint/RestTestConstraint.php
@@ -19,6 +19,9 @@
)]
class RestTestConstraint extends SymfonyConstraint {
+ /**
+ * The default violation message.
+ */
public $message = 'REST test validation failed';
}
diff --git a/core/modules/system/tests/modules/entity_test/src/Plugin/Validation/Constraint/EntityTestCompositeConstraint.php b/core/modules/system/tests/modules/entity_test/src/Plugin/Validation/Constraint/EntityTestCompositeConstraint.php
index 227020cd5b9895cb22d698d1dd651abb9b2b1dca..3a46217b5222ec781d2447e627f32fbf39cc9aa8 100644
--- a/core/modules/system/tests/modules/entity_test/src/Plugin/Validation/Constraint/EntityTestCompositeConstraint.php
+++ b/core/modules/system/tests/modules/entity_test/src/Plugin/Validation/Constraint/EntityTestCompositeConstraint.php
@@ -18,6 +18,9 @@
)]
class EntityTestCompositeConstraint extends CompositeConstraintBase {
+ /**
+ * The default violation message.
+ */
public $message = 'Multiple fields are validated';
/**
diff --git a/core/modules/system/tests/modules/entity_test/src/Plugin/Validation/Constraint/EntityTestEntityLevel.php b/core/modules/system/tests/modules/entity_test/src/Plugin/Validation/Constraint/EntityTestEntityLevel.php
index 99b04d01f0d39feacba99a83ec3de6c4a7ae34bf..956c032b5d5962e16fd01465fe96ac863165e8b2 100644
--- a/core/modules/system/tests/modules/entity_test/src/Plugin/Validation/Constraint/EntityTestEntityLevel.php
+++ b/core/modules/system/tests/modules/entity_test/src/Plugin/Validation/Constraint/EntityTestEntityLevel.php
@@ -18,6 +18,11 @@
)]
class EntityTestEntityLevel extends SymfonyConstraint {
+ /**
+ * The error message.
+ *
+ * @var string
+ */
public $message = 'Entity level validation';
}
diff --git a/core/modules/system/tests/modules/entity_test/src/Plugin/Validation/Constraint/FieldWidgetConstraint.php b/core/modules/system/tests/modules/entity_test/src/Plugin/Validation/Constraint/FieldWidgetConstraint.php
index 7cb72da3b073d4e9fdad84ac534378bac34c3d5e..9e69c9e4b765a5dfeb1d25bff021bfc318c3016e 100644
--- a/core/modules/system/tests/modules/entity_test/src/Plugin/Validation/Constraint/FieldWidgetConstraint.php
+++ b/core/modules/system/tests/modules/entity_test/src/Plugin/Validation/Constraint/FieldWidgetConstraint.php
@@ -17,6 +17,9 @@
)]
class FieldWidgetConstraint extends SymfonyConstraint {
+ /**
+ * The default violation message.
+ */
public $message = 'Widget constraint has failed.';
}
diff --git a/core/modules/system/tests/modules/sdc_other_node_visitor/src/Twig/NodeVisitor/TestNodeVisitor.php b/core/modules/system/tests/modules/sdc_other_node_visitor/src/Twig/NodeVisitor/TestNodeVisitor.php
index 637557b40b12b097a5a7d67c845bc7586f9a8415..2b3d0b0b30191bfc12daed0fdf7cfe90245ea9da 100644
--- a/core/modules/system/tests/modules/sdc_other_node_visitor/src/Twig/NodeVisitor/TestNodeVisitor.php
+++ b/core/modules/system/tests/modules/sdc_other_node_visitor/src/Twig/NodeVisitor/TestNodeVisitor.php
@@ -20,8 +20,14 @@
*/
final class TestNodeVisitor implements NodeVisitorInterface {
+ /**
+ * The name of the extension.
+ */
private string $extensionName;
+ /**
+ * The variable name.
+ */
private string $varName;
/**
diff --git a/core/modules/system/tests/src/Functional/Cache/CacheTestBase.php b/core/modules/system/tests/src/Functional/Cache/CacheTestBase.php
index 56ceaae71afd29f1133ce0322dea33fe2fdac44f..14bd0846d16d74a12f697a83089b1b5e91551caa 100644
--- a/core/modules/system/tests/src/Functional/Cache/CacheTestBase.php
+++ b/core/modules/system/tests/src/Functional/Cache/CacheTestBase.php
@@ -11,8 +11,19 @@
*/
abstract class CacheTestBase extends BrowserTestBase {
+ /**
+ * The default bin for the cache item.
+ */
protected $defaultBin = 'render';
+
+ /**
+ * The default cache ID.
+ */
protected $defaultCid = 'test_temporary';
+
+ /**
+ * The cache contents default value.
+ */
protected $defaultValue = 'CacheTest';
/**
diff --git a/core/modules/system/tests/src/Functional/FileTransfer/MockTestConnection.php b/core/modules/system/tests/src/Functional/FileTransfer/MockTestConnection.php
index 5de24c61fc17ba9ccd95cf17106656d03e81cc94..a3b505acd3962d626a6852bff623267fe3b56544 100644
--- a/core/modules/system/tests/src/Functional/FileTransfer/MockTestConnection.php
+++ b/core/modules/system/tests/src/Functional/FileTransfer/MockTestConnection.php
@@ -9,7 +9,14 @@
*/
class MockTestConnection {
+ /**
+ * The commands to run.
+ */
protected $commandsRun = [];
+
+ /**
+ * The database connection.
+ */
public $connectionString;
public function run($cmd) {
diff --git a/core/modules/system/tests/src/Functional/Form/UrlTest.php b/core/modules/system/tests/src/Functional/Form/UrlTest.php
index ee1d1fc76400b0229c4563408a897571d7d40bda..ac6aee19f3433da0c77f57c77fe95d4394089b28 100644
--- a/core/modules/system/tests/src/Functional/Form/UrlTest.php
+++ b/core/modules/system/tests/src/Functional/Form/UrlTest.php
@@ -19,8 +19,6 @@ class UrlTest extends BrowserTestBase {
*/
protected static $modules = ['form_test'];
- protected $profile = 'testing';
-
/**
* {@inheritdoc}
*/
diff --git a/core/modules/system/tests/src/Functional/Module/ModuleTestBase.php b/core/modules/system/tests/src/Functional/Module/ModuleTestBase.php
index a5a34cc2630ef3a190fdf22c51bca836f8c3478b..18a76bf1c9158f12113f8ec7ddabdc1679e9fe38 100644
--- a/core/modules/system/tests/src/Functional/Module/ModuleTestBase.php
+++ b/core/modules/system/tests/src/Functional/Module/ModuleTestBase.php
@@ -21,6 +21,9 @@ abstract class ModuleTestBase extends BrowserTestBase {
*/
protected static $modules = ['system_test'];
+ /**
+ * The test user.
+ */
protected $adminUser;
/**
diff --git a/core/modules/system/tests/src/Functional/Pager/PagerTest.php b/core/modules/system/tests/src/Functional/Pager/PagerTest.php
index 3f46565d049d0e13b1f076b12bc4553e2757578e..9d0cae26b41289973bb77244f74069f48115052e 100644
--- a/core/modules/system/tests/src/Functional/Pager/PagerTest.php
+++ b/core/modules/system/tests/src/Functional/Pager/PagerTest.php
@@ -34,8 +34,6 @@ class PagerTest extends BrowserTestBase {
*/
protected $adminUser;
- protected $profile = 'testing';
-
/**
* {@inheritdoc}
*/
diff --git a/core/modules/system/tests/src/Functional/System/AccessDeniedTest.php b/core/modules/system/tests/src/Functional/System/AccessDeniedTest.php
index 3907ad12cd6042cd14420939f3f3ca5ac3ec6d76..3266b8564881b200ec620f5d61875bf8f28def36 100644
--- a/core/modules/system/tests/src/Functional/System/AccessDeniedTest.php
+++ b/core/modules/system/tests/src/Functional/System/AccessDeniedTest.php
@@ -27,6 +27,9 @@ class AccessDeniedTest extends BrowserTestBase {
*/
protected $defaultTheme = 'stark';
+ /**
+ * The test user.
+ */
protected $adminUser;
/**
diff --git a/core/modules/system/tests/src/Functional/System/MainContentFallbackTest.php b/core/modules/system/tests/src/Functional/System/MainContentFallbackTest.php
index fa3e318fea3e167103ba63d9ec93abbaed6e0ae8..f893e5aecfdd6335195f539c54b34379d3f74584 100644
--- a/core/modules/system/tests/src/Functional/System/MainContentFallbackTest.php
+++ b/core/modules/system/tests/src/Functional/System/MainContentFallbackTest.php
@@ -23,7 +23,14 @@ class MainContentFallbackTest extends BrowserTestBase {
*/
protected $defaultTheme = 'stark';
+ /**
+ * The administrator user for the test.
+ */
protected $adminUser;
+
+ /**
+ * The web user for the test.
+ */
protected $webUser;
/**
diff --git a/core/modules/system/tests/src/Functional/System/PageNotFoundTest.php b/core/modules/system/tests/src/Functional/System/PageNotFoundTest.php
index 3950822f73da9dadddb5656a9cf47b16b42b9608..5a48868682a47925214f1bd72af0866760c9a4c0 100644
--- a/core/modules/system/tests/src/Functional/System/PageNotFoundTest.php
+++ b/core/modules/system/tests/src/Functional/System/PageNotFoundTest.php
@@ -27,6 +27,9 @@ class PageNotFoundTest extends BrowserTestBase {
*/
protected $defaultTheme = 'stark';
+ /**
+ * The test user.
+ */
protected $adminUser;
/**
diff --git a/core/modules/system/tests/src/Functional/System/PageTitleTest.php b/core/modules/system/tests/src/Functional/System/PageTitleTest.php
index a51362999ca3a523c38c11c8c48006225432a6ae..0928f535bad20eb209bd5e55b3e794e88b648623 100644
--- a/core/modules/system/tests/src/Functional/System/PageTitleTest.php
+++ b/core/modules/system/tests/src/Functional/System/PageTitleTest.php
@@ -26,7 +26,11 @@ class PageTitleTest extends BrowserTestBase {
*/
protected $defaultTheme = 'starterkit_theme';
+ /**
+ * The test user.
+ */
protected $contentUser;
+ protected $savedTitle;
/**
* Implement setUp().
diff --git a/core/modules/system/tests/src/Functional/System/SiteMaintenanceTest.php b/core/modules/system/tests/src/Functional/System/SiteMaintenanceTest.php
index f49b74078f3bd49c4b339aa3b7746a22abd41c02..8a34e27c4b0b830c231ec4a1943799a544cc2ea7 100644
--- a/core/modules/system/tests/src/Functional/System/SiteMaintenanceTest.php
+++ b/core/modules/system/tests/src/Functional/System/SiteMaintenanceTest.php
@@ -30,6 +30,9 @@ class SiteMaintenanceTest extends BrowserTestBase {
*/
protected $defaultTheme = 'stark';
+ /**
+ * The test user.
+ */
protected $adminUser;
/**
diff --git a/core/modules/system/tests/src/Kernel/Migrate/d6/MigrateSystemConfigurationTest.php b/core/modules/system/tests/src/Kernel/Migrate/d6/MigrateSystemConfigurationTest.php
index 5ce419d0e4daa1223e472d32406dba00a8b57671..2223473e05b05bafc83b24248fc0a29584bd70bc 100644
--- a/core/modules/system/tests/src/Kernel/Migrate/d6/MigrateSystemConfigurationTest.php
+++ b/core/modules/system/tests/src/Kernel/Migrate/d6/MigrateSystemConfigurationTest.php
@@ -18,6 +18,9 @@ class MigrateSystemConfigurationTest extends MigrateDrupal6TestBase {
*/
protected static $modules = ['file', 'system'];
+ /**
+ * The expected configuration after migration.
+ */
protected $expectedConfig = [
'system.cron' => [
'threshold' => [
diff --git a/core/modules/system/tests/src/Kernel/Migrate/d7/MigrateSystemConfigurationTest.php b/core/modules/system/tests/src/Kernel/Migrate/d7/MigrateSystemConfigurationTest.php
index 60a0f2c4af6f7db9c79ec3f59cfe1fd1c3f191c4..6eb71045f421232d56f48f969143fdc9bf639b23 100644
--- a/core/modules/system/tests/src/Kernel/Migrate/d7/MigrateSystemConfigurationTest.php
+++ b/core/modules/system/tests/src/Kernel/Migrate/d7/MigrateSystemConfigurationTest.php
@@ -18,6 +18,9 @@ class MigrateSystemConfigurationTest extends MigrateDrupal7TestBase {
*/
protected static $modules = ['file', 'system'];
+ /**
+ * The expected configuration after migration.
+ */
protected $expectedConfig = [
'system.authorize' => [],
'system.cron' => [
diff --git a/core/modules/system/tests/src/Unit/Breadcrumbs/PathBasedBreadcrumbBuilderTest.php b/core/modules/system/tests/src/Unit/Breadcrumbs/PathBasedBreadcrumbBuilderTest.php
index 241e1a00a76a1ed643d5b2b17699b67850cc347c..e3745d48775533a9366f8b5ad55c17f3ada440a6 100644
--- a/core/modules/system/tests/src/Unit/Breadcrumbs/PathBasedBreadcrumbBuilderTest.php
+++ b/core/modules/system/tests/src/Unit/Breadcrumbs/PathBasedBreadcrumbBuilderTest.php
@@ -432,6 +432,9 @@ protected function setupStubPathProcessor(): void {
*/
class TestPathBasedBreadcrumbBuilder extends PathBasedBreadcrumbBuilder {
+ /**
+ * The test link generator.
+ */
protected LinkGeneratorInterface $linkGenerator;
public function setStringTranslation(TranslationInterface $string_translation) {
diff --git a/core/modules/user/tests/src/Kernel/Views/HandlerFilterPermissionTest.php b/core/modules/user/tests/src/Kernel/Views/HandlerFilterPermissionTest.php
index afb0c0ae91c95aef720e229757b261489ea3bd3c..9cb16c0a901ce4b4b7ac864459a3e3fea5094f41 100644
--- a/core/modules/user/tests/src/Kernel/Views/HandlerFilterPermissionTest.php
+++ b/core/modules/user/tests/src/Kernel/Views/HandlerFilterPermissionTest.php
@@ -21,6 +21,7 @@ class HandlerFilterPermissionTest extends UserKernelTestBase {
* @var array
*/
public static $testViews = ['test_filter_permission'];
+ protected $columnMap;
/**
* Tests the permission filter handler.
diff --git a/core/modules/views/tests/modules/views_test_data/src/Plugin/views/query/QueryTest.php b/core/modules/views/tests/modules/views_test_data/src/Plugin/views/query/QueryTest.php
index 00d03c9f0645d95bfc071721c9300a9dcb8f9a30..c18f139616d24a6a22346ccd3b6df75f71a96327 100644
--- a/core/modules/views/tests/modules/views_test_data/src/Plugin/views/query/QueryTest.php
+++ b/core/modules/views/tests/modules/views_test_data/src/Plugin/views/query/QueryTest.php
@@ -21,9 +21,25 @@
help: new TranslatableMarkup('Defines a query test plugin.')
)]
class QueryTest extends QueryPluginBase {
+
+ /**
+ * The conditions to apply to the query.
+ */
protected $conditions = [];
+
+ /**
+ * The list of fields.
+ */
protected $fields = [];
+
+ /**
+ * An array of stdClasses.
+ */
protected $allItems = [];
+
+ /**
+ * The field to order and the direction.
+ */
protected $orderBy = [];
/**
diff --git a/core/modules/views/tests/src/FunctionalJavascript/BlockExposedFilterAJAXTest.php b/core/modules/views/tests/src/FunctionalJavascript/BlockExposedFilterAJAXTest.php
index dff279552af76f81045479b7b30d36ac4065065c..36a1cf75dcbc591d5dd7b2254680e4540191d46f 100644
--- a/core/modules/views/tests/src/FunctionalJavascript/BlockExposedFilterAJAXTest.php
+++ b/core/modules/views/tests/src/FunctionalJavascript/BlockExposedFilterAJAXTest.php
@@ -24,6 +24,9 @@ class BlockExposedFilterAJAXTest extends WebDriverTestBase {
*/
protected static $modules = ['node', 'views', 'block', 'views_test_config'];
+ /**
+ * The views to use for testing.
+ */
public static $testViews = ['test_block_exposed_ajax', 'test_block_exposed_ajax_with_page'];
/**
diff --git a/core/modules/views/tests/src/FunctionalJavascript/ClickSortingAJAXTest.php b/core/modules/views/tests/src/FunctionalJavascript/ClickSortingAJAXTest.php
index 29cad07068b0688599e597042041fab936a165f0..abc6037dd06a0d715d3629e7116d12375158eb05 100644
--- a/core/modules/views/tests/src/FunctionalJavascript/ClickSortingAJAXTest.php
+++ b/core/modules/views/tests/src/FunctionalJavascript/ClickSortingAJAXTest.php
@@ -29,6 +29,9 @@ class ClickSortingAJAXTest extends WebDriverTestBase {
*/
protected $defaultTheme = 'stark';
+ /**
+ * The views to use for testing.
+ */
public static $testViews = ['test_content_ajax'];
/**
diff --git a/core/modules/views/tests/src/FunctionalJavascript/PaginationAJAXTest.php b/core/modules/views/tests/src/FunctionalJavascript/PaginationAJAXTest.php
index 5eb53caba9ccae5816f9f05ec0875b72f00d3c4e..40141d188da6221b7dc1a0546cad2eb5d8fdbb66 100644
--- a/core/modules/views/tests/src/FunctionalJavascript/PaginationAJAXTest.php
+++ b/core/modules/views/tests/src/FunctionalJavascript/PaginationAJAXTest.php
@@ -35,6 +35,9 @@ class PaginationAJAXTest extends WebDriverTestBase {
*/
public static $testViews = ['test_content_ajax'];
+ /**
+ * The test user.
+ */
protected $user;
/**
diff --git a/core/modules/views/tests/src/Unit/Plugin/Derivative/ViewsLocalTaskTest.php b/core/modules/views/tests/src/Unit/Plugin/Derivative/ViewsLocalTaskTest.php
index f0dde96d809148c400290ce7495bc1cc02c5b75a..27e53c1c92e7736d419a03538f45e7da6b5dabe8 100644
--- a/core/modules/views/tests/src/Unit/Plugin/Derivative/ViewsLocalTaskTest.php
+++ b/core/modules/views/tests/src/Unit/Plugin/Derivative/ViewsLocalTaskTest.php
@@ -34,6 +34,9 @@ class ViewsLocalTaskTest extends UnitTestCase {
*/
protected $viewStorage;
+ /**
+ * The base definition for the test plugin.
+ */
protected $baseDefinition = [
'class' => '\Drupal\views\Plugin\Menu\LocalTask\ViewsLocalTask',
'deriver' => '\Drupal\views\Plugin\Derivative\ViewsLocalTask',
@@ -383,6 +386,9 @@ public function testGetDerivativeDefinitionsWithExistingLocalTask(): void {
*/
class TestViewsLocalTask extends ViewsLocalTask {
+ /**
+ * The view result.
+ */
protected $result;
/**
diff --git a/core/modules/views_ui/tests/src/FunctionalJavascript/DisplayTest.php b/core/modules/views_ui/tests/src/FunctionalJavascript/DisplayTest.php
index f5ad7de3ba705b7e0212c11420268359fd121230..7fa18698677462cd213399d4fe7e36ff22031b6f 100644
--- a/core/modules/views_ui/tests/src/FunctionalJavascript/DisplayTest.php
+++ b/core/modules/views_ui/tests/src/FunctionalJavascript/DisplayTest.php
@@ -41,6 +41,9 @@ class DisplayTest extends WebDriverTestBase {
*/
protected $defaultTheme = 'stark';
+ /**
+ * The views used for testing.
+ */
public static $testViews = ['test_content_ajax', 'test_display'];
/**
diff --git a/core/modules/workspaces/tests/src/Functional/WorkspaceTestUtilities.php b/core/modules/workspaces/tests/src/Functional/WorkspaceTestUtilities.php
index 899dfec2780f9072b927789ce827fd24c20bb621..25108d6412fb058d76241e23b0803d179987bcaa 100644
--- a/core/modules/workspaces/tests/src/Functional/WorkspaceTestUtilities.php
+++ b/core/modules/workspaces/tests/src/Functional/WorkspaceTestUtilities.php
@@ -19,6 +19,9 @@ trait WorkspaceTestUtilities {
use BlockCreationTrait;
+ /**
+ * Signifies that the switcher block is configured.
+ */
protected $switcherBlockConfigured = FALSE;
/**
diff --git a/core/phpcs.xml.dist b/core/phpcs.xml.dist
index 3bf930d50a45d8a6c13c1e0fc9e2a22add89bfe4..4534ec882e3b600087585a362d7a172af759b94b 100644
--- a/core/phpcs.xml.dist
+++ b/core/phpcs.xml.dist
@@ -112,6 +112,7 @@
<rule ref="Drupal.Commenting.VariableComment.Missing">
<exclude-pattern>./core/tests/*</exclude-pattern>
<exclude-pattern>./core/*/tests/*</exclude-pattern>
+ <include-pattern>core/modules/*/tests/modules/*</include-pattern>
</rule>
<rule ref="Drupal.ControlStructures.ControlSignature"/>
<rule ref="Drupal.ControlStructures.ElseIf"/>
diff --git a/core/profiles/minimal/tests/src/Functional/MinimalTest.php b/core/profiles/minimal/tests/src/Functional/MinimalTest.php
index cfc5b65b9b118b05d39dfa03a584637c3f02d2e7..b0e9d2cbe2a48dcafe561283d98ba49594e8e54c 100644
--- a/core/profiles/minimal/tests/src/Functional/MinimalTest.php
+++ b/core/profiles/minimal/tests/src/Functional/MinimalTest.php
@@ -19,6 +19,9 @@ class MinimalTest extends BrowserTestBase {
use SchemaCheckTestTrait;
use RequirementsPageTrait;
+ /**
+ * The profile to use.
+ */
protected $profile = 'minimal';
/**
diff --git a/core/profiles/standard/tests/src/Functional/StandardTest.php b/core/profiles/standard/tests/src/Functional/StandardTest.php
index 4bb993ffc947108a03ef6ebe8021aa8b05d33d15..cc16629b8468255f1ab028d3332c2d59e9a1863d 100644
--- a/core/profiles/standard/tests/src/Functional/StandardTest.php
+++ b/core/profiles/standard/tests/src/Functional/StandardTest.php
@@ -15,6 +15,9 @@
class StandardTest extends BrowserTestBase {
use StandardTestTrait;
+ /**
+ * The profile to use.
+ */
protected $profile = 'standard';
}