Issue #2805281 by Wim Leers, damiankloip: ?_format=hal_json error responses...

Issue #2805281 by Wim Leers, damiankloip: ?_format=hal_json error responses are application/json, yet should be application/hal+json

core/modules/hal/hal.services.yml

@@ -26,7 +26,3 @@ services:
     class: Drupal\hal\Encoder\JsonEncoder
     tags:
       - { name: encoder, priority: 10, format: hal_json }
-  exception.default_json:
-    class: Drupal\hal\EventSubscriber\ExceptionHalJsonSubscriber
-    tags:
-      - { name: event_subscriber }

core/modules/hal/src/EventSubscriber/ExceptionHalJsonSubscriber.php

-<?php
-
-namespace Drupal\hal\EventSubscriber;
-
-use Drupal\Core\EventSubscriber\ExceptionJsonSubscriber;
-
-/**
- * Handle HAL JSON exceptions the same as JSON exceptions.
- */
-class ExceptionHalJsonSubscriber extends ExceptionJsonSubscriber {
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function getHandledFormats() {
-    return ['hal_json'];
-  }
-
-}

core/modules/hal/tests/src/Functional/EntityResource/Block/BlockHalJsonAnonTest.php

@@ -27,9 +27,4 @@ class BlockHalJsonAnonTest extends BlockResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
 }

core/modules/hal/tests/src/Functional/EntityResource/Block/BlockHalJsonBasicAuthTest.php

@@ -27,11 +27,6 @@ class BlockHalJsonBasicAuthTest extends BlockResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
   /**
    * {@inheritdoc}
    */

core/modules/hal/tests/src/Functional/EntityResource/Block/BlockHalJsonCookieTest.php

@@ -27,11 +27,6 @@ class BlockHalJsonCookieTest extends BlockResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
   /**
    * {@inheritdoc}
    */

core/modules/hal/tests/src/Functional/EntityResource/Comment/CommentHalJsonTestBase.php

@@ -27,11 +27,6 @@ abstract class CommentHalJsonTestBase extends CommentResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
   /**
    * {@inheritdoc}
    *

core/modules/hal/tests/src/Functional/EntityResource/ConfigTest/ConfigTestHalJsonAnonTest.php

@@ -27,9 +27,4 @@ class ConfigTestHalJsonAnonTest extends ConfigTestResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
 }

core/modules/hal/tests/src/Functional/EntityResource/ConfigTest/ConfigTestHalJsonBasicAuthTest.php

@@ -27,11 +27,6 @@ class ConfigTestHalJsonBasicAuthTest extends ConfigTestResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
   /**
    * {@inheritdoc}
    */

core/modules/hal/tests/src/Functional/EntityResource/ConfigTest/ConfigTestHalJsonCookieTest.php

@@ -27,11 +27,6 @@ class ConfigTestHalJsonCookieTest extends ConfigTestResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
   /**
    * {@inheritdoc}
    */

core/modules/hal/tests/src/Functional/EntityResource/EntityTest/EntityTestHalJsonAnonTest.php

@@ -31,11 +31,6 @@ class EntityTestHalJsonAnonTest extends EntityTestResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
   /**
    * {@inheritdoc}
    */

core/modules/hal/tests/src/Functional/EntityResource/Node/NodeHalJsonAnonTest.php

@@ -31,11 +31,6 @@ class NodeHalJsonAnonTest extends NodeResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
   /**
    * {@inheritdoc}
    */

core/modules/hal/tests/src/Functional/EntityResource/Role/RoleHalJsonAnonTest.php

@@ -27,9 +27,4 @@ class RoleHalJsonAnonTest extends RoleResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
 }

core/modules/hal/tests/src/Functional/EntityResource/Role/RoleHalJsonBasicAuthTest.php

@@ -27,11 +27,6 @@ class RoleHalJsonBasicAuthTest extends RoleResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
   /**
    * {@inheritdoc}
    */

core/modules/hal/tests/src/Functional/EntityResource/Role/RoleHalJsonCookieTest.php

@@ -27,11 +27,6 @@ class RoleHalJsonCookieTest extends RoleResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
   /**
    * {@inheritdoc}
    */

core/modules/hal/tests/src/Functional/EntityResource/Term/TermHalJsonAnonTest.php

@@ -30,11 +30,6 @@ class TermHalJsonAnonTest extends TermResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
   /**
    * {@inheritdoc}
    */

core/modules/hal/tests/src/Functional/EntityResource/User/UserHalJsonAnonTest.php

@@ -30,11 +30,6 @@ class UserHalJsonAnonTest extends UserResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
   /**
    * {@inheritdoc}
    */

core/modules/hal/tests/src/Functional/EntityResource/Vocabulary/VocabularyHalJsonAnonTest.php

@@ -27,11 +27,6 @@ class VocabularyHalJsonAnonTest extends VocabularyResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
   /**
    * @todo Remove this override in https://www.drupal.org/node/2805281.
    */

core/modules/hal/tests/src/Functional/EntityResource/Vocabulary/VocabularyHalJsonBasicAuthTest.php

@@ -27,11 +27,6 @@ class VocabularyHalJsonBasicAuthTest extends VocabularyResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
   /**
    * {@inheritdoc}
    */

core/modules/hal/tests/src/Functional/EntityResource/Vocabulary/VocabularyHalJsonCookieTest.php

@@ -27,11 +27,6 @@ class VocabularyHalJsonCookieTest extends VocabularyResourceTestBase {
    */
   protected static $mimeType = 'application/hal+json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
   /**
    * {@inheritdoc}
    */

core/modules/rest/tests/src/Functional/EntityResource/Block/BlockJsonAnonTest.php

@@ -21,9 +21,4 @@ class BlockJsonAnonTest extends BlockResourceTestBase {
    */
   protected static $mimeType = 'application/json';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected static $expectedErrorMimeType = 'application/json';
-
 }