From 5052fcddde7744bd1f78f21bbcfe0a502bd44cd0 Mon Sep 17 00:00:00 2001
From: catch <catch@35733.no-reply.drupal.org>
Date: Wed, 2 Aug 2023 13:53:31 +0100
Subject: [PATCH] Issue #3377131 by longwave, smustgrave: File mode check in
commit-code-check.sh is too strict
---
core/scripts/dev/commit-code-check.sh | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/core/scripts/dev/commit-code-check.sh b/core/scripts/dev/commit-code-check.sh
index 59d72b041118..a22a7808afb9 100755
--- a/core/scripts/dev/commit-code-check.sh
+++ b/core/scripts/dev/commit-code-check.sh
@@ -366,13 +366,8 @@
# Ensure the file still exists (i.e. is not being deleted).
if [ -a $FILE ]; then
if [ ${FILE: -3} != ".sh" ]; then
- # Ensure the file has the correct mode.
- STAT="$(stat -f "%A" $FILE 2>/dev/null)"
- if [ $? -ne 0 ]; then
- STAT="$(stat -c "%a" $FILE 2>/dev/null)"
- fi
- if [ "$STAT" -ne "644" ]; then
- printf "${red}check failed:${reset} file $FILE should be 644 not $STAT\n"
+ if [ -x $FILE ]; then
+ printf "${red}check failed:${reset} file $FILE should not be executable\n"
STATUS=1
fi
fi
--
GitLab