From 4c66ab52f31d0b9718b7f4255536797695d187fc Mon Sep 17 00:00:00 2001 From: Steven Wittens <steven@10.no-reply.drupal.org> Date: Tue, 27 Dec 2005 18:42:49 +0000 Subject: [PATCH] - #31301: Don't escape apostrophes in XML-RPC strings. /me looks down OH MY GOD... I'M MELLLLTTIIINNGG NOOOOOOO.... AAARGHHHHHH. Oh well, don't the people inside the asylum say the outside world is insane, too? --- includes/xmlrpc.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/includes/xmlrpc.inc b/includes/xmlrpc.inc index 9ab6be402837..fae8b1c1f3f9 100644 --- a/includes/xmlrpc.inc +++ b/includes/xmlrpc.inc @@ -82,7 +82,9 @@ function xmlrpc_value_get_xml($xmlrpc_value) { return '<double>'. $xmlrpc_value->data .'</double>'; break; case 'string': - return '<string>'. check_plain($xmlrpc_value->data) .'</string>'; + // Note: we don't escape apostrophes because of the many blogging clients + // that don't support numerical entities (and XML in general) properly. + return '<string>'. htmlspecialchars($xmlrpc_value->data) .'</string>'; break; case 'array': $return = '<array><data>'."\n"; -- GitLab