Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
7
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Open sidebar
project
drupal
Commits
47a7b736
Unverified
Commit
47a7b736
authored
Jul 20, 2020
by
alexpott
2
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue
#3155462
by andrewmacpherson: Remove landmark region role from Powered-by-Drupal block
parent
6752b8d1
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
13 deletions
+1
-13
core/modules/system/system.module
core/modules/system/system.module
+0
-4
core/profiles/standard/tests/src/Functional/StandardTest.php
core/profiles/standard/tests/src/Functional/StandardTest.php
+1
-9
No files found.
core/modules/system/system.module
View file @
47a7b736
...
@@ -800,10 +800,6 @@ function system_preprocess_block(&$variables) {
...
@@ -800,10 +800,6 @@ function system_preprocess_block(&$variables) {
];
];
}
}
break
;
break
;
case
'system_powered_by_block'
:
$variables
[
'attributes'
][
'role'
]
=
'complementary'
;
break
;
}
}
}
}
...
...
core/profiles/standard/tests/src/Functional/StandardTest.php
View file @
47a7b736
...
@@ -61,8 +61,7 @@ public function testStandard() {
...
@@ -61,8 +61,7 @@ public function testStandard() {
$this
->
drupalGet
(
''
);
$this
->
drupalGet
(
''
);
$this
->
assertText
(
'Main navigation'
);
$this
->
assertText
(
'Main navigation'
);
// Verify we have role = aria on system_powered_by and help_block
// Verify we have role = complementary on help_block blocks.
// blocks.
$this
->
drupalGet
(
'admin/structure/block'
);
$this
->
drupalGet
(
'admin/structure/block'
);
$elements
=
$this
->
xpath
(
'//div[@role=:role and @id=:id]'
,
[
$elements
=
$this
->
xpath
(
'//div[@role=:role and @id=:id]'
,
[
':role'
=>
'complementary'
,
':role'
=>
'complementary'
,
...
@@ -71,13 +70,6 @@ public function testStandard() {
...
@@ -71,13 +70,6 @@ public function testStandard() {
$this
->
assertCount
(
1
,
$elements
,
'Found complementary role on help block.'
);
$this
->
assertCount
(
1
,
$elements
,
'Found complementary role on help block.'
);
$this
->
drupalGet
(
''
);
$elements
=
$this
->
xpath
(
'//div[@role=:role and @id=:id]'
,
[
':role'
=>
'complementary'
,
':id'
=>
'block-bartik-powered'
,
]);
$this
->
assertCount
(
1
,
$elements
,
'Found complementary role on powered by block.'
);
// Verify anonymous user can see the block.
// Verify anonymous user can see the block.
$this
->
drupalLogout
();
$this
->
drupalLogout
();
$this
->
assertText
(
'Main navigation'
);
$this
->
assertText
(
'Main navigation'
);
...
...
alexpott
@alexpott
mentioned in commit
2ae9c222
·
Jul 21, 2020
mentioned in commit
2ae9c222
mentioned in commit 2ae9c22205cced7a0beaf18601e0d681355f8110
Toggle commit list
alexpott
@alexpott
mentioned in commit
72fa05ef
·
Jul 21, 2020
mentioned in commit
72fa05ef
mentioned in commit 72fa05ef339762c8475618411e09269d2e0cf480
Toggle commit list
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment