Commit 47028f4d authored by larowlan's avatar larowlan

Issue #2887000 by cilefen, Mile23, mpdonadio, Eric_A: composer.json does not...

Issue #2887000 by cilefen, Mile23, mpdonadio, Eric_A: composer.json does not constrain Symfony components to minor and patch versions that are compatible with Drupal
parent ebfcdda2
......@@ -5,19 +5,19 @@
"license": "GPL-2.0+",
"require": {
"php": ">=5.5.9",
"symfony/class-loader": "^3.2",
"symfony/console": "^3.2",
"symfony/dependency-injection": "^3.2",
"symfony/event-dispatcher": "^3.2",
"symfony/http-foundation": "^3.2",
"symfony/http-kernel": "^3.2",
"symfony/routing": "^3.2",
"symfony/serializer": "^3.2",
"symfony/translation": "^3.2",
"symfony/validator": "^3.2",
"symfony/process": "^3.2",
"symfony/class-loader": "~3.2.8",
"symfony/console": "~3.2.8",
"symfony/dependency-injection": "~3.2.8",
"symfony/event-dispatcher": "~3.2.8",
"symfony/http-foundation": "~3.2.8",
"symfony/http-kernel": "~3.2.8",
"symfony/routing": "~3.2.8",
"symfony/serializer": "~3.2.8",
"symfony/translation": "~3.2.8",
"symfony/validator": "~3.2.8",
"symfony/process": "~3.2.8",
"symfony/polyfill-iconv": "^1.0",
"symfony/yaml": "^3.2",
"symfony/yaml": "~3.2.8",
"twig/twig": "^1.23.1",
"doctrine/common": "^2.5",
"doctrine/annotations": "^1.2",
......@@ -45,8 +45,8 @@
"jcalderonzumba/mink-phantomjs-driver": "^0.3.1",
"mikey179/vfsStream": "^1.2",
"phpunit/phpunit": ">=4.8.35 <5",
"symfony/css-selector": "^3.2",
"symfony/phpunit-bridge": "^3.2"
"symfony/css-selector": "~3.2.8",
"symfony/phpunit-bridge": "~3.2.8"
},
"replace": {
"drupal/action": "self.version",
......
......@@ -104,6 +104,11 @@ public function testComposerTilde($path) {
}
foreach ($composer_keys as $composer_key) {
foreach ($content[$composer_key] as $dependency => $version) {
// We allow tildes if the dependency is a Symfony component.
// @see https://www.drupal.org/node/2887000
if (strpos($dependency, 'symfony/') === 0) {
continue;
}
$this->assertFalse(strpos($version, '~'), "Dependency $dependency in $path contains a tilde, use a caret.");
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment