Issue #2100329 by cosmicdreams: Use \Drupal instead of Drupal to make IDEs and...

Issue #2100329 by cosmicdreams: Use \Drupal instead of Drupal to make IDEs and static code analyse tools happy.

core/includes/bootstrap.inc

@@ -2277,7 +2277,7 @@ function _drupal_load_test_overrides($test_prefix) {
   global $conf, $config_directories;
 
   // Do not use the parent site's config directories. Use only the child site's.
-  // @see Drupal\simpletest\TestBase::prepareConfigDirectories()
+  // @see \Drupal\simpletest\TestBase::prepareConfigDirectories()
   $path_prefix = 'simpletest/' . substr($test_prefix, 10);
   $config_directories = array();
   foreach (array(CONFIG_ACTIVE_DIRECTORY, CONFIG_STAGING_DIRECTORY) as $type) {
@@ -2353,7 +2353,7 @@ function drupal_language_initialize() {
 /**
  * Returns the language object for a given language type.
  *
- * @see Drupal\Core\Language\LanguageManager
+ * @see \Drupal\Core\Language\LanguageManager
  *
  * @param string $type
  *   The type of language object needed, e.g. Language::TYPE_INTERFACE.
@@ -2561,7 +2561,7 @@ function language_is_locked($langcode) {
 /**
  * Returns the default language used on the site.
  *
- * @return Drupal\Core\Language\Language
+ * @return \Drupal\Core\Language\Language
  *   A language object.
  */
 function language_default() {
@@ -3086,7 +3086,7 @@ function drupal_check_memory_limit($required, $memory_limit = NULL) {
  * @deprecated Use \Drupal::lock() instead, or even better have the lock service
  *   injected into your object.
  *
- * @return Drupal\Core\Lock\LockBackendInterface
+ * @return \Drupal\Core\Lock\LockBackendInterface
  */
 function lock() {
   return \Drupal::lock();

core/includes/cache.inc

@@ -20,10 +20,10 @@
  *   The cache bin for which the cache object should be returned, defaults to
  *   'cache'.
  *
- * @return Drupal\Core\Cache\CacheBackendInterface
+ * @return \Drupal\Core\Cache\CacheBackendInterface
  *   The cache object associated with the specified bin.
  *
- * @see Drupal\Core\Cache\CacheBackendInterface
+ * @see \Drupal\Core\Cache\CacheBackendInterface
  */
 function cache($bin = 'cache') {
   return \Drupal::cache($bin);

core/includes/common.inc

@@ -297,7 +297,7 @@ function drupal_get_profile() {
  * @deprecated This will be removed in 8.0. Instead, register a new breadcrumb
  *   builder service.
  *
- * @see Drupal\Core\Breadcrumb\BreadcrumbBuilderInterface
+ * @see \Drupal\Core\Breadcrumb\BreadcrumbBuilderInterface
  */
 function drupal_set_breadcrumb($breadcrumb = NULL) {
   $stored_breadcrumb = &drupal_static(__FUNCTION__);
@@ -3135,8 +3135,8 @@ function _drupal_bootstrap_code() {
  *
  * DrupalKernel skips this and replicates it via event listeners.
  *
- * @see Drupal\Core\EventSubscriber\PathSubscriber;
- * @see Drupal\Core\EventSubscriber\LegacyRequestSubscriber;
+ * @see \Drupal\Core\EventSubscriber\PathSubscriber;
+ * @see \Drupal\Core\EventSubscriber\LegacyRequestSubscriber;
  */
 function _drupal_bootstrap_full($skip = FALSE) {
   static $called = FALSE;
@@ -4949,7 +4949,7 @@ function archiver_get_archiver($file) {
  * @return array
  *   The Drupal Updater class registry.
  *
- * @see Drupal\Core\Updater\Updater
+ * @see \Drupal\Core\Updater\Updater
  * @see hook_updater_info()
  * @see hook_updater_info_alter()
  */
@@ -4969,7 +4969,7 @@ function drupal_get_updaters() {
  * @return
  *   The Drupal FileTransfer class registry.
  *
- * @see Drupal\Core\FileTransfer\FileTransfer
+ * @see \Drupal\Core\FileTransfer\FileTransfer
  * @see hook_filetransfer_info()
  * @see hook_filetransfer_info_alter()
  */

core/includes/config.inc

@@ -102,7 +102,7 @@ function config_uninstall_default_config($type, $name) {
 /**
  * Gets configuration object names starting with a given prefix.
  *
- * @see Drupal\Core\Config\StorageInterface::listAll()
+ * @see \Drupal\Core\Config\StorageInterface::listAll()
  */
 function config_get_storage_names_with_prefix($prefix = '') {
   return drupal_container()->get('config.storage')->listAll($prefix);
@@ -123,7 +123,7 @@ function config_get_storage_names_with_prefix($prefix = '') {
  *   config object returned will contain the contents of book.admin
  *   configuration file.
  *
- * @return Drupal\Core\Config\Config
+ * @return \Drupal\Core\Config\Config
  *   A configuration object.
  */
 function config($name) {
@@ -219,9 +219,9 @@ function config_get_entity_type_by_name($name) {
  *
  * Use the typed data manager service for creating typed configuration objects.
  *
- * @see Drupal\Core\TypedData\TypedDataManager::create()
+ * @see \Drupal\Core\TypedData\TypedDataManager::create()
  *
- * @return Drupal\Core\TypedData\TypedConfigManager
+ * @return \Drupal\Core\TypedData\TypedConfigManager
  */
 function config_typed() {
   return drupal_container()->get('config.typed');
@@ -230,9 +230,9 @@ function config_typed() {
 /**
  * Creates a configuration snapshot following a successful import.
  *
- * @param Drupal\Core\Config\StorageInterface $source_storage
+ * @param \Drupal\Core\Config\StorageInterface $source_storage
  *   The storage to synchronize configuration from.
- * @param Drupal\Core\Config\StorageInterface $snapshot_storage
+ * @param \Drupal\Core\Config\StorageInterface $snapshot_storage
  *   The storage to synchronize configuration to.
  */
 function config_import_create_snapshot(StorageInterface $source_storage, StorageInterface $snapshot_storage) {
@@ -245,9 +245,9 @@ function config_import_create_snapshot(StorageInterface $source_storage, Storage
 /**
  * Return a formatted diff of a named config between two storages.
  *
- * @param Drupal\Core\Config\StorageInterface $source_storage
+ * @param \Drupal\Core\Config\StorageInterface $source_storage
  *   The storage to diff configuration from.
- * @param Drupal\Core\Config\StorageInterface $target_storage
+ * @param \Drupal\Core\Config\StorageInterface $target_storage
  *   The storage to diff configuration to.
  * @param string $name
  *   The name of the configuration object to diff.

core/includes/entity.inc

@@ -192,7 +192,7 @@ function entity_get_view_modes($entity_type = NULL) {
  * @param bool $reset
  *   Whether to reset the internal cache for the requested entity type.
  *
- * @return Drupal\Core\Entity\EntityInterface
+ * @return \Drupal\Core\Entity\EntityInterface
  *   The entity object, or NULL if there is no entity with the given id.
  *
  * @see \Drupal\Core\Entity\EntityManager
@@ -216,7 +216,7 @@ function entity_load($entity_type, $id, $reset = FALSE) {
  * @param int $revision_id
  *   The id of the entity to load.
  *
- * @return Drupal\Core\Entity\EntityInterface
+ * @return \Drupal\Core\Entity\EntityInterface
  *   The entity object, or FALSE if there is no entity with the given revision
  *   id.
  *
@@ -259,7 +259,7 @@ function entity_revision_delete($entity_type, $revision_id) {
  * @return EntityInterface|FALSE
  *   The entity object, or FALSE if there is no entity with the given UUID.
  *
- * @throws Drupal\Core\Entity\EntityStorageException
+ * @throws \Drupal\Core\Entity\EntityStorageException
  *   Thrown in case the requested entity type does not support UUIDs.
  *
  * @see \Drupal\Core\Entity\EntityManager
@@ -383,7 +383,7 @@ function entity_delete_multiple($entity_type, array $ids) {
  *   An array of values to set, keyed by property name. If the entity type has
  *   bundles the bundle key has to be specified.
  *
- * @return Drupal\Core\Entity\EntityInterface
+ * @return \Drupal\Core\Entity\EntityInterface
  *   A new entity object.
  */
 function entity_create($entity_type, array $values) {
@@ -395,7 +395,7 @@ function entity_create($entity_type, array $values) {
 /**
  * Gets the entity controller class for an entity type.
  *
- * @return Drupal\Core\Entity\EntityStorageControllerInterface
+ * @return \Drupal\Core\Entity\EntityStorageControllerInterface
  *
  * @deprecated Use \Drupal\Core\Entity\EntityManager::getStorageController().
  */
@@ -410,7 +410,7 @@ function entity_get_controller($entity_type) {
  * This is a wrapper for Drupal\Core\Entity\EntityInterface::label(). This function
  * should only be used as a callback, e.g. for menu title callbacks.
  *
- * @param Drupal\Core\Entity\EntityInterface $entity
+ * @param \Drupal\Core\Entity\EntityInterface $entity
  *   The entity for which to generate the label.
  * @param $langcode
  *   (optional) The language code of the language that should be used for
@@ -420,7 +420,7 @@ function entity_get_controller($entity_type) {
  * @return
  *   The label of the entity, or NULL if there is no label defined.
  *
- * @see Drupal\Core\Entity\EntityInterface::label()
+ * @see \Drupal\Core\Entity\EntityInterface::label()
  */
 function entity_page_label(EntityInterface $entity, $langcode = NULL) {
   return $entity->label($langcode);
@@ -460,7 +460,7 @@ function entity_access_controller($entity_type) {
  *   identifying the controlled form. Defaults to 'default' which is the usual
  *   create/edit form.
  *
- * @return Drupal\Core\Entity\EntityFormControllerInterface
+ * @return \Drupal\Core\Entity\EntityFormControllerInterface
  *   An entity form controller instance.
  *
  * @deprecated Use \Drupal\Core\Entity\EntityManager::getFormController().
@@ -541,7 +541,7 @@ function entity_get_form(EntityInterface $entity, $operation = 'default', array
  * @param string $entity_type
  *   The type of the entity.
  *
- * @return Drupal\Core\Entity\EntityListControllerInterface
+ * @return \Drupal\Core\Entity\EntityListControllerInterface
  *   An entity list controller.
  *
  * @deprecated Use \Drupal\Core\Entity\EntityManager::getFormController().
@@ -557,7 +557,7 @@ function entity_list_controller($entity_type) {
  * @param string $entity_type
  *   The type of the entity.
  *
- * @return Drupal\Core\Entity\EntityRenderControllerInterface
+ * @return \Drupal\Core\Entity\EntityRenderControllerInterface
  *   An entity render controller.
  *
  * @deprecated Use \Drupal\Core\Entity\EntityManager::getFormController().
@@ -570,7 +570,7 @@ function entity_render_controller($entity_type) {
 /**
  * Returns the render array for an entity.
  *
- * @param Drupal\Core\Entity\EntityInterface $entity
+ * @param \Drupal\Core\Entity\EntityInterface $entity
  *   The entity to be rendered.
  * @param string $view_mode
  *   The view mode that should be used to display the entity.

core/includes/file.inc

@@ -1350,7 +1350,7 @@ function drupal_unlink($uri, $context = NULL) {
  * @return string|false
  *   The absolute local filepath (with no symbolic links), or FALSE on failure.
  *
- * @see Drupal\Core\StreamWrapper\StreamWrapperInterface::realpath()
+ * @see \Drupal\Core\StreamWrapper\StreamWrapperInterface::realpath()
  * @see http://php.net/manual/function.realpath.php
  * @ingroup php_wrappers
  */

core/includes/install.core.inc

@@ -1467,7 +1467,7 @@ function install_find_translations() {
 /**
  * Build a file translation service for installation.
  *
- * @return Drupal\Core\StringTranslation\Translator\FileTranslation
+ * @return \Drupal\Core\StringTranslation\Translator\FileTranslation
  *   File translation service for the installer.
  */
 function install_file_translation_service() {

core/includes/mail.inc

@@ -206,7 +206,7 @@ function drupal_mail($module, $key, $to, $langcode, $params = array(), $from = N
  *   A key to identify the e-mail sent. The final e-mail ID for the e-mail
  *   alter hook in drupal_mail() would have been {$module}_{$key}.
  *
- * @return Drupal\Core\Mail\MailInterface
+ * @return \Drupal\Core\Mail\MailInterface
  *   An object that implements Drupal\Core\Mail\MailInterface.
  *
  * @throws \Exception

core/includes/module.inc

@@ -321,7 +321,7 @@ function module_set_weight($module, $weight) {
       ->save();
 
     // Prepare the new module list, sorted by weight, including filenames.
-    // @see Drupal\Core\Extension\ModuleHandler::install()
+    // @see \Drupal\Core\Extension\ModuleHandler::install()
     $module_handler = \Drupal::moduleHandler();
     $current_module_filenames = $module_handler->getModuleList();
     $current_modules = array_fill_keys(array_keys($current_module_filenames), 0);

core/includes/update.inc

@@ -1054,7 +1054,7 @@ function update_get_update_list() {
  *   - 'module': The name of the module that this update function belongs to.
  *   - 'number': The number of this update function within that module.
  *
- * @see Drupal\Component\Graph\Graph::searchAndSort()
+ * @see \Drupal\Component\Graph\Graph::searchAndSort()
  */
 function update_resolve_dependencies($starting_updates) {
   // Obtain a dependency graph for the requested update functions.
@@ -1170,7 +1170,7 @@ function update_get_update_function_list($starting_updates) {
  *   - 'module': The name of the module that this update function belongs to.
  *   - 'number': The number of this update function within that module.
  *
- * @see Drupal\Component\Graph\Graph::searchAndSort()
+ * @see \Drupal\Component\Graph\Graph::searchAndSort()
  * @see update_resolve_dependencies()
  */
 function update_build_dependency_graph($update_functions) {

core/lib/Drupal/Component/Archiver/ArchiverInterface.php

@@ -19,7 +19,7 @@ interface ArchiverInterface {
    *   The full system path of the file or directory to add. Only local files
    *   and directories are supported.
    *
-   * @return Drupal\Component\Archiver\ArchiverInterface
+   * @return \Drupal\Component\Archiver\ArchiverInterface
    *   The called object.
    */
   public function add($file_path);
@@ -30,7 +30,7 @@ public function add($file_path);
    * @param string $path
    *   The file name relative to the root of the archive to remove.
    *
-   * @return Drupal\Component\Archiver\ArchiverInterface
+   * @return \Drupal\Component\Archiver\ArchiverInterface
    *   The called object.
    */
   public function remove($path);
@@ -45,7 +45,7 @@ public function remove($path);
    *   relative to the root of the archive. If not specified, all files
    *   in the archive will be extracted.
    *
-   * @return Drupal\Component\Archiver\ArchiverInterface
+   * @return \Drupal\Component\Archiver\ArchiverInterface
    *   The called object.
    */
   public function extract($path, array $files = array());

core/lib/Drupal/Component/Archiver/Tar.php

@@ -15,7 +15,7 @@ class Tar implements ArchiverInterface {
   /**
    * The underlying ArchiveTar instance that does the heavy lifting.
    *
-   * @var Drupal\Component\Archiver\ArchiveTar
+   * @var \Drupal\Component\Archiver\ArchiveTar
    */
   protected $tar;
 
@@ -27,7 +27,7 @@ class Tar implements ArchiverInterface {
    *   are supported. If the file does not yet exist, it will be created if
    *   appropriate.
    *
-   * @throws Drupal\Component\Archiver\ArchiverException
+   * @throws \Drupal\Component\Archiver\ArchiverException
    */
   public function __construct($file_path) {
     $this->tar = new ArchiveTar($file_path);

core/lib/Drupal/Component/Archiver/Zip.php

@@ -29,7 +29,7 @@ class Zip implements ArchiverInterface {
    *   are supported. If the file does not yet exist, it will be created if
    *   appropriate.
    *
-   * @throws Drupal\Component\Archiver\ArchiverException
+   * @throws \Drupal\Component\Archiver\ArchiverException
    */
   public function __construct($file_path) {
     $this->zip = new \ZipArchive();

core/lib/Drupal/Component/Gettext/PoMetadataInterface.php

@@ -12,8 +12,8 @@
 /**
  * Methods required for both reader and writer implementations.
  *
- * @see Drupal\Component\Gettext\PoReaderInterface
- * @see Drupal\Component\Gettext\PoWriterInterface
+ * @see \Drupal\Component\Gettext\PoReaderInterface
+ * @see \Drupal\Component\Gettext\PoWriterInterface
  */
 interface PoMetadataInterface {
 
@@ -36,7 +36,7 @@ public function getLangcode();
   /**
    * Set header metadata.
    *
-   * @param Drupal\Component\Gettext\PoHeader $header
+   * @param \Drupal\Component\Gettext\PoHeader $header
    *   Header object representing metadata in a PO header.
    */
   public function setHeader(PoHeader $header);
@@ -44,7 +44,7 @@ public function setHeader(PoHeader $header);
   /**
    * Get header metadata.
    *
-   * @return Drupal\Component\Gettext\PoHeader $header
+   * @return \Drupal\Component\Gettext\PoHeader $header
    *   Header instance representing metadata in a PO header.
    */
   public function getHeader();

core/lib/Drupal/Component/Gettext/PoReaderInterface.php

@@ -17,7 +17,7 @@ interface PoReaderInterface extends PoMetadataInterface {
   /**
    * Reads and returns a PoItem (source/translation pair).
    *
-   * @return Drupal\Component\Gettext\PoItem
+   * @return \Drupal\Component\Gettext\PoItem
    *   Wrapper for item data instance.
    */
   public function readItem();

core/lib/Drupal/Component/Gettext/PoStreamReader.php

@@ -87,14 +87,14 @@ class PoStreamReader implements PoStreamInterface, PoReaderInterface {
   /**
    * The PO stream header.
    *
-   * @var Drupal\Component\Gettext\PoHeader
+   * @var \Drupal\Component\Gettext\PoHeader
    */
   private $_header;
 
   /**
    * Object wrapper for the last read source/translation pair.
    *
-   * @var Drupal\Component\Gettext\PoItem
+   * @var \Drupal\Component\Gettext\PoItem
    */
   private $_last_item;
 

core/lib/Drupal/Component/Gettext/PoStreamWriter.php

@@ -28,7 +28,7 @@ class PoStreamWriter implements PoWriterInterface, PoStreamInterface {
   /**
    * The Gettext PO header.
    *
-   * @var Drupal\Component\Gettext\PoHeader
+   * @var \Drupal\Component\Gettext\PoHeader
    */
   private $_header;
 
@@ -42,7 +42,7 @@ class PoStreamWriter implements PoWriterInterface, PoStreamInterface {
   /**
    * Get the PO header of the current stream.
    *
-   * @return Drupal\Component\Gettext\PoHeader
+   * @return \Drupal\Component\Gettext\PoHeader
    *   The Gettext PO header.
    */
   public function getHeader() {
@@ -52,7 +52,7 @@ public function getHeader() {
   /**
    * Set the PO header for the current stream.
    *
-   * @param Drupal\Component\Gettext\PoHeader $header
+   * @param \Drupal\Component\Gettext\PoHeader $header
    *   The Gettext PO header to set.
    */
   public function setHeader(PoHeader $header) {

core/lib/Drupal/Component/Graph/Graph.php

@@ -101,7 +101,7 @@ public function searchAndSort() {
    * @param $component
    *   The component of the last vertex.
    *
-   * @see Drupal\Component\Graph\Graph::searchAndSort()
+   * @see \Drupal\Component\Graph\Graph::searchAndSort()
    */
   protected function depthFirstSearch(&$state, $start, &$component = NULL) {
     // Assign new component for each new vertex, i.e. when not called recursively.

core/lib/Drupal/Component/Plugin/Discovery/DerivativeDiscoveryDecorator.php

@@ -133,7 +133,7 @@ protected function encodePluginId($base_plugin_id, $derivative_id) {
    * @param array $base_definition
    *   The base plugin definition to build derivatives.
    *
-   * @return Drupal\Component\Plugin\Discovery\DerivativeInterface|null
+   * @return \Drupal\Component\Plugin\Discovery\DerivativeInterface|null
    *   A DerivativeInterface or null if none exists for the plugin.
    */
   protected function getDerivativeFetcher($base_plugin_id, array $base_definition) {

core/lib/Drupal/Component/Plugin/Factory/DefaultFactory.php

@@ -26,7 +26,7 @@ class DefaultFactory implements FactoryInterface {
    * The plugin definition includes the plugin class and possibly other
    * information necessary for proper instantiation.
    *
-   * @var Drupal\Component\Plugin\Discovery\DiscoveryInterface
+   * @var \Drupal\Component\Plugin\Discovery\DiscoveryInterface
    */
   protected $discovery;