From 3af57f41b44726c0b7924a6d5fa75e102248970c Mon Sep 17 00:00:00 2001
From: catch <catch56@gmail.com>
Date: Wed, 2 Nov 2022 14:54:34 +0000
Subject: [PATCH] Issue #3317658 by pooja saraah, mondrake, ravi.shankar,
longwave: Fix HoldTestSubscriber PHPStan L0 issues
(cherry picked from commit 08b0f54bf453d2746db9d5a373cfa48c8fb85740)
---
.../hold_test/src/EventSubscriber/HoldTestSubscriber.php | 6 +++---
core/phpstan-baseline.neon | 5 -----
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/core/modules/system/tests/modules/hold_test/src/EventSubscriber/HoldTestSubscriber.php b/core/modules/system/tests/modules/hold_test/src/EventSubscriber/HoldTestSubscriber.php
index 523e257f7004..5ccb0ecb648c 100644
--- a/core/modules/system/tests/modules/hold_test/src/EventSubscriber/HoldTestSubscriber.php
+++ b/core/modules/system/tests/modules/hold_test/src/EventSubscriber/HoldTestSubscriber.php
@@ -59,9 +59,9 @@ public function onRespond() {
*/
protected function hold($type) {
$path = "{$this->sitePath}/hold_test_$type.txt";
- do {
- $status = (bool) file_get_contents($path);
- } while ($status && (NULL === usleep(static::WAIT)));
+ while ((bool) file_get_contents($path)) {
+ usleep(static::WAIT);
+ }
}
/**
diff --git a/core/phpstan-baseline.neon b/core/phpstan-baseline.neon
index 5f75f0eec7ef..747860ed73e4 100644
--- a/core/phpstan-baseline.neon
+++ b/core/phpstan-baseline.neon
@@ -1095,11 +1095,6 @@ parameters:
count: 1
path: modules/system/tests/modules/entity_test/src/Plugin/Field/FieldType/ChangedTestItem.php
- -
- message: "#^Result of function usleep \\(void\\) is used\\.$#"
- count: 1
- path: modules/system/tests/modules/hold_test/src/EventSubscriber/HoldTestSubscriber.php
-
-
message: "#^Configuration entity must define a `config_export` key\\. See https\\://www\\.drupal\\.org/node/2481909$#"
count: 1
--
GitLab