#392494 follow-up by yched: Clean-ups to Field API scalar search patch.

modules/field/field.attach.inc

@@ -833,7 +833,7 @@ function field_attach_query($field_name, $conditions, $result_format = FIELD_QUE
         // are therefore called on each object separately, which might cause
         // performance issues when large numbers of revisions are retrieved.
         foreach ($pseudo_objects as $vid => $pseudo_object) {
-          list($id) = _field_attach_extract_ids($obj_type, $pseudo_object);
+          list($id) = field_attach_extract_ids($obj_type, $pseudo_object);
           $objects = array($id => $pseudo_object);
 
           // Invoke hook_field_load().

modules/field/field.test

@@ -467,8 +467,6 @@ class FieldAttachTestCase extends DrupalWebTestCase {
       ),
     );
     $this->assertEqual($result, $expected, t('FIELD_QUERY_RETURN_VALUES result format returns the expect result'));
-
-    // TODO : test
   }
 
   function testFieldAttachViewAndPreprocess() {

modules/field/modules/field_sql_storage/field_sql_storage.module

@@ -384,10 +384,6 @@ function field_sql_storage_field_storage_query($field_name, $conditions, $result
     @list($column, $value, $operator) = $condition;
     // Translate operator and value if needed.
     switch ($operator) {
-      case NULL:
-        $operator = is_array($value) ? 'IN' : '=';
-        break;
-
       case 'STARTS_WITH':
         $operator = 'LIKE';
         $value .= '%';