Issue #3097822 by mondrake, Lendude: Drupal\migrate_drupal\Tests\StubTestTrait...

Issue #3097822 by mondrake, Lendude: Drupal\migrate_drupal\Tests\StubTestTrait is not compatible with PHPUnit 8

(cherry picked from commit a5876a27)

core/modules/block_content/tests/src/Kernel/Migrate/MigrateBlockContentStubTest.php

@@ -35,7 +35,7 @@ protected function setUp() {
   public function testStubFailure() {
     $message = 'Expected MigrateException thrown when no bundles exist.';
     try {
-      $this->createStub('block_content');
+      $this->createEntityStub('block_content');
       $this->fail($message);
     }
     catch (MigrateException $e) {

core/modules/migrate_drupal/src/Tests/StubTestTrait.php

@@ -17,7 +17,7 @@ trait StubTestTrait {
    *   The entity type we are stubbing.
    */
   protected function performStubTest($entity_type_id) {
-    $entity_id = $this->createStub($entity_type_id);
+    $entity_id = $this->createEntityStub($entity_type_id);
     $this->assertNotEmpty($entity_id, 'Stub successfully created');
     if ($entity_id) {
       $violations = $this->validateStub($entity_type_id, $entity_id);
@@ -38,7 +38,7 @@ protected function performStubTest($entity_type_id) {
    * @return int
    *   ID of the created entity.
    */
-  protected function createStub($entity_type_id) {
+  protected function createEntityStub($entity_type_id) {
     // Create a dummy migration to pass to the destination plugin.
     $definition = [
       'migration_tags' => ['Stub test'],