Issue #2379683 by Gábor Hojtsy: Fix configuration schema issues in contact...

Issue #2379683 by Gábor Hojtsy: Fix configuration schema issues in contact (indirectly user and system) modules

core/modules/contact/src/Tests/ContactPersonalTest.php

@@ -18,6 +18,15 @@
  */
 class ContactPersonalTest extends WebTestBase {
 
+  /**
+   * Set to TRUE to strict check all configuration saved.
+   *
+   * @see \Drupal\Core\Config\Testing\ConfigSchemaChecker
+   *
+   * @var bool
+   */
+  protected $strictConfigSchema = TRUE;
+
   /**
    * Modules to enable.
    *

core/modules/contact/src/Tests/ContactSitewideTest.php

@@ -20,6 +20,15 @@
  */
 class ContactSitewideTest extends WebTestBase {
 
+  /**
+   * Set to TRUE to strict check all configuration saved.
+   *
+   * @see \Drupal\Core\Config\Testing\ConfigSchemaChecker
+   *
+   * @var bool
+   */
+  protected $strictConfigSchema = TRUE;
+
   /**
    * Modules to enable.
    *

core/modules/contact/src/Tests/ContactStorageTest.php

@@ -8,7 +8,6 @@
 namespace Drupal\contact\Tests;
 
 use Drupal\Component\Utility\Unicode;
-use Drupal\config\Tests\SchemaCheckTestTrait;
 use Drupal\contact\Entity\Message;
 
 /**
@@ -16,8 +15,6 @@
  */
 class ContactStorageTest extends ContactSitewideTest {
 
-  use SchemaCheckTestTrait;
-
   /**
    * Modules to enable.
    *
@@ -79,7 +76,6 @@ public function testContactStorage() {
 
     $config = \Drupal::config("contact.form.$id");
     $this->assertEqual($config->get('id'), $id);
-    $this->assertConfigSchema(\Drupal::service('config.typed'), $config->getName(), $config->get());
   }
 
 }

core/modules/contact/src/Tests/Views/ContactLinkTest.php

@@ -18,6 +18,15 @@
  */
 class ContactLinkTest extends ViewTestBase {
 
+  /**
+   * Set to TRUE to strict check all configuration saved.
+   *
+   * @see \Drupal\Core\Config\Testing\ConfigSchemaChecker
+   *
+   * @var bool
+   */
+  protected $strictConfigSchema = TRUE;
+
   /**
    * Stores the user data service used by the test.
    *

core/modules/contact/tests/modules/contact_test_views/test_views/views.view.test_contact_link.yml

@@ -101,6 +101,7 @@ display:
           hide_alter_empty: true
           anonymous_text: ''
           format_username: true
+          plugin_id: user_name
         contact:
           id: contact
           table: users
@@ -116,6 +117,7 @@ display:
           expose:
             operator: '0'
           group: 1
+          plugin_id: boolean
       sorts: {  }
       title: test_contact_link
       header: {  }

core/modules/system/config/schema/system.schema.yml

@@ -38,6 +38,9 @@ system.site:
     langcode:
       type: string
       label: 'Default language'
+    mail_notification:
+      type: string
+      label: 'Notification email address'
 
 system.maintenance:
   type: mapping

core/modules/user/config/install/user.settings.yml

@@ -6,7 +6,7 @@ notify:
   password_reset: true
   status_activated: true
   status_blocked: false
-  status_cancelled: false
+  status_canceled: false
   register_admin_created: true
   register_no_approval_required: true
   register_pending_approval: true

core/modules/user/config/schema/user.schema.yml

@@ -29,7 +29,7 @@ user.settings:
         status_blocked:
           type: boolean
           label: 'Account blocked'
-        status_cancelled:
+        status_canceled:
           type: boolean
           label: 'Account canceled'
         register_admin_created: