Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
project
drupal
Commits
24343f97
Commit
24343f97
authored
Aug 13, 2016
by
alexpott
Browse files
Issue
#2763283
by naught101, thomas73: Failure on comments with no subject
parent
0c0481ef
Changes
2
Hide whitespace changes
Inline
Side-by-side
core/modules/comment/src/Plugin/migrate/source/d6/CommentVariablePerCommentType.php
View file @
24343f97
...
...
@@ -20,7 +20,7 @@ protected function getCommentVariables() {
$return
=
array
();
foreach
(
$node_types
as
$node_type
=>
$data
)
{
// Only 2 comment types depending on subject field visibility.
if
(
empty
(
$data
[
'comment_subject_field'
]))
{
if
(
!
empty
(
$data
[
'comment_subject_field'
]))
{
// Default label and description should be set in migration.
$return
[
'comment'
]
=
array
(
'comment_type'
=>
'comment'
,
...
...
core/modules/comment/tests/src/Unit/Migrate/d6/CommentVariablePerCommentTypeTest.php
View file @
24343f97
...
...
@@ -24,10 +24,10 @@ class CommentVariablePerCommentTypeTest extends MigrateSqlSourceTestCase {
// Each result will also include a label and description, but those are
// static values set by the source plugin and don't need to be asserted.
array
(
'comment_type'
=>
'comment
_no_subject
'
,
'comment_type'
=>
'comment'
,
),
array
(
'comment_type'
=>
'comment'
,
'comment_type'
=>
'comment
_no_subject
'
,
),
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment