From 1b87d95eaf1ce1971d4b60415892c685120f671f Mon Sep 17 00:00:00 2001 From: Alex Pott <alex.a.pott@googlemail.com> Date: Thu, 8 Mar 2018 14:19:28 +0000 Subject: [PATCH] Issue #2949378 by masipila, heddn, phenaproxima: Document that SqlBase source plugin must use the ignore_map configuraition option if expressions are used in the query --- core/modules/migrate/src/Plugin/migrate/source/SqlBase.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/core/modules/migrate/src/Plugin/migrate/source/SqlBase.php b/core/modules/migrate/src/Plugin/migrate/source/SqlBase.php index 91bbcb4cf6b6..b9e8e731ab6b 100644 --- a/core/modules/migrate/src/Plugin/migrate/source/SqlBase.php +++ b/core/modules/migrate/src/Plugin/migrate/source/SqlBase.php @@ -24,8 +24,11 @@ * - target: (optional) The database target name. Defaults to 'default'. * - batch_size: (optional) Number of records to fetch from the database during * each batch. If omitted, all records are fetched in a single query. - * - ignore_map: (optional) Source data is joined to the map table by default. - * If set to TRUE, the map table will not be joined. + * - ignore_map: (optional) Source data is joined to the map table by default to + * improve migration performance. If set to TRUE, the map table will not be + * joined. Using expressions in the query may result in column aliases in the + * JOIN clause which would be invalid SQL. If you run into this, set + * ignore_map to TRUE. * * For other optional configuration keys inherited from the parent class, refer * to \Drupal\migrate\Plugin\migrate\source\SourcePluginBase. -- GitLab