Commit 1220c071 authored by xjm's avatar xjm

Issue #2937844 by andypost, ravi.shankar, mrinalini9, Deepak Goyal, RoSk0,...

Issue #2937844 by andypost, ravi.shankar, mrinalini9, Deepak Goyal, RoSk0, daffie, borisson_, tstoeckler, xjm: Fix 'Squiz.PHP.NonExecutableCode' coding standard
parent 0334414b
...@@ -506,8 +506,6 @@ private function readLine() { ...@@ -506,8 +506,6 @@ private function readLine() {
$this->errors[] = new FormattableMarkup('The translation stream %uri ended unexpectedly at line %line.', $log_vars); $this->errors[] = new FormattableMarkup('The translation stream %uri ended unexpectedly at line %line.', $log_vars);
return FALSE; return FALSE;
} }
return;
} }
/** /**
......
...@@ -176,7 +176,6 @@ protected function openBrowser($url, SymfonyStyle $io) { ...@@ -176,7 +176,6 @@ protected function openBrowser($url, SymfonyStyle $io) {
$php = "<?php sleep(2); passthru(\"$cmd\"); ?>"; $php = "<?php sleep(2); passthru(\"$cmd\"); ?>";
$process = new PhpProcess($php); $process = new PhpProcess($php);
$process->start(); $process->start();
return;
} }
/** /**
......
...@@ -49,9 +49,7 @@ public function rowCount() { ...@@ -49,9 +49,7 @@ public function rowCount() {
/** /**
* {@inheritdoc} * {@inheritdoc}
*/ */
public function setFetchMode($mode, $a1 = NULL, $a2 = []) { public function setFetchMode($mode, $a1 = NULL, $a2 = []) {}
return;
}
/** /**
* {@inheritdoc} * {@inheritdoc}
......
...@@ -232,9 +232,7 @@ public function render() { ...@@ -232,9 +232,7 @@ public function render() {
/** /**
* Gets the title of the page. * Gets the title of the page.
*/ */
protected function getTitle() { protected function getTitle() {}
return;
}
/** /**
* Ensures that a destination is present on the given URL. * Ensures that a destination is present on the given URL.
......
...@@ -29,5 +29,4 @@ function _config_import_test_config_import_steps_alter(&$context, ConfigImporter ...@@ -29,5 +29,4 @@ function _config_import_test_config_import_steps_alter(&$context, ConfigImporter
$config_importer->logError('_config_import_test_config_import_steps_alter ConfigImporter error'); $config_importer->logError('_config_import_test_config_import_steps_alter ConfigImporter error');
} }
$context['finished'] = 1; $context['finished'] = 1;
return;
} }
...@@ -60,8 +60,6 @@ public function isFile($path) { ...@@ -60,8 +60,6 @@ public function isFile($path) {
return FALSE; return FALSE;
} }
public function chmodJailed($path, $mode, $recursive) { public function chmodJailed($path, $mode, $recursive) {}
return;
}
} }
...@@ -349,6 +349,7 @@ ...@@ -349,6 +349,7 @@
<severity>0</severity> <severity>0</severity>
</rule> </rule>
<rule ref="Squiz.PHP.LowercasePHPFunctions"/> <rule ref="Squiz.PHP.LowercasePHPFunctions"/>
<rule ref="Squiz.PHP.NonExecutableCode"/>
<rule ref="Squiz.Strings.ConcatenationSpacing"> <rule ref="Squiz.Strings.ConcatenationSpacing">
<properties> <properties>
<property name="spacing" value="1"/> <property name="spacing" value="1"/>
......
...@@ -48,7 +48,6 @@ protected function prepareEnvironment() { ...@@ -48,7 +48,6 @@ protected function prepareEnvironment() {
*/ */
protected function setUpSettings() { protected function setUpSettings() {
// This form will never be reached. // This form will never be reached.
return;
} }
/** /**
...@@ -56,7 +55,6 @@ protected function setUpSettings() { ...@@ -56,7 +55,6 @@ protected function setUpSettings() {
*/ */
protected function setUpSite() { protected function setUpSite() {
// This form will never be reached. // This form will never be reached.
return;
} }
/** /**
......
...@@ -21,7 +21,6 @@ class InstallerExistingConfigNoConfigTest extends InstallerExistingConfigTestBas ...@@ -21,7 +21,6 @@ class InstallerExistingConfigNoConfigTest extends InstallerExistingConfigTestBas
*/ */
protected function setUpSite() { protected function setUpSite() {
// There are errors therefore there is nothing to do here. // There are errors therefore there is nothing to do here.
return;
} }
/** /**
......
...@@ -22,7 +22,7 @@ protected function prepareEnvironment() { ...@@ -22,7 +22,7 @@ protected function prepareEnvironment() {
* {@inheritdoc} * {@inheritdoc}
*/ */
public function setUpSite() { public function setUpSite() {
return; // There are are errors. Therefore, there is nothing to do here.
} }
/** /**
......
...@@ -32,7 +32,6 @@ function config_profile_with_hook_install_install() { ...@@ -32,7 +32,6 @@ function config_profile_with_hook_install_install() {
*/ */
protected function setUpSettings() { protected function setUpSettings() {
// There are errors therefore there is nothing to do here. // There are errors therefore there is nothing to do here.
return;
} }
/** /**
...@@ -40,7 +39,6 @@ protected function setUpSettings() { ...@@ -40,7 +39,6 @@ protected function setUpSettings() {
*/ */
protected function setUpSite() { protected function setUpSite() {
// There are errors therefore there is nothing to do here. // There are errors therefore there is nothing to do here.
return;
} }
/** /**
......
...@@ -46,7 +46,6 @@ function testing_config_install_multilingual_install() { ...@@ -46,7 +46,6 @@ function testing_config_install_multilingual_install() {
protected function setUpProfile() { protected function setUpProfile() {
// This is the form we are testing so wait until the test method to do // This is the form we are testing so wait until the test method to do
// assertions. // assertions.
return;
} }
/** /**
...@@ -54,7 +53,6 @@ protected function setUpProfile() { ...@@ -54,7 +53,6 @@ protected function setUpProfile() {
*/ */
protected function setUpRequirementsProblem() { protected function setUpRequirementsProblem() {
// This form will never be reached. // This form will never be reached.
return;
} }
/** /**
...@@ -62,7 +60,6 @@ protected function setUpRequirementsProblem() { ...@@ -62,7 +60,6 @@ protected function setUpRequirementsProblem() {
*/ */
protected function setUpSettings() { protected function setUpSettings() {
// This form will never be reached. // This form will never be reached.
return;
} }
/** /**
...@@ -70,7 +67,6 @@ protected function setUpSettings() { ...@@ -70,7 +67,6 @@ protected function setUpSettings() {
*/ */
protected function setUpSite() { protected function setUpSite() {
// This form will never be reached. // This form will never be reached.
return;
} }
/** /**
......
...@@ -42,7 +42,6 @@ protected function setUpSettings() { ...@@ -42,7 +42,6 @@ protected function setUpSettings() {
protected function setUpSite() { protected function setUpSite() {
// This step will not occur because there is an error. // This step will not occur because there is an error.
return;
} }
/** /**
......
...@@ -67,9 +67,7 @@ public function databaseType() { ...@@ -67,9 +67,7 @@ public function databaseType() {
/** /**
* {@inheritdoc} * {@inheritdoc}
*/ */
public function createDatabase($database) { public function createDatabase($database) {}
return;
}
/** /**
* {@inheritdoc} * {@inheritdoc}
......
...@@ -49,9 +49,7 @@ public function databaseType() { ...@@ -49,9 +49,7 @@ public function databaseType() {
/** /**
* {@inheritdoc} * {@inheritdoc}
*/ */
public function createDatabase($database) { public function createDatabase($database) {}
return;
}
/** /**
* {@inheritdoc} * {@inheritdoc}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment