From 0f4319e4182dc28867e366d5407592d883d1d830 Mon Sep 17 00:00:00 2001
From: Alex Pott <alex.a.pott@googlemail.com>
Date: Wed, 8 Jul 2015 11:55:40 +0100
Subject: [PATCH] Issue #2528292 by Fabianx, dawehner: Decouple Error testing
from relying on a cached on disk-container that is created by a different
Kernel
---
core/lib/Drupal/Core/DrupalKernel.php | 5 ++--
.../System/ErrorContainerRebuildKernel.php | 22 ----------------
.../ExceptionContainerRebuildKernel.php | 22 ----------------
.../Tests/System/UncaughtExceptionTest.php | 26 ++++++++++++++-----
sites/default/default.settings.php | 9 +++++++
5 files changed, 31 insertions(+), 53 deletions(-)
delete mode 100644 core/modules/system/src/Tests/System/ErrorContainerRebuildKernel.php
delete mode 100644 core/modules/system/src/Tests/System/ExceptionContainerRebuildKernel.php
diff --git a/core/lib/Drupal/Core/DrupalKernel.php b/core/lib/Drupal/Core/DrupalKernel.php
index 0f103e67cd3d..6a5ce77e1f71 100644
--- a/core/lib/Drupal/Core/DrupalKernel.php
+++ b/core/lib/Drupal/Core/DrupalKernel.php
@@ -52,8 +52,6 @@
*/
class DrupalKernel implements DrupalKernelInterface, TerminableInterface {
- const CONTAINER_BASE_CLASS = '\Drupal\Core\DependencyInjection\Container';
-
/**
* Holds the container instance.
*
@@ -815,7 +813,8 @@ protected function initializeContainer() {
\Drupal::setContainer($this->container);
// If needs dumping flag was set, dump the container.
- if ($this->containerNeedsDumping && !$this->dumpDrupalContainer($this->container, static::CONTAINER_BASE_CLASS)) {
+ $base_class = Settings::get('container_base_class', '\Drupal\Core\DependencyInjection\Container');
+ if ($this->containerNeedsDumping && !$this->dumpDrupalContainer($this->container, $base_class)) {
$this->container->get('logger.factory')->get('DrupalKernel')->notice('Container cannot be written to disk');
}
diff --git a/core/modules/system/src/Tests/System/ErrorContainerRebuildKernel.php b/core/modules/system/src/Tests/System/ErrorContainerRebuildKernel.php
deleted file mode 100644
index 8e8db22ef720..000000000000
--- a/core/modules/system/src/Tests/System/ErrorContainerRebuildKernel.php
+++ /dev/null
@@ -1,22 +0,0 @@
-<?php
-
-/**
- * @file
- * Contains \Drupal\system\Tests\System\ErrorContainerRebuildKernel.
- */
-
-namespace Drupal\system\Tests\System;
-
-use Drupal\Core\DrupalKernel;
-
-/**
- * A kernel which produces a container which triggers an error.
- */
-class ErrorContainerRebuildKernel extends DrupalKernel {
-
- /**
- * {@inheritdoc}
- */
- const CONTAINER_BASE_CLASS = '\Drupal\system\Tests\Bootstrap\ErrorContainer';
-
-}
diff --git a/core/modules/system/src/Tests/System/ExceptionContainerRebuildKernel.php b/core/modules/system/src/Tests/System/ExceptionContainerRebuildKernel.php
deleted file mode 100644
index 9460b7506641..000000000000
--- a/core/modules/system/src/Tests/System/ExceptionContainerRebuildKernel.php
+++ /dev/null
@@ -1,22 +0,0 @@
-<?php
-
-/**
- * @file
- * Contains \Drupal\system\Tests\System\ExceptionContainerRebuildKernel.
- */
-
-namespace Drupal\system\Tests\System;
-
-use Drupal\Core\DrupalKernel;
-
-/**
- * A kernel which produces a container which triggers an exception.
- */
-class ExceptionContainerRebuildKernel extends DrupalKernel {
-
- /**
- * {@inheritdoc}
- */
- const CONTAINER_BASE_CLASS = '\Drupal\system\Tests\Bootstrap\ExceptionContainer';
-
-}
diff --git a/core/modules/system/src/Tests/System/UncaughtExceptionTest.php b/core/modules/system/src/Tests/System/UncaughtExceptionTest.php
index 0e78ee88afbc..b5a3b3dcf35a 100644
--- a/core/modules/system/src/Tests/System/UncaughtExceptionTest.php
+++ b/core/modules/system/src/Tests/System/UncaughtExceptionTest.php
@@ -108,10 +108,17 @@ public function testMissingDependency() {
* Tests a container which has an error.
*/
public function testErrorContainer() {
- $kernel = ErrorContainerRebuildKernel::createFromRequest($this->prepareRequestForGenerator(), $this->classLoader, 'prod', TRUE);
- $kernel->rebuildContainer();
+ $settings = [];
+ $settings['settings']['container_base_class'] = (object) [
+ 'value' => '\Drupal\system\Tests\Bootstrap\ErrorContainer',
+ 'required' => TRUE,
+ ];
+ $this->writeSettings($settings);
+
+ // Need to rebuild the container, so the dumped container can be tested
+ // and not the container builder.
+ \Drupal::service('kernel')->rebuildContainer();
- $this->prepareRequestForGenerator();
// Ensure that we don't use the now broken generated container on the test
// process.
\Drupal::setContainer($this->container);
@@ -137,10 +144,17 @@ public function testErrorContainer() {
* Tests a container which has an exception really early.
*/
public function testExceptionContainer() {
- $kernel = ExceptionContainerRebuildKernel::createFromRequest($this->prepareRequestForGenerator(), $this->classLoader, 'prod', TRUE);
- $kernel->rebuildContainer();
+ $settings = [];
+ $settings['settings']['container_base_class'] = (object) [
+ 'value' => '\Drupal\system\Tests\Bootstrap\ExceptionContainer',
+ 'required' => TRUE,
+ ];
+ $this->writeSettings($settings);
+
+ // Need to rebuild the container, so the dumped container can be tested
+ // and not the container builder.
+ \Drupal::service('kernel')->rebuildContainer();
- $this->prepareRequestForGenerator();
// Ensure that we don't use the now broken generated container on the test
// process.
\Drupal::setContainer($this->container);
diff --git a/sites/default/default.settings.php b/sites/default/default.settings.php
index 330cc560e8b3..9ad5cae550b9 100644
--- a/sites/default/default.settings.php
+++ b/sites/default/default.settings.php
@@ -632,6 +632,15 @@
*/
$settings['container_yamls'][] = __DIR__ . '/services.yml';
+/**
+ * Override the default service container class.
+ *
+ * This is useful for example to trace the service container for performance
+ * tracking purposes, for testing a service container with an error condition or
+ * to test a service container that throws an exception.
+ */
+# $settings['container_base_class'] = '\Drupal\Core\DependencyInjection\Container';
+
/**
* Trusted host configuration.
*
--
GitLab