From 0d040d40f1cf2c8395ca94a95e602b90a8be9017 Mon Sep 17 00:00:00 2001
From: catch <6915-catch@users.noreply.drupalcode.org>
Date: Mon, 17 Mar 2025 15:31:51 +0000
Subject: [PATCH] Issue #3507052 by quietone, borisson_, alexpott: Enable
LineLength for core/includes, lib, profiles, recipes and themes
---
core/includes/common.inc | 13 +++++++----
.../Plugin/Factory/DefaultFactory.php | 2 +-
.../Plugin/Factory/ReflectionFactory.php | 2 +-
.../Core/Access/AccessManagerInterface.php | 2 +-
core/lib/Drupal/Core/Access/AccessResult.php | 4 ++--
.../Core/Access/AccessResultForbidden.php | 2 +-
.../Core/Ajax/OpenModalDialogCommand.php | 2 +-
.../Core/Asset/LibraryDiscoveryParser.php | 4 ++--
.../AccountPermissionsCacheContext.php | 2 +-
.../CalculatedCacheContextInterface.php | 2 +-
.../Core/Cache/MemoryCache/LruMemoryCache.php | 4 ++--
.../Core/Config/ConfigManagerInterface.php | 2 +-
.../Core/Config/Entity/ConfigEntityBase.php | 2 +-
core/lib/Drupal/Core/Config/FileStorage.php | 2 +-
core/lib/Drupal/Core/Database/Log.php | 4 +++-
.../Core/Database/Query/SelectInterface.php | 2 +-
core/lib/Drupal/Core/Database/Schema.php | 4 ++--
.../Core/Database/StatementInterface.php | 3 ++-
.../TransactionOutOfOrderException.php | 5 +++-
.../BackwardsCompatibilityClassLoaderPass.php | 2 +-
core/lib/Drupal/Core/DrupalKernel.php | 2 +-
...LastInstalledSchemaRepositoryInterface.php | 2 +-
.../SelectionInterface.php | 2 +-
.../Core/Entity/EntityTypeInterface.php | 4 ++--
.../Entity/EntityTypeListenerInterface.php | 2 +-
.../Entity/Query/ConditionAggregateBase.php | 2 +-
.../ExtensionNameLengthException.php | 2 +-
.../InstallRequirementsInterface.php | 11 +++++----
.../Drupal/Core/Extension/ModuleHandler.php | 4 +++-
...ieldStorageDefinitionListenerInterface.php | 2 +-
core/lib/Drupal/Core/Field/WidgetBase.php | 1 +
core/lib/Drupal/Core/Form/FormState.php | 2 +-
.../Core/Language/LanguageInterface.php | 2 +-
core/lib/Drupal/Core/Routing/UrlGenerator.php | 23 ++++++++++++++-----
.../Drupal/Core/StackMiddleware/Session.php | 2 +-
.../Constraint/UniqueFieldValueValidator.php | 4 +++-
core/phpcs.xml.dist | 8 +++++++
.../demo_umami_content/src/InstallHelper.php | 2 +-
38 files changed, 89 insertions(+), 53 deletions(-)
diff --git a/core/includes/common.inc b/core/includes/common.inc
index 034108b28d83..55603fc67833 100644
--- a/core/includes/common.inc
+++ b/core/includes/common.inc
@@ -84,17 +84,19 @@
const CSS_LAYOUT = -100;
/**
- * The default weight for CSS rules that style design components (and their associated states and themes.)
+ * The default weight for CSS rules that style design components.
+ *
+ * This applies to the associated states and themes of the component.
*/
const CSS_COMPONENT = 0;
/**
- * The default weight for CSS rules that style states and are not included with components.
+ * The default weight for rules that style states not included with components.
*/
const CSS_STATE = 100;
/**
- * The default weight for CSS rules that style themes and are not included with components.
+ * The default weight for rules that style themes not included with components.
*/
const CSS_THEME = 200;
@@ -342,7 +344,10 @@ function show(&$element) {
}
/**
- * Rebuilds the container, flushes all persistent caches, resets all variables, and rebuilds all data structures.
+ * Re-initializes the entire system.
+ *
+ * To re-initialize the system, the container is rebuilt, all persistent caches
+ * are flushed, all variables are reset and all data structures are rebuilt.
*
* At times, it is necessary to re-initialize the entire system to account for
* changed or new code. This function:
diff --git a/core/lib/Drupal/Component/Plugin/Factory/DefaultFactory.php b/core/lib/Drupal/Component/Plugin/Factory/DefaultFactory.php
index b783e402deb6..dafc7ef010da 100644
--- a/core/lib/Drupal/Component/Plugin/Factory/DefaultFactory.php
+++ b/core/lib/Drupal/Component/Plugin/Factory/DefaultFactory.php
@@ -17,7 +17,7 @@
class DefaultFactory implements FactoryInterface {
/**
- * The object that retrieves the definitions of the plugins that this factory instantiates.
+ * The object that gets the plugin definitions that this factory instantiates.
*
* The plugin definition includes the plugin class and possibly other
* information necessary for proper instantiation.
diff --git a/core/lib/Drupal/Component/Plugin/Factory/ReflectionFactory.php b/core/lib/Drupal/Component/Plugin/Factory/ReflectionFactory.php
index 4ce80eeaa21d..2b239751d8e8 100644
--- a/core/lib/Drupal/Component/Plugin/Factory/ReflectionFactory.php
+++ b/core/lib/Drupal/Component/Plugin/Factory/ReflectionFactory.php
@@ -32,7 +32,7 @@ public function createInstance($plugin_id, array $configuration = []) {
}
/**
- * Inspects the plugin class and build a list of arguments for the constructor.
+ * Inspects the plugin class and builds a list of constructor arguments.
*
* This is provided as a helper method so factories extending this class can
* replace this and insert their own reflection logic.
diff --git a/core/lib/Drupal/Core/Access/AccessManagerInterface.php b/core/lib/Drupal/Core/Access/AccessManagerInterface.php
index 7fc86ad08a13..bfc7d1f04f12 100644
--- a/core/lib/Drupal/Core/Access/AccessManagerInterface.php
+++ b/core/lib/Drupal/Core/Access/AccessManagerInterface.php
@@ -12,7 +12,7 @@
interface AccessManagerInterface {
/**
- * Checks a named route with parameters against applicable access check services.
+ * Checks a named route with parameters against access check services.
*
* Determines whether the route is accessible or not.
*
diff --git a/core/lib/Drupal/Core/Access/AccessResult.php b/core/lib/Drupal/Core/Access/AccessResult.php
index 479867c083f3..386aba4f09ff 100644
--- a/core/lib/Drupal/Core/Access/AccessResult.php
+++ b/core/lib/Drupal/Core/Access/AccessResult.php
@@ -98,7 +98,7 @@ public static function forbiddenIf($condition, $reason = NULL) {
}
/**
- * Creates an allowed access result if the permission is present, neutral otherwise.
+ * Creates an access result if the permission is present, neutral otherwise.
*
* Checks the permission and adds a 'user.permissions' cache context.
*
@@ -121,7 +121,7 @@ public static function allowedIfHasPermission(AccountInterface $account, $permis
}
/**
- * Creates an allowed access result if the permissions are present, neutral otherwise.
+ * Creates an access result if the permissions are present, neutral otherwise.
*
* Checks the permission and adds a 'user.permissions' cache contexts.
*
diff --git a/core/lib/Drupal/Core/Access/AccessResultForbidden.php b/core/lib/Drupal/Core/Access/AccessResultForbidden.php
index c6bf66c7eaa7..47856e3704ea 100644
--- a/core/lib/Drupal/Core/Access/AccessResultForbidden.php
+++ b/core/lib/Drupal/Core/Access/AccessResultForbidden.php
@@ -3,7 +3,7 @@
namespace Drupal\Core\Access;
/**
- * Value object indicating a forbidden access result, with cacheability metadata.
+ * Value object for a forbidden access result, with cacheability metadata.
*/
class AccessResultForbidden extends AccessResult implements AccessResultReasonInterface {
diff --git a/core/lib/Drupal/Core/Ajax/OpenModalDialogCommand.php b/core/lib/Drupal/Core/Ajax/OpenModalDialogCommand.php
index eae20c65d9ed..700aae4068a8 100644
--- a/core/lib/Drupal/Core/Ajax/OpenModalDialogCommand.php
+++ b/core/lib/Drupal/Core/Ajax/OpenModalDialogCommand.php
@@ -3,7 +3,7 @@
namespace Drupal\Core\Ajax;
/**
- * Defines an AJAX command to open certain content in a dialog in a modal dialog.
+ * An AJAX command to open certain content in a dialog in a modal dialog.
*
* @ingroup ajax
*/
diff --git a/core/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php b/core/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php
index 197d935909de..4fbec3231196 100644
--- a/core/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php
+++ b/core/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php
@@ -634,8 +634,8 @@ protected function setOverrideValue(array &$library, array $sub_key, array $over
protected function resolveThemeAssetPath($theme_path, $overriding_asset) {
if ($overriding_asset[0] !== '/' && !$this->isValidUri($overriding_asset)) {
// The destination is not an absolute path and it's not a URI (e.g.
- // public://generated_js/example.js or https://example.com/js/my_js.js), so
- // it's relative to the theme.
+ // public://generated_js/example.js or https://example.com/js/my_js.js),
+ // so it's relative to the theme.
return '/' . $theme_path . '/' . $overriding_asset;
}
return $overriding_asset;
diff --git a/core/lib/Drupal/Core/Cache/Context/AccountPermissionsCacheContext.php b/core/lib/Drupal/Core/Cache/Context/AccountPermissionsCacheContext.php
index af2766469c50..49133e22c2be 100644
--- a/core/lib/Drupal/Core/Cache/Context/AccountPermissionsCacheContext.php
+++ b/core/lib/Drupal/Core/Cache/Context/AccountPermissionsCacheContext.php
@@ -6,7 +6,7 @@
use Drupal\Core\Session\PermissionsHashGeneratorInterface;
/**
- * Defines the AccountPermissionsCacheContext service, for "per permission" caching.
+ * The account permission cache context for "per permission" caching.
*
* Cache context ID: 'user.permissions'.
*/
diff --git a/core/lib/Drupal/Core/Cache/Context/CalculatedCacheContextInterface.php b/core/lib/Drupal/Core/Cache/Context/CalculatedCacheContextInterface.php
index 74be67027cbd..77836d5f07fa 100644
--- a/core/lib/Drupal/Core/Cache/Context/CalculatedCacheContextInterface.php
+++ b/core/lib/Drupal/Core/Cache/Context/CalculatedCacheContextInterface.php
@@ -36,7 +36,7 @@ public static function getLabel();
public function getContext($parameter = NULL);
/**
- * Gets the cacheability metadata for the context based on the parameter value.
+ * Gets cacheability metadata for the context based on the parameter value.
*
* There are three valid cases for the returned CacheableMetadata object:
* - An empty object means this can be optimized away safely.
diff --git a/core/lib/Drupal/Core/Cache/MemoryCache/LruMemoryCache.php b/core/lib/Drupal/Core/Cache/MemoryCache/LruMemoryCache.php
index 5ac066cfbdc0..f64d1035d715 100644
--- a/core/lib/Drupal/Core/Cache/MemoryCache/LruMemoryCache.php
+++ b/core/lib/Drupal/Core/Cache/MemoryCache/LruMemoryCache.php
@@ -79,8 +79,8 @@ public function set($cid, $data, $expire = Cache::PERMANENT, array $tags = []):
}
elseif (count($this->cache) > $this->allowedSlots - 1) {
// Remove one item from the cache to ensure we remain within the allowed
- // number of slots. Avoid using array_slice() because it makes a copy of the
- // array, and avoid using array_splice() or array_shift() because they
+ // number of slots. Avoid using array_slice() because it makes a copy of
+ // the array, and avoid using array_splice() or array_shift() because they
// re-index numeric keys.
unset($this->cache[array_key_first($this->cache)]);
}
diff --git a/core/lib/Drupal/Core/Config/ConfigManagerInterface.php b/core/lib/Drupal/Core/Config/ConfigManagerInterface.php
index 2dc69635dd13..769c63ed5ee2 100644
--- a/core/lib/Drupal/Core/Config/ConfigManagerInterface.php
+++ b/core/lib/Drupal/Core/Config/ConfigManagerInterface.php
@@ -134,7 +134,7 @@ public function findConfigEntityDependencies($type, array $names);
public function findConfigEntityDependenciesAsEntities($type, array $names);
/**
- * Lists which config entities to update and delete on removal of a dependency.
+ * Lists config entities to update and delete on removal of a dependency.
*
* @param string $type
* The type of dependency being checked. Either 'module', 'theme', 'config'
diff --git a/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php b/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php
index d03c5dbb6703..c7edfa939587 100644
--- a/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php
+++ b/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php
@@ -233,7 +233,7 @@ public function createDuplicate() {
}
/**
- * Helper callback for uasort() to sort configuration entities by weight and label.
+ * Callback for uasort() to sort configuration entities by weight and label.
*/
public static function sort(ConfigEntityInterface $a, ConfigEntityInterface $b) {
$a_weight = $a->weight ?? 0;
diff --git a/core/lib/Drupal/Core/Config/FileStorage.php b/core/lib/Drupal/Core/Config/FileStorage.php
index 79153c6d9ba7..dc2c374bb966 100644
--- a/core/lib/Drupal/Core/Config/FileStorage.php
+++ b/core/lib/Drupal/Core/Config/FileStorage.php
@@ -63,7 +63,7 @@ public function getFilePath($name) {
}
/**
- * Returns the file extension used by the file storage for all configuration files.
+ * Gets the extension used by the file storage for all configuration files.
*
* @return string
* The file extension.
diff --git a/core/lib/Drupal/Core/Database/Log.php b/core/lib/Drupal/Core/Database/Log.php
index 62f1e1b88025..2949754c54f2 100644
--- a/core/lib/Drupal/Core/Database/Log.php
+++ b/core/lib/Drupal/Core/Database/Log.php
@@ -18,7 +18,9 @@
class Log {
/**
- * Cache of logged queries. This will only be used if the query logger is enabled.
+ * Cache of logged queries.
+ *
+ * This will only be used if the query logger is enabled.
*
* @var array
* The structure for the logging array is as follows:
diff --git a/core/lib/Drupal/Core/Database/Query/SelectInterface.php b/core/lib/Drupal/Core/Database/Query/SelectInterface.php
index 97bd2da4a12d..1b0873555e9a 100644
--- a/core/lib/Drupal/Core/Database/Query/SelectInterface.php
+++ b/core/lib/Drupal/Core/Database/Query/SelectInterface.php
@@ -152,7 +152,7 @@ public function escapeLike($string);
public function escapeField($string);
/**
- * Compiles and returns an associative array of the arguments for this prepared statement.
+ * Compiles and returns an array of the arguments for this prepared statement.
*
* @param \Drupal\Core\Database\Query\PlaceholderInterface|null $queryPlaceholder
* When collecting the arguments of a subquery, the main placeholder
diff --git a/core/lib/Drupal/Core/Database/Schema.php b/core/lib/Drupal/Core/Database/Schema.php
index 190f8816fa31..97e73b1bf8cb 100644
--- a/core/lib/Drupal/Core/Database/Schema.php
+++ b/core/lib/Drupal/Core/Database/Schema.php
@@ -143,7 +143,7 @@ protected function executeDdlStatement(string $sql, array $arguments = [], array
}
/**
- * Build a condition to match a table name against a standard information_schema.
+ * Builds a condition to match a table name against the information_schema.
*
* The information_schema is a SQL standard that provides information about
* the database server and the databases, schemas, tables, columns and users
@@ -676,7 +676,7 @@ protected function createTableSql($name, $table) {
}
/**
- * Return an array of field names from an array of key/index column specifiers.
+ * Gets an array of field names from an array of key/index column specifiers.
*
* This is usually an identity function but if a key/index uses a column
* prefix specification, this function extracts just the name.
diff --git a/core/lib/Drupal/Core/Database/StatementInterface.php b/core/lib/Drupal/Core/Database/StatementInterface.php
index 1f229373c4e4..b07553683076 100644
--- a/core/lib/Drupal/Core/Database/StatementInterface.php
+++ b/core/lib/Drupal/Core/Database/StatementInterface.php
@@ -151,7 +151,8 @@ public function fetchAssoc();
* @param int|null $column_index
* If $mode is FetchAs::Column, the index of the column to fetch.
* @param array $constructor_arguments
- * If $mode is FetchAs::ClassObject, the arguments to pass to the constructor.
+ * If $mode is FetchAs::ClassObject, the arguments to pass to the
+ * constructor.
*
* @return array
* An array of results.
diff --git a/core/lib/Drupal/Core/Database/TransactionOutOfOrderException.php b/core/lib/Drupal/Core/Database/TransactionOutOfOrderException.php
index d7b07df3ea73..b6061e50aa06 100644
--- a/core/lib/Drupal/Core/Database/TransactionOutOfOrderException.php
+++ b/core/lib/Drupal/Core/Database/TransactionOutOfOrderException.php
@@ -3,6 +3,9 @@
namespace Drupal\Core\Database;
/**
- * Exception thrown when a rollBack() resulted in other active transactions being rolled-back.
+ * Exception thrown transactions are out of order.
+ *
+ * This is thrown when a rollBack() resulted in other active transactions being
+ * rolled-back.
*/
class TransactionOutOfOrderException extends TransactionException implements DatabaseException {}
diff --git a/core/lib/Drupal/Core/DependencyInjection/Compiler/BackwardsCompatibilityClassLoaderPass.php b/core/lib/Drupal/Core/DependencyInjection/Compiler/BackwardsCompatibilityClassLoaderPass.php
index d698b45cde00..c56fc46d3b7b 100644
--- a/core/lib/Drupal/Core/DependencyInjection/Compiler/BackwardsCompatibilityClassLoaderPass.php
+++ b/core/lib/Drupal/Core/DependencyInjection/Compiler/BackwardsCompatibilityClassLoaderPass.php
@@ -8,7 +8,7 @@
use Symfony\Component\DependencyInjection\ContainerBuilder;
/**
- * Defines a compiler pass to merge moved classes into a single container parameter.
+ * Compiler pass to merge moved classes into a single container parameter.
*/
class BackwardsCompatibilityClassLoaderPass implements CompilerPassInterface {
diff --git a/core/lib/Drupal/Core/DrupalKernel.php b/core/lib/Drupal/Core/DrupalKernel.php
index 268173914637..221164875ef3 100644
--- a/core/lib/Drupal/Core/DrupalKernel.php
+++ b/core/lib/Drupal/Core/DrupalKernel.php
@@ -1468,7 +1468,7 @@ protected function getHttpKernel() {
}
/**
- * Returns the active configuration storage to use during building the container.
+ * Gets the active configuration storage to use during building the container.
*
* @return \Drupal\Core\Config\StorageInterface
* The configuration storage.
diff --git a/core/lib/Drupal/Core/Entity/EntityLastInstalledSchemaRepositoryInterface.php b/core/lib/Drupal/Core/Entity/EntityLastInstalledSchemaRepositoryInterface.php
index af910bb69004..a4fcf968460e 100644
--- a/core/lib/Drupal/Core/Entity/EntityLastInstalledSchemaRepositoryInterface.php
+++ b/core/lib/Drupal/Core/Entity/EntityLastInstalledSchemaRepositoryInterface.php
@@ -125,7 +125,7 @@ public function deleteLastInstalledDefinition($entity_type_id);
public function getLastInstalledFieldStorageDefinitions($entity_type_id);
/**
- * Stores the entity type's field storage definitions in the application state.
+ * Puts the entity type's field storage definitions in the application state.
*
* @param string $entity_type_id
* The entity type identifier.
diff --git a/core/lib/Drupal/Core/Entity/EntityReferenceSelection/SelectionInterface.php b/core/lib/Drupal/Core/Entity/EntityReferenceSelection/SelectionInterface.php
index d2f9bf3063c3..1504154bc52d 100644
--- a/core/lib/Drupal/Core/Entity/EntityReferenceSelection/SelectionInterface.php
+++ b/core/lib/Drupal/Core/Entity/EntityReferenceSelection/SelectionInterface.php
@@ -63,7 +63,7 @@ public function countReferenceableEntities($match = NULL, $match_operator = 'CON
public function validateReferenceableEntities(array $ids);
/**
- * Allows the selection to alter the SelectQuery generated by EntityFieldQuery.
+ * Allows altering the SelectQuery generated by EntityFieldQuery.
*
* @param \Drupal\Core\Database\Query\SelectInterface $query
* A Select Query object.
diff --git a/core/lib/Drupal/Core/Entity/EntityTypeInterface.php b/core/lib/Drupal/Core/Entity/EntityTypeInterface.php
index 4522902f76bb..fb11b64c2dd8 100644
--- a/core/lib/Drupal/Core/Entity/EntityTypeInterface.php
+++ b/core/lib/Drupal/Core/Entity/EntityTypeInterface.php
@@ -736,8 +736,8 @@ public function getListCacheTags();
/**
* The list cache tags associated with a specific bundle.
*
- * Enables code listing entities of this type and bundle to ensure that newly created
- * entities show up immediately.
+ * Enables code listing entities of this type and bundle to ensure that newly
+ * created entities show up immediately.
*
* @return string[]
* An array of the cache tags for this bundle.
diff --git a/core/lib/Drupal/Core/Entity/EntityTypeListenerInterface.php b/core/lib/Drupal/Core/Entity/EntityTypeListenerInterface.php
index c5775eab29f1..ffeffed5e2ce 100644
--- a/core/lib/Drupal/Core/Entity/EntityTypeListenerInterface.php
+++ b/core/lib/Drupal/Core/Entity/EntityTypeListenerInterface.php
@@ -3,7 +3,7 @@
namespace Drupal\Core\Entity;
/**
- * Defines an interface for reacting to entity type creation, deletion, and updates.
+ * Interface for entity type create, delete and update operations.
*/
interface EntityTypeListenerInterface {
diff --git a/core/lib/Drupal/Core/Entity/Query/ConditionAggregateBase.php b/core/lib/Drupal/Core/Entity/Query/ConditionAggregateBase.php
index 27ec70ce98be..db9bbcad6d5d 100644
--- a/core/lib/Drupal/Core/Entity/Query/ConditionAggregateBase.php
+++ b/core/lib/Drupal/Core/Entity/Query/ConditionAggregateBase.php
@@ -3,7 +3,7 @@
namespace Drupal\Core\Entity\Query;
/**
- * Defines a common base class for all aggregation entity condition implementations.
+ * A common base class for all aggregation entity condition implementations.
*/
abstract class ConditionAggregateBase extends ConditionFundamentals implements ConditionAggregateInterface {
diff --git a/core/lib/Drupal/Core/Extension/ExtensionNameLengthException.php b/core/lib/Drupal/Core/Extension/ExtensionNameLengthException.php
index ceb2d1cac665..9611b888e41c 100644
--- a/core/lib/Drupal/Core/Extension/ExtensionNameLengthException.php
+++ b/core/lib/Drupal/Core/Extension/ExtensionNameLengthException.php
@@ -3,6 +3,6 @@
namespace Drupal\Core\Extension;
/**
- * Exception thrown when the extension's name length exceeds the allowed maximum.
+ * Exception thrown when the extension's name length exceeds the maximum.
*/
class ExtensionNameLengthException extends \Exception {}
diff --git a/core/lib/Drupal/Core/Extension/InstallRequirementsInterface.php b/core/lib/Drupal/Core/Extension/InstallRequirementsInterface.php
index ca1ad6afd673..f2e8d7137c82 100644
--- a/core/lib/Drupal/Core/Extension/InstallRequirementsInterface.php
+++ b/core/lib/Drupal/Core/Extension/InstallRequirementsInterface.php
@@ -16,11 +16,12 @@ interface InstallRequirementsInterface {
* During the 'install' phase, modules can for example assert that
* library or server versions are available or sufficient.
* Note that the installation of a module can happen during installation of
- * Drupal itself (by install.php) with an installation profile or later by hand.
- * As a consequence, install-time requirements must be checked without access
- * to the full Drupal API, because it is not available during install.php.
- * If a requirement has a severity of REQUIREMENT_ERROR, install.php will abort
- * or at least the module will not install.
+ * Drupal itself (by install.php) with an installation profile or later by
+ * hand. As a consequence, install-time requirements must be checked without
+ * access to the full Drupal API, because it is not available during
+ * install.php.
+ * If a requirement has a severity of REQUIREMENT_ERROR, install.php will
+ * abort or at least the module will not install.
* Other severity levels have no effect on the installation.
* Module dependencies do not belong to these installation requirements,
* but should be defined in the module's .info.yml file.
diff --git a/core/lib/Drupal/Core/Extension/ModuleHandler.php b/core/lib/Drupal/Core/Extension/ModuleHandler.php
index 99e73d6bca09..1f9ff1cb0f63 100644
--- a/core/lib/Drupal/Core/Extension/ModuleHandler.php
+++ b/core/lib/Drupal/Core/Extension/ModuleHandler.php
@@ -202,8 +202,10 @@ protected function add($type, $name, $path) {
// A module freshly added will not be registered on the container yet.
// ProceduralCall service does not yet know about it.
// Note in HookCollectorPass:
+ // phpcs:ignore Drupal.Files.LineLength
// - $container->register(ProceduralCall::class, ProceduralCall::class)->addArgument($collector->includes);
- // Load all includes so the legacy section of invoke can handle hooks in includes.
+ // Load all includes so the legacy section of invoke can handle hooks in
+ // includes.
$hook_collector->loadAllIncludes();
// Register procedural implementations.
foreach ($hook_collector->getImplementations() as $hook => $moduleImplements) {
diff --git a/core/lib/Drupal/Core/Field/FieldStorageDefinitionListenerInterface.php b/core/lib/Drupal/Core/Field/FieldStorageDefinitionListenerInterface.php
index abb25c4e03f6..1ab9c5c1cd85 100644
--- a/core/lib/Drupal/Core/Field/FieldStorageDefinitionListenerInterface.php
+++ b/core/lib/Drupal/Core/Field/FieldStorageDefinitionListenerInterface.php
@@ -3,7 +3,7 @@
namespace Drupal\Core\Field;
/**
- * Defines an interface for reacting to field storage definition creation, deletion, and updates.
+ * Interface for field storage definition create, delete and update operations.
*/
interface FieldStorageDefinitionListenerInterface {
diff --git a/core/lib/Drupal/Core/Field/WidgetBase.php b/core/lib/Drupal/Core/Field/WidgetBase.php
index d130563c7067..6b408991cc02 100644
--- a/core/lib/Drupal/Core/Field/WidgetBase.php
+++ b/core/lib/Drupal/Core/Field/WidgetBase.php
@@ -625,6 +625,7 @@ public static function setWidgetState(array $parents, $field_name, FormStateInte
*/
protected static function getWidgetStateParents(array $parents, $field_name) {
// Field processing data is placed at
+ // phpcs:ignore Drupal.Files.LineLength
// $form_state->get(['field_storage', '#parents', ...$parents..., '#fields', $field_name]),
// to avoid clashes between field names and $parents parts.
return array_merge(['field_storage', '#parents'], $parents, ['#fields', $field_name]);
diff --git a/core/lib/Drupal/Core/Form/FormState.php b/core/lib/Drupal/Core/Form/FormState.php
index 2f25316037fb..7ec819333abb 100644
--- a/core/lib/Drupal/Core/Form/FormState.php
+++ b/core/lib/Drupal/Core/Form/FormState.php
@@ -383,7 +383,7 @@ class FormState implements FormStateInterface {
protected $has_file_element;
/**
- * Contains references to details elements to render them within vertical tabs.
+ * The references to details elements to render them within vertical tabs.
*
* This property is uncacheable.
*
diff --git a/core/lib/Drupal/Core/Language/LanguageInterface.php b/core/lib/Drupal/Core/Language/LanguageInterface.php
index a4b5acc9e62b..2894eb057128 100644
--- a/core/lib/Drupal/Core/Language/LanguageInterface.php
+++ b/core/lib/Drupal/Core/Language/LanguageInterface.php
@@ -36,7 +36,7 @@ interface LanguageInterface {
* Should be used when we explicitly know that the data referred has no
* linguistic content.
*
- * See https://www.w3.org/International/questions/qa-no-language#nonlinguistic.
+ * @see https://www.w3.org/International/questions/qa-no-language#nonlinguistic
*/
const LANGCODE_NOT_APPLICABLE = 'zxx';
diff --git a/core/lib/Drupal/Core/Routing/UrlGenerator.php b/core/lib/Drupal/Core/Routing/UrlGenerator.php
index 20cc4df72083..0133cf17254b 100644
--- a/core/lib/Drupal/Core/Routing/UrlGenerator.php
+++ b/core/lib/Drupal/Core/Routing/UrlGenerator.php
@@ -196,13 +196,24 @@ protected function doGenerate(array $variables, array $defaults, array $tokens,
// variables up to the start of the path must be supplied to there is no
// gap.
$optional = TRUE;
- // Structure of $tokens from the compiled route:
- // If the path is /admin/config/user-interface/shortcut/manage/{shortcut_set}/add-link-inline
- // [ [ 0 => 'text', 1 => '/add-link-inline' ], [ 0 => 'variable', 1 => '/', 2 => '[^/]++', 3 => 'shortcut_set' ], [ 0 => 'text', 1 => '/admin/config/user-interface/shortcut/manage' ] ]
+ // The structure of the tokens array varies according to the compiled route.
+ // Examples:
+ // @code
+ // [
+ // [0 => 'text', 1 => '/add-link-inline'],
+ // [0 => 'variable', 1 => '/', 2 => '[^/]++', 3 => 'shortcut_set'],
+ // [0 => 'text', 1 => '/admin/config/user-interface/shortcut/manage'],
+ // ]
+ // @endcode
+ // This is the structure for the "shortcut.link_add_inline" route.
//
- // For a simple fixed path, there is just one token.
- // If the path is /admin/config
- // [ [ 0 => 'text', 1 => '/admin/config' ] ]
+ // @code
+ // [
+ // [ 0 => 'text', 1 => '/admin/config' ]
+ // ]
+ // @endcode
+ // This is the structure for a simple fixed path, "/admin/config:. there is
+ // just one token.
foreach ($tokens as $token) {
if ('variable' === $token[0]) {
if (!$optional || !array_key_exists($token[3], $defaults) || (isset($mergedParams[$token[3]]) && (string) $mergedParams[$token[3]] !== (string) $defaults[$token[3]])) {
diff --git a/core/lib/Drupal/Core/StackMiddleware/Session.php b/core/lib/Drupal/Core/StackMiddleware/Session.php
index 2a3be0eea646..709369f6ddca 100644
--- a/core/lib/Drupal/Core/StackMiddleware/Session.php
+++ b/core/lib/Drupal/Core/StackMiddleware/Session.php
@@ -60,7 +60,7 @@ public function handle(Request $request, $type = self::MAIN_REQUEST, $catch = TR
}
/**
- * Initializes a session backed by persistent store and puts it on the request.
+ * Sets a session backed by persistent store and puts it on the request.
*
* Sessions for web requests need to be backed by a persistent session store
* and a real session handler (responsible for session cookie management).
diff --git a/core/lib/Drupal/Core/Validation/Plugin/Validation/Constraint/UniqueFieldValueValidator.php b/core/lib/Drupal/Core/Validation/Plugin/Validation/Constraint/UniqueFieldValueValidator.php
index 3bae5c3a5bce..857e2c1b0991 100644
--- a/core/lib/Drupal/Core/Validation/Plugin/Validation/Constraint/UniqueFieldValueValidator.php
+++ b/core/lib/Drupal/Core/Validation/Plugin/Validation/Constraint/UniqueFieldValueValidator.php
@@ -124,7 +124,9 @@ public function validate($items, Constraint $constraint): void {
}
/**
- * Perform a case-insensitive array intersection, but keep original capitalization.
+ * Performs a case-insensitive array intersection.
+ *
+ * This retains the capitalization of the original string.
*
* @param array $orig_values
* The original values to be returned.
diff --git a/core/phpcs.xml.dist b/core/phpcs.xml.dist
index baf5ecad909d..44940ee0ea74 100644
--- a/core/phpcs.xml.dist
+++ b/core/phpcs.xml.dist
@@ -109,6 +109,14 @@
<rule ref="Drupal.ControlStructures.InlineControlStructure"/>
<rule ref="Drupal.Files.EndFileNewline"/>
<rule ref="Drupal.Files.FileEncoding"/>
+ <rule ref="Drupal.Files.LineLength">
+ <include-pattern>*/core/lib/*</include-pattern>
+ <exclude-pattern>*/core/lib/*/*Trait</exclude-pattern>
+ <include-pattern>*/core/includes/*</include-pattern>
+ <include-pattern>*/core/profiles/*</include-pattern>
+ <include-pattern>*/core/recipes/*</include-pattern>
+ <include-pattern>*/core/themes/*</include-pattern>
+ </rule>
<rule ref="Drupal.Files.TxtFileLineLength"/>
<rule ref="Drupal.Formatting.MultiLineAssignment"/>
<rule ref="Drupal.Formatting.MultipleStatementAlignment"/>
diff --git a/core/profiles/demo_umami/modules/demo_umami_content/src/InstallHelper.php b/core/profiles/demo_umami/modules/demo_umami_content/src/InstallHelper.php
index d999eb873239..3d8e38c1d3bd 100644
--- a/core/profiles/demo_umami/modules/demo_umami_content/src/InstallHelper.php
+++ b/core/profiles/demo_umami/modules/demo_umami_content/src/InstallHelper.php
@@ -235,7 +235,7 @@ protected function saveTermId($vocabulary, $term_csv_id, $tid) {
}
/**
- * Retrieves the Media Image ID of a media image saved during the import process.
+ * Retrieves th ID of a media image saved during the import process.
*
* @param int $media_image_csv_id
* The media image's ID from the CSV file.
--
GitLab