From 04d38bc9797e03bbc798e2c93c3e78fdabf25f0b Mon Sep 17 00:00:00 2001
From: xjm <xjm@65776.no-reply.drupal.org>
Date: Mon, 4 Dec 2023 18:02:54 -0600
Subject: [PATCH] Issue #3403711 by mstrelan, smustgrave: Add
 declare(strict_types=1) to all Build tests

---
 core/phpcs.xml.dist                                         | 6 ++++++
 .../Composer/Component/ComponentsIsolatedBuildTest.php      | 2 ++
 .../Composer/Component/ComponentsTaggedReleaseTest.php      | 2 ++
 .../Drupal/BuildTests/Composer/ComposerBuildTestBase.php    | 2 ++
 .../Drupal/BuildTests/Composer/ComposerValidateTest.php     | 2 ++
 .../Composer/Template/ComposerProjectTemplatesTest.php      | 2 ++
 core/tests/Drupal/BuildTests/Framework/BuildTestBase.php    | 2 ++
 .../Framework/ExternalCommandRequirementsTrait.php          | 2 ++
 .../Drupal/BuildTests/Framework/Tests/BuildTestTest.php     | 2 ++
 .../Framework/Tests/ExternalCommandRequirementTest.php      | 2 ++
 .../Drupal/BuildTests/Framework/Tests/HtRouterTest.php      | 2 ++
 .../Drupal/BuildTests/QuickStart/QuickStartTestBase.php     | 2 ++
 .../Drupal/BuildTests/TestSiteApplication/InstallTest.php   | 2 ++
 13 files changed, 30 insertions(+)

diff --git a/core/phpcs.xml.dist b/core/phpcs.xml.dist
index ed5acf2e732d..015d8633e3bb 100644
--- a/core/phpcs.xml.dist
+++ b/core/phpcs.xml.dist
@@ -268,6 +268,12 @@
        </property>
     </properties>
   </rule>
+  <rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes">
+    <properties>
+      <property name="spacesCountAroundEqualsSign" value="0" />
+    </properties>
+    <include-pattern>./tests/Drupal/BuildTests/*</include-pattern>
+  </rule>
 
   <!-- Squiz sniffs -->
   <rule ref="Squiz.Arrays.ArrayBracketSpacing"/>
diff --git a/core/tests/Drupal/BuildTests/Composer/Component/ComponentsIsolatedBuildTest.php b/core/tests/Drupal/BuildTests/Composer/Component/ComponentsIsolatedBuildTest.php
index fe72a958a6b2..9891f10897ca 100644
--- a/core/tests/Drupal/BuildTests/Composer/Component/ComponentsIsolatedBuildTest.php
+++ b/core/tests/Drupal/BuildTests/Composer/Component/ComponentsIsolatedBuildTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\BuildTests\Composer\Component;
 
 use Drupal\BuildTests\Composer\ComposerBuildTestBase;
diff --git a/core/tests/Drupal/BuildTests/Composer/Component/ComponentsTaggedReleaseTest.php b/core/tests/Drupal/BuildTests/Composer/Component/ComponentsTaggedReleaseTest.php
index df12ea6b763c..ae3a08ec3627 100644
--- a/core/tests/Drupal/BuildTests/Composer/Component/ComponentsTaggedReleaseTest.php
+++ b/core/tests/Drupal/BuildTests/Composer/Component/ComponentsTaggedReleaseTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\BuildTests\Composer\Component;
 
 use Drupal\BuildTests\Composer\ComposerBuildTestBase;
diff --git a/core/tests/Drupal/BuildTests/Composer/ComposerBuildTestBase.php b/core/tests/Drupal/BuildTests/Composer/ComposerBuildTestBase.php
index 619fd8d10484..10f36d62fa09 100644
--- a/core/tests/Drupal/BuildTests/Composer/ComposerBuildTestBase.php
+++ b/core/tests/Drupal/BuildTests/Composer/ComposerBuildTestBase.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\BuildTests\Composer;
 
 use Drupal\BuildTests\Framework\BuildTestBase;
diff --git a/core/tests/Drupal/BuildTests/Composer/ComposerValidateTest.php b/core/tests/Drupal/BuildTests/Composer/ComposerValidateTest.php
index 13d726056410..f510a474d202 100644
--- a/core/tests/Drupal/BuildTests/Composer/ComposerValidateTest.php
+++ b/core/tests/Drupal/BuildTests/Composer/ComposerValidateTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\BuildTests\Composer;
 
 use Drupal\BuildTests\Framework\BuildTestBase;
diff --git a/core/tests/Drupal/BuildTests/Composer/Template/ComposerProjectTemplatesTest.php b/core/tests/Drupal/BuildTests/Composer/Template/ComposerProjectTemplatesTest.php
index 9fd3d4f000b9..23d0dbbf68e6 100644
--- a/core/tests/Drupal/BuildTests/Composer/Template/ComposerProjectTemplatesTest.php
+++ b/core/tests/Drupal/BuildTests/Composer/Template/ComposerProjectTemplatesTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\BuildTests\Composer\Template;
 
 use Composer\Json\JsonFile;
diff --git a/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php b/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php
index ded5b3104128..f566064807d5 100644
--- a/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php
+++ b/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\BuildTests\Framework;
 
 use Behat\Mink\Driver\BrowserKitDriver;
diff --git a/core/tests/Drupal/BuildTests/Framework/ExternalCommandRequirementsTrait.php b/core/tests/Drupal/BuildTests/Framework/ExternalCommandRequirementsTrait.php
index a3eb94ea49a6..68635e21676e 100644
--- a/core/tests/Drupal/BuildTests/Framework/ExternalCommandRequirementsTrait.php
+++ b/core/tests/Drupal/BuildTests/Framework/ExternalCommandRequirementsTrait.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\BuildTests\Framework;
 
 use PHPUnit\Framework\SkippedTestError;
diff --git a/core/tests/Drupal/BuildTests/Framework/Tests/BuildTestTest.php b/core/tests/Drupal/BuildTests/Framework/Tests/BuildTestTest.php
index 5eeca68e12ea..d58fdacc5fb7 100644
--- a/core/tests/Drupal/BuildTests/Framework/Tests/BuildTestTest.php
+++ b/core/tests/Drupal/BuildTests/Framework/Tests/BuildTestTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\BuildTests\Framework\Tests;
 
 use Drupal\BuildTests\Framework\BuildTestBase;
diff --git a/core/tests/Drupal/BuildTests/Framework/Tests/ExternalCommandRequirementTest.php b/core/tests/Drupal/BuildTests/Framework/Tests/ExternalCommandRequirementTest.php
index ccbbd7261a84..8d260cb827e1 100644
--- a/core/tests/Drupal/BuildTests/Framework/Tests/ExternalCommandRequirementTest.php
+++ b/core/tests/Drupal/BuildTests/Framework/Tests/ExternalCommandRequirementTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\BuildTests\Framework\Tests;
 
 use Drupal\BuildTests\Framework\ExternalCommandRequirementsTrait;
diff --git a/core/tests/Drupal/BuildTests/Framework/Tests/HtRouterTest.php b/core/tests/Drupal/BuildTests/Framework/Tests/HtRouterTest.php
index 9e90a19270e0..19c439c876d5 100644
--- a/core/tests/Drupal/BuildTests/Framework/Tests/HtRouterTest.php
+++ b/core/tests/Drupal/BuildTests/Framework/Tests/HtRouterTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\BuildTests\Framework\Tests;
 
 use Drupal\BuildTests\QuickStart\QuickStartTestBase;
diff --git a/core/tests/Drupal/BuildTests/QuickStart/QuickStartTestBase.php b/core/tests/Drupal/BuildTests/QuickStart/QuickStartTestBase.php
index 3424c228132f..1ee4602e636a 100644
--- a/core/tests/Drupal/BuildTests/QuickStart/QuickStartTestBase.php
+++ b/core/tests/Drupal/BuildTests/QuickStart/QuickStartTestBase.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\BuildTests\QuickStart;
 
 use Drupal\BuildTests\Framework\BuildTestBase;
diff --git a/core/tests/Drupal/BuildTests/TestSiteApplication/InstallTest.php b/core/tests/Drupal/BuildTests/TestSiteApplication/InstallTest.php
index cc431a9aa855..a97099ecb1d1 100644
--- a/core/tests/Drupal/BuildTests/TestSiteApplication/InstallTest.php
+++ b/core/tests/Drupal/BuildTests/TestSiteApplication/InstallTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\BuildTests\TestSiteApplication;
 
 use Drupal\BuildTests\Framework\BuildTestBase;
-- 
GitLab