Issue #2421849 by amateescu: Make SelectionBase::buildEntityQuery() protected

core/lib/Drupal/Core/Entity/Plugin/EntityReferenceSelection/SelectionBase.php

@@ -329,7 +329,7 @@ public function validateAutocompleteInput($input, &$element, FormStateInterface
    *   The EntityQuery object with the basic conditions and sorting applied to
    *   it.
    */
-  public function buildEntityQuery($match = NULL, $match_operator = 'CONTAINS') {
+  protected function buildEntityQuery($match = NULL, $match_operator = 'CONTAINS') {
     $target_type = $this->configuration['target_type'];
     $handler_settings = $this->configuration['handler_settings'];
     $entity_type = $this->entityManager->getDefinition($target_type);

core/modules/comment/src/Plugin/EntityReferenceSelection/CommentSelection.php

@@ -27,7 +27,7 @@ class CommentSelection extends SelectionBase {
   /**
    * {@inheritdoc}
    */
-  public function buildEntityQuery($match = NULL, $match_operator = 'CONTAINS') {
+  protected function buildEntityQuery($match = NULL, $match_operator = 'CONTAINS') {
     $query = parent::buildEntityQuery($match, $match_operator);
 
     // Adding the 'comment_access' tag is sadly insufficient for comments:

core/modules/file/src/Plugin/EntityReferenceSelection/FileSelection.php

@@ -25,7 +25,7 @@ class FileSelection extends SelectionBase {
   /**
    * {@inheritdoc}
    */
-  public function buildEntityQuery($match = NULL, $match_operator = 'CONTAINS') {
+  protected function buildEntityQuery($match = NULL, $match_operator = 'CONTAINS') {
     $query = parent::buildEntityQuery($match, $match_operator);
     $query->condition('status', FILE_STATUS_PERMANENT);
     return $query;

core/modules/node/src/Plugin/EntityReferenceSelection/NodeSelection.php

@@ -25,7 +25,7 @@ class NodeSelection extends SelectionBase {
   /**
    * {@inheritdoc}
    */
-  public function buildEntityQuery($match = NULL, $match_operator = 'CONTAINS') {
+  protected function buildEntityQuery($match = NULL, $match_operator = 'CONTAINS') {
     $query = parent::buildEntityQuery($match, $match_operator);
     // Adding the 'node_access' tag is sadly insufficient for nodes: core
     // requires us to also know about the concept of 'published' and

core/modules/user/src/Plugin/EntityReferenceSelection/UserSelection.php

@@ -130,7 +130,7 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta
   /**
    * {@inheritdoc}
    */
-  public function buildEntityQuery($match = NULL, $match_operator = 'CONTAINS') {
+  protected function buildEntityQuery($match = NULL, $match_operator = 'CONTAINS') {
     $query = parent::buildEntityQuery($match, $match_operator);
 
     // The user entity doesn't have a label column.