Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
10
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Open sidebar
project
drupal
Commits
0345c337
Unverified
Commit
0345c337
authored
Jul 21, 2020
by
alexpott
2
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue
#3160124
by jungle, jameszhang023, alexpott: Fix "wiget, escapeable, PHPunit" typos in Core
parent
1859ee95
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
8 additions
and
11 deletions
+8
-11
core/lib/Drupal/Core/Test/PhpUnitTestRunner.php
core/lib/Drupal/Core/Test/PhpUnitTestRunner.php
+1
-1
core/misc/cspell/dictionary.txt
core/misc/cspell/dictionary.txt
+0
-3
core/modules/media_library/tests/src/FunctionalJavascript/ViewsUiIntegrationTest.php
...tests/src/FunctionalJavascript/ViewsUiIntegrationTest.php
+1
-1
core/tests/Drupal/Tests/Component/Render/HtmlEscapedTextTest.php
...sts/Drupal/Tests/Component/Render/HtmlEscapedTextTest.php
+5
-5
core/tests/Drupal/Tests/Core/Test/PhpUnitTestRunnerTest.php
core/tests/Drupal/Tests/Core/Test/PhpUnitTestRunnerTest.php
+1
-1
No files found.
core/lib/Drupal/Core/Test/PhpUnitTestRunner.php
View file @
0345c337
...
...
@@ -217,7 +217,7 @@ public function runTests($test_id, array $unescaped_test_classnames, &$status =
'test_id'
=>
$test_id
,
'test_class'
=>
implode
(
","
,
$unescaped_test_classnames
),
'status'
=>
TestStatus
::
label
(
$status
),
'message'
=>
'PHP
u
nit Test failed to complete; Error: '
.
implode
(
"
\n
"
,
$output
),
'message'
=>
'PHP
U
nit Test failed to complete; Error: '
.
implode
(
"
\n
"
,
$output
),
'message_group'
=>
'Other'
,
'function'
=>
implode
(
","
,
$unescaped_test_classnames
),
'line'
=>
'0'
,
...
...
core/misc/cspell/dictionary.txt
View file @
0345c337
...
...
@@ -569,7 +569,6 @@ eridani
errmode
errored
errrf
escapeable
eslintignore
eslinting
espagnol
...
...
@@ -1392,7 +1391,6 @@ pseudotag
ptablenode
pterm
pulks
punit
puzzlepiece
pvde
pwprompt
...
...
@@ -2070,7 +2068,6 @@ whos
widget's
widt
widthx
wiget
wimoids
windir
winnt
...
...
core/modules/media_library/tests/src/FunctionalJavascript/ViewsUiIntegrationTest.php
View file @
0345c337
...
...
@@ -55,7 +55,7 @@ public function testViewsAdmin() {
$page
->
find
(
'css'
,
'.js-media-library-view .view-filters'
)
->
pressButton
(
'Apply filters'
);
$this
->
waitForElementsCount
(
'css'
,
'.js-media-library-item'
,
1
);
// Test the same routine but in the view for the table wiget.
// Test the same routine but in the view for the table wi
d
get.
$this
->
drupalGet
(
'/admin/structure/views/view/media_library/edit/widget_table'
);
$this
->
waitForElementsCount
(
'css'
,
'.js-media-library-item'
,
8
);
...
...
core/tests/Drupal/Tests/Component/Render/HtmlEscapedTextTest.php
View file @
0345c337
...
...
@@ -21,9 +21,9 @@ class HtmlEscapedTextTest extends TestCase {
* @dataProvider providerToString
*/
public
function
testToString
(
$text
,
$expected
,
$message
)
{
$escap
e
able_string
=
new
HtmlEscapedText
(
$text
);
$this
->
assertEquals
(
$expected
,
(
string
)
$escap
e
able_string
,
$message
);
$this
->
assertEquals
(
$expected
,
$escap
e
able_string
->
jsonSerialize
());
$escapable_string
=
new
HtmlEscapedText
(
$text
);
$this
->
assertEquals
(
$expected
,
(
string
)
$escapable_string
,
$message
);
$this
->
assertEquals
(
$expected
,
$escapable_string
->
jsonSerialize
());
}
/**
...
...
@@ -57,8 +57,8 @@ public function providerToString() {
*/
public
function
testCount
()
{
$string
=
'Can I please have a <em>kitten</em>'
;
$escap
e
able_string
=
new
HtmlEscapedText
(
$string
);
$this
->
assertEquals
(
strlen
(
$string
),
$escap
e
able_string
->
count
());
$escapable_string
=
new
HtmlEscapedText
(
$string
);
$this
->
assertEquals
(
strlen
(
$string
),
$escapable_string
->
count
());
}
}
core/tests/Drupal/Tests/Core/Test/PhpUnitTestRunnerTest.php
View file @
0345c337
...
...
@@ -57,7 +57,7 @@ function ($unescaped_test_classnames, $phpunit_file, &$status) {
'test_id'
=>
$test_id
,
'test_class'
=>
'SomeTest'
,
'status'
=>
TestStatus
::
label
(
TestStatus
::
EXCEPTION
),
'message'
=>
'PHP
u
nit Test failed to complete; Error: '
,
'message'
=>
'PHP
U
nit Test failed to complete; Error: '
,
'message_group'
=>
'Other'
,
'function'
=>
'SomeTest'
,
'line'
=>
'0'
,
...
...
alexpott
@alexpott
mentioned in commit
275ac5ab
·
Jul 21, 2020
mentioned in commit
275ac5ab
mentioned in commit 275ac5ab0e8dfb4c717020b8a400c1c3f5cf3633
Toggle commit list
alexpott
@alexpott
mentioned in commit
fd2f9a07
·
Jul 21, 2020
mentioned in commit
fd2f9a07
mentioned in commit fd2f9a07a0af2b36592962d0b3dde6e58963bdcb
Toggle commit list
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment