• Dries's avatar
    · aed1b0ca
    Dries authored
    - Patch #5347 by JonBob:
    
    Here's a new patch that unifies the node/52 and book/view/52 paths for nodes. It involves a small change to hook_view(), which is discussed first:
    
    Currently hook_view() expects node modules to return a themed node. However, each module does this the same way; they modify $node as necessary, then call theme('node', $node) and return the result. We can refactor this so that the calling function node_view() calls theme('node') instead. By doing this, it becomes possible for hook_nodeapi('view') to be called after hook_view() where the node contents are filtered, and before theme('node') where the body is enclosed in other HTML. This way the book module can insert its navigation into the body right before the theming.
    
    Advantages of this refactoring:
    - I can use it for book.module to remove the extra viewing path.
    - The function of hook_nodeapi('view') becomes more like hook_view(), as neither will expect a return value.
    - We more closely follow the flow of other nodeapi calls, which usually directly follow their corresponding specific node type hooks (instead of preceding them).
    - The attachment.module people could use it to append their attachments in a list after the node.
    - Gabor could use it instead of his filter perversion for his "articles in a series" module.
    - A little less code in each view hook.
    - The content hook is no longer needed, so that means even less code.
    
    Disadvantages:
    - Any modules written to use nodeapi('view') could be affected (but these would all be post-4.4 modules).
    - Implementations of hook_view() would need to be updated (but return values would be ignored, so most would work without updates anyway).
    
    Now the patch takes advantage of this API shift to inject its navigation at the end of all book nodes, regardless of the viewing path. In fact, since the paths become identical, I've removed the book/view handler entirely. We should probably provide an .htaccess rewrite for this (one is still needed for node/view/nn anyway). At the same time, there is a check in book_block() that shows the block appropriately on these pages.
    aed1b0ca
To find the state of this project's repository at the time of any of these versions, check out the tags.
CHANGELOG.txt 16.5 KB