>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3618606. --> Reported by: [mably](https://www.drupal.org/user/3375160) Related to !52 >>> <h3>Problem/Motivation</h3> <p>The domain project now has a 4.x branch that requires <code>^11.4 || ^12</code> and drops Drupal 10, and a 4.x branch already exists here at the same commit as 3.x. domain_extras still declared <code>^10.2 || ^11</code> and required <code>drupal/domain: ^3.1.0-alpha4</code>, so nothing on the branch targeted domain 4.x or Drupal 12.</p> <p>The 3.x branch stays on domain 3.1 and Drupal 10/11. This issue makes 4.x depend on domain 4.x and run both the current (11.4) and next-major (12) CI lanes.</p> <h3>Proposed resolution</h3> <p>Version metadata:</p> <ul> <li>All 16 <code>.info.yml</code> files move to <code>core_version_requirement: ^11.4 || ^12</code>.</li> <li><code>composer.json</code> requires <code>drupal/domain: ^4.0@dev</code>. No 4.x release is tagged yet, so a dev constraint is the only one that resolves; it tightens to <code>^4</code> once domain tags an alpha.</li> <li><code>.gitlab-ci.yml</code> turns the previous-major lane off and the next-major lane on.</li> <li><code>_LENIENT_ALLOW_LIST</code> covers admin_toolbar, page_manager, linkit and ctools. The first three are development dependencies that do not declare Drupal 12 support. ctools is not a dependency of this project at all: page_manager requires it, and its own core requirement stops at Drupal 11, which is enough to block the whole next-major resolution.</li> <li>A <code>phpunit (next major)</code> override unsets <code>SYMFONY_DEPRECATIONS_HELPER</code> and points the deprecation filter at a project <code>.deprecation-ignore.txt</code>, the same block the domain project needed on its 4.x branch. The ignored pattern is scoped to the namespaces around this project, so the same warning on one of its own classes still fails the lane.</li> </ul> <p>Code that only existed for Drupal 10:</p> <ul> <li>The eight <code>.module</code> files that held nothing but <code>#[LegacyHook]</code> procedural wrappers are deleted; the <code>#[Hook]</code> classes already carry every implementation on 11.4.</li> <li><code>domain_config_switcher_module_implements_alter()</code> is removed. <code>hook_module_implements_alter()</code> is removed in Drupal 12, and it only existed to reproduce, on Drupal 10, the ordering that <code>#[Hook]</code> attributes give natively.</li> <li><code>DomainNegotiationMiddleware</code> loses the branch it kept for Drupal below 11.1, which can never be taken on this floor.</li> <li>Two tests dropped a <code>markTestSkipped()</code> guard on domain_config's diff bridge, which <code>drupal/domain: ^4</code> guarantees. A skipped test reads as a pass, so the guard was hiding coverage.</li> <li>Comments, a form description and one docs page that documented Drupal 10 behavior are swept.</li> </ul> <p>Drupal 12 compatibility, including three things only the next-major pipeline could show:</p> <ul> <li><strong>A real forward-compatibility bug.</strong> Core 11.5 added a tenth argument to <code>LocalTaskManager::__construct()</code> that becomes required in 12.0. <code>DomainAwareLocalTaskManager</code> restated core's nine parameters and put its own context last, so core's new argument lands in the slot reserved for the domain context and the parent never receives it. The context now arrives through <code>setDomainContext()</code> and the subclass declares no constructor at all, which is what the service provider already promised. Its test double copies the real service's state instead of naming core's arguments, for the same reason.</li> <li>Ten methods gained the native return types core is about to require, rather than <code>@return</code> annotations.</li> <li>The Drupal 7 migration submodules are removed. Drupal 12 deletes core's D6/D7 migrate source plugins outright and leaves <code>migrate_drupal</code> an empty shell marked <code>lifecycle: obsolete</code>, so <code>domain_access_migrate</code> could not even compile there (it extends core's deleted d7 <code>Node</code> and <code>User</code> sources) and <code>domain_migrate</code> had no framework left to feed. Both stay on 3.x, which is where a Drupal 7 site migrates from.</li> <li>The linkit matcher annotation becomes a <code>#[Matcher]</code> attribute: the annotation is deprecated, and the next-major lane runs with <code>--fail-on-deprecation</code>.</li> </ul> <p>Tests, for the PHPUnit that Drupal 12 ships:</p> <ul> <li>The 16 class-level <code>@group</code> annotations are removed: PHPUnit 12 drops doc-comment metadata entirely.</li> <li>Four classes carried <code>@group</code> and no attribute at all, so on PHPUnit 12 they would have had no group. They gain <code>#[Group]</code> and <code>#[RunTestsInSeparateProcesses]</code>, matching the other twelve. <code>DomainMaintenanceModeTest</code> was grouped <code>domain_sso</code> by a copy-paste; it is now <code>domain_maintenance</code>.</li> <li><code>installSchema('system', ['sequences'])</code> and two <code>ReflectionProperty::setAccessible()</code> calls are gone.</li> <li>An expectation-free <code>createMock()</code> becomes <code>createStub()</code>. PHPUnit raises a notice for the former, and the phpunit configuration Drupal 12 ships turns that notice into a failure.</li> <li><code>DomainMaintenanceModeTest</code> asserted the maintenance page on the front page, which is exempt from maintenance mode whenever it resolves to the login route, and that is where core's install profile points it on Drupal 12. It now asserts on a path maintenance mode covers, and opens registration so that path is reachable whatever the profile sets. It also no longer depends on the frontpage view, which Drupal 12 disables.</li> </ul> <p>PHPStan moves from the default configuration to level 3, matching what the domain project did in <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-2"><a href="https://www.drupal.org/project/domain/issues/3616760" title="Status: Fixed">#3616760: Raise phpstan analysis from level 2 -&gt; 3</a></span>. The project shipped no <code>phpstan.neon</code> at all, so the job was running at PHPStan's default level and reporting three errors under an <code>allow_failure</code> job. Level 3 needed one real docblock fix (a <code>@var</code> missing its leading backslash), an <code>entity_mapping.neon</code> so domain storage and entity calls resolve, and three narrowings in tests and one storage trait. There is no baseline and no new suppression beyond the <code>new static()</code> line domain also carries.</p> <h3>Remaining tasks</h3> <p>None known. Every job on the merge request pipeline is green, including <code>phpunit (next major)</code> and <code>phpstan (next major)</code>: 16 test classes and 62 tests pass on both Drupal 11.4 and Drupal 12. Note that every lint and next-major job is <code>allow_failure</code> on drupal.org, so the pipeline badge is not evidence on its own; the job statuses are.</p> <p>Related: <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/domain_extras/-/work_items/3597278" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/domain_extras/-/work_items/3597278</a></span> is the update bot's Drupal 12 issue for 3.x. Its open merge request independently confirmed two of the items above, the <code>sequences</code> schema and the <code>setAccessible()</code> calls.</p> <h3>AI-Generated: Yes</h3> <p>AI-Generated: Yes (Claude Code was used to help draft this issue summary and to write the code and tests on the merge request. I reviewed and ran the work myself before posting it.)</p>