>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3514467. --> Reported by: [jamsilver](https://www.drupal.org/user/476732) Related to !38 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>Drupal 10.3.0 introduced a new hook_entity_query_alter() API (see <a href="https://www.drupal.org/node/3363939">change record here</a>).</p> <p>Due to the following coincidences:</p> <ul> <li>This module's name equals the name of some other module (<code>domain</code>) plus the suffix <code>_entity</code>,</li> <li>This module implements <code>hook_query_alter()</code>,</li> <li>Drupal *.module files are loaded globally on all requests for all enabled modules.</li> </ul> <p>The function <code>domain_entity_query_alter()</code> is considered by core to be an implementation of <code>hook_entity_query_alter()</code> for the <code>domain</code> module. (This is <i>in addition to</i> being considered an implementation of <code>hook_query_alter()</code> for the <code>domain_entity</code> module, as originally intended).</p> <p>The only reason this does not throw an immediate Fatal Error (at least in my case) is because, of the following coincidences:</p> <ul> <li> <a href="https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Database%21database.api.php/function/hook_query_alter/10">hook_query_alter()</a> is covariant in its parameter type with respect to <a href="https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21entity.api.php/function/hook_entity_query_alter/10">hook_entity_query_alter()</a>. (Entity Query instances implement the same <code>AlterableInterface</code> as DB queries do).</li> <li><code>domain_entity_query_alter()</code> starts with quite a general check for <code>method_exists($query, 'getTables')</code> (<a href="https://git.drupalcode.org/project/domain_entity/-/commit/87cd6b217a3c843d60d1aa73cb30be3632ac9b6b">added 8 years ago</a>) which fails in the hook_entity_query_alter() case, skipping the function. </li> </ul> <p>This is something I discovered while debugging something unrelated. In my situation it doesn't break anything, but I thought I'd bring it to the attention of the module maintainers, as surely it is not the intention for this to be so, it strikes me as quite fragile? </p> <p>For example: If a getTables method were added to Entity queries, or if the <a href="http://drupal.org/project/domain">Domain module</a> added its own <code>hook_entity_query_alter()</code> implementation, things would break horribly.</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>I suppose renaming the module is out of the question, but perhaps it would be a good idea to add this kind of check to the top of the function?</p> <div class="codeblock"> <pre><span style="color: #000000"><span style="color: #0000BB">&lt;?php<br></span><span style="color: #FF8000">// Due to various coincidences this function is incorrectly interpreted, as of Drupal 10.3.0,<br>// as an implementation of hook_entity_query_alter(). No thanks.<br></span><span style="color: #007700">if (</span><span style="color: #0000BB">$query </span><span style="color: #007700">instanceof \</span><span style="color: #0000BB">Drupal</span><span style="color: #007700">\</span><span style="color: #0000BB">Core</span><span style="color: #007700">\</span><span style="color: #0000BB">Entity</span><span style="color: #007700">\</span><span style="color: #0000BB">Query</span><span style="color: #007700">\</span><span style="color: #0000BB">QueryInterface</span><span style="color: #007700">) {<br>&nbsp; return;<br>}<br></span><span style="color: #0000BB">?&gt;</span></span></pre></div>