Commit 7ffe37d5 authored by Dieter Holvoet's avatar Dieter Holvoet Committed by Adam G-H
Browse files

Issue #3256598 by DieterHolvoet, Berdir, anneke_vde: Deprecated function:... 

Issue #3256598 by DieterHolvoet, Berdir, anneke_vde: Deprecated function: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
parent b969dea9

src/DiffEntityComparison.php

+4 −1
Original line number Diff line number Diff line
@@ -268,7 +268,10 @@ class DiffEntityComparison { 
    $revision_summary = '';

    // Check if the revision has a revision log message.

    if ($revision instanceof RevisionLogInterface) {

      $revision_summary = Xss::filter($revision->getRevisionLogMessage());

      $revision_log_message = $revision->getRevisionLogMessage();

      if ($revision_log_message !== NULL) {

        $revision_summary = Xss::filter($revision_log_message);

      }

    }



    // @todo Autogenerate summary again.

src/DiffLayoutBase.php

+2 −2
Original line number Diff line number Diff line
@@ -166,7 +166,7 @@ abstract class DiffLayoutBase extends PluginBase implements DiffLayoutInterface, 
   */

  protected function buildRevisionData(ContentEntityInterface $revision) {

    if ($revision instanceof RevisionLogInterface) {

      $revision_log = Xss::filter($revision->getRevisionLogMessage());

      $revision_log = $revision->getRevisionLogMessage();

      $user_id = $revision->getRevisionUserId();



      $revision_link['date'] = [
@@ -192,7 +192,7 @@ abstract class DiffLayoutBase extends PluginBase implements DiffLayoutInterface, 
          '#type' => 'markup',

          '#prefix' => '<div class="diff-revision__item diff-revision__item-message">',

          '#suffix' => '</div>',

          '#markup' => $revision_log,

          '#markup' => Xss::filter($revision_log),

        ];

      }

    }