>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3581684. --> Reported by: [benstallings](https://www.drupal.org/user/210009) Related to !10 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>no test coverage.</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p> Test Layer: Unit Tests</p> <p> Unit tests mock all dependencies (database, config, logger, etc.) and test pure logic.</p> <p> 1. DeadLetterDatabaseQueueTest (the core of the module)</p> <p> - claimItem() increments tries counter on each claim<br> - claimItem() returns item normally when tries &lt; max_tries<br> - claimItem() triggers dead letter handling when tries &gt;= max_tries<br> - claimItem() calls handleDeadLetter() on workers implementing DeadLetterQueueWorkerInterface<br> - claimItem() does NOT call handleDeadLetter() on workers that don't implement the interface<br> - claimItem() deletes item when handleDeadLetter() throws DiscardDeadLetterException<br> - claimItem() resets tries to 0 when handleDeadLetter() throws RestoreDeadLetterException<br> - claimItem() logs dead letter events<br> - numberOfItems() excludes items where tries &gt;= max_tries<br> - releaseItem() decrements the tries counter<br> - resetItemTries() sets tries back to 0 for a given item ID<br> - getMaxTries() returns queue-specific config value when set<br> - getMaxTries() falls back to worker annotation cron['max_tries'] when no config<br> - getMaxTries() defaults to 10 when neither config nor annotation exists<br> - schemaDefinition() includes the 'tries' field</p> <p> 2. DeadLetterQueueDatabaseFactoryTest</p> <p> - get() returns a DeadLetterDatabaseQueue instance<br> - Dependencies (database, worker manager, config, logger) are passed through correctly</p> <p> 3. UniqueDeadLetterDatabaseQueueTest</p> <p> - doCreateItem() inserts items with SHA512 hash<br> - doCreateItem() returns FALSE on duplicate items (hash collision)<br> - hash() generates consistent hashes for the same input<br> - hash() generates different hashes for different queue names with same data<br> - schemaDefinition() includes hash field and unique key constraint<br> - Dead letter behavior inherited from parent class works correctly</p> <p> 4. UniqueDeadLetterQueueDatabaseFactoryTest</p> <p> - get() returns a UniqueDeadLetterDatabaseQueue instance</p> <p> 5. Exception tests (lightweight, may not be worth separate test classes)</p> <p> - DiscardDeadLetterException extends RuntimeException<br> - RestoreDeadLetterException extends RuntimeException</p> <p> Test Layer: Kernel Tests</p> <p> Kernel tests boot a real Drupal kernel with a test database. These are the most valuable tests for this module since the core logic is database<br> interaction.</p> <p> 6. DeadLetterDatabaseQueueKernelTest</p> <p> This is the most important test class. It exercises the real queue table with the tries column.</p> <p> - Create an item, claim it, verify tries = 1<br> - Claim and release repeatedly, verify tries increments and decrements correctly<br> - After max_tries claims, item is no longer returned by claimItem()<br> - numberOfItems() returns correct count excluding dead letters<br> - resetItemTries() makes a dead letter claimable again<br> - Full lifecycle: create -&gt; claim repeatedly -&gt; dead letter -&gt; reset -&gt; claim again<br> - Multiple items: only the item exceeding max_tries becomes a dead letter, others still process<br> - Verify the install hook adds the tries column correctly (via module install during test setup)</p> <p> 7. DeadLetterQueueConfigKernelTest</p> <p> - Per-queue max_tries from config overrides annotation default<br> - Changing config at runtime affects getMaxTries() return value<br> - Config schema validation (queues array structure)</p> <p> 8. UniqueDeadLetterDatabaseQueueKernelTest</p> <p> - Inserting duplicate data returns FALSE<br> - Inserting same data to different queue names succeeds (different hashes)<br> - Dead letter behavior works end-to-end with unique queue table<br> - Verify unique queue install hook adds tries column to queue_unique table</p> <p> Test Layer: UI Submodule (Kernel + Unit)</p> <p> 9. DeadLetterDatabaseQueueUiTest (Kernel)</p> <p> - getItems() excludes dead letters<br> - getDeadLetters() returns only items where tries &gt;= maxTries<br> - getNumberOfDeadLetters() returns correct count<br> - getOperations() includes "Reset tries" operation<br> - loadItem() returns item with tries field</p> <p> 10. DeadLettersFormTest (Unit or Kernel)</p> <p> - Form builds table with correct columns (ID, expires, created, tries, operations)<br> - Pagination works (test with &gt;25 items)<br> - Operations dropbutton includes View, Release, Delete, Reset tries</p> <p> 11. ConfirmItemResetTriesFormTest (Kernel)</p> <p> - Validates queue implements DeadLetterQueueInterface<br> - Submission calls resetItemTries() and shows success message<br> - Redirects to queue inspection view after submission</p> <p> 12. Overview form alter tests (Kernel)</p> <p> - Dead letter count column added to overview<br> - Max tries input field present and editable<br> - Submit handler saves max_tries to config correctly</p> <p> Priority Order</p> <p> If we're doing this incrementally:</p> <p> 1. DeadLetterDatabaseQueueKernelTest &mdash; highest value, tests the core claim/tries/dead-letter lifecycle against a real database<br> 2. DeadLetterDatabaseQueueTest (unit) &mdash; covers the branching logic in claimItem() (exception handling, worker interface checks)<br> 3. UniqueDeadLetterDatabaseQueueKernelTest &mdash; covers the unique variant<br> 4. DeadLetterQueueConfigKernelTest &mdash; covers config resolution<br> 5. UI tests &mdash; lower priority, more surface area but less critical logic</p> <p> Estimated Scope</p> <p> Roughly 12 test classes, ~60-70 test methods. The kernel tests for the core queue class and the unit tests for claimItem() branching logic cover the vast<br> majority of risk. The UI tests are nice-to-have but the module's value is in the queue behavior, not the admin screens.</p> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <p>write the tests and make an MR.</p>