>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3542751. --> Reported by: [trackleft2](https://www.drupal.org/user/2860655) Related to !34 !25 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p> Date AP Style's settings schema is present but not fully constrained, which prevents 100% config validation.<br> Drupal 10.2 introduced configuration validation constraints and <code>#config_target</code> so modules can strictly validate settings:<br> <a href="https://www.drupal.org/node/3376195">#3376195 Choice constraint for configuration schema</a>,<br> <a href="https://www.drupal.org/node/3373502">#3373502 Using validation constraints via <code>#config_target</code></a>. </p> <h4 id="summary-steps-reproduce">Steps to reproduce</h4> <ol> <li>Install Date AP Style module</li> <li>Run <code>drush config:inspect date_ap_style.settings</code></li> <li>Note configuration shows as validatable but without strict constraints</li> <li>Try setting invalid values like <code>drush config:set date_ap_style.settings separator "invalid"</code></li> <li>Invalid values are accepted without validation errors</li> <p> (Drush 13 will still allow setting invalid config, but a future version may enable config validation. ) </p></ol> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <ul> <li>Add strict constraints to <code>config/schema/date_ap_style.schema.yml</code>: <ul> <li><strong>separator</strong>: <code>Choice</code> with explicit options (<code>endash</code>, <code>to</code>).</li> <li><strong>timezone</strong>: <code>Choice</code> with <code>callback</code> to <code>DateTimeZone::listIdentifiers</code> (as per Drupal core's system module pattern).</li> <li>Add missing field formatter schema definitions for <code>timestamp_ap_style</code> and <code>daterange_ap_style</code>.</li> <li>Ensure schema defaults match <code>defaultConfiguration()</code>.</li> </ul> </li> <li>Refactor settings form to use <code>#config_target</code> for each element so schema constraints are enforced automatically on submit.</li> <li>Add comprehensive post-update function to: <ul> <li>Migrate legacy configuration names and structure</li> <li>Convert string/integer boolean values to proper boolean types</li> <li>Fix entity view display field formatter settings data types</li> <li>Handle both fresh installations and existing sites</li> </ul> </li> <li>Add tests: <ul> <li><em>Kernel</em>: Configuration validation with valid/invalid values.</li> <li><em>Functional</em>: UI shows inline errors when submitting invalid inputs.</li> </ul> </li> <li>Set/confirm minimum core version to <strong>10.2+</strong> (required for constraints + <code>#config_target</code> workflow).</li> </ul> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <ul> <li>[x] Add/adjust constraints in <code>date_ap_style.schema.yml</code> (separator Choice, timezone Choice callback).</li> <li>[x] Add missing field formatter schema definitions.</li> <li>[x] Update settings form elements to use <code>#config_target</code>.</li> <li>[x] Implement comprehensive <code>post_update</code> function to normalize existing config and handle data type conversions.</li> <li>[x] Deprecate <code>date_ap_style.date_ap_style.dateapstylesettings</code> schema .</li> <li>[x] Align schema defaults with <code>defaultConfiguration()</code>.</li> <li>[x] Write Kernel tests for invalid/valid config validation.</li> <li>[x] Ensure PHP strict types in all PHP files.</li> <li>[x] Write Functional tests for form validation.</li> <li>[x] Update composer.json to require core &ge;10.2.</li> </ul> <h3 id="summary-ui-changes">User interface changes</h3> <p> Simplified the default settings form by removing custom submit logic and leveraging <code>#config_target</code> for automatic configuration handling. Form validation now happens automatically through schema constraints. </p> <h3 id="summary-api-changes">API changes</h3> <p> Configuration schema now includes strict validation constraints. Sites using invalid configuration values will need to update them to valid options. </p> <h3 id="summary-data-model-changes">Data model changes</h3> <p> Boolean configuration values are now stored as proper boolean types instead of strings or integers. Legacy configurations are automatically migrated via post-update functions. </p> <hr> <h4>Release notes (when merged)</h4> <ul> <li>Configuration is now strictly validated using schema constraints and <code>#config_target</code>.</li> <li>Boolean values in configuration are now properly typed (migrated automatically).</li> <li>Field formatter settings in entity view displays are automatically cleaned up.</li> <li>Sites on Drupal 10.0&ndash;10.1 must upgrade core to &ge;10.2 before updating this module.</li> <li>Invalid timezone and separator values will now trigger validation errors.</li> </ul>